Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Let's Encrypt in core #9244

Closed
mik-jozef opened this issue Oct 23, 2016 · 8 comments
Closed

Support Let's Encrypt in core #9244

mik-jozef opened this issue Oct 23, 2016 · 8 comments
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Comments

@mik-jozef
Copy link

Mozilla annouced their intent to deprecate http over year and a half ago. Chrome plans to limit new features to https and mark http as non-secure. Having a https site will only get more and more important in the future and with browsers pushing https everywhere, I expect it will be essential for most Node users who who run a server.

Native Let's Encrypt support would make the complicated process of getting a certificate super easy.

@bnoordhuis
Copy link
Member

Can you come up with a more concrete implementation proposal than "let's do it"? I'll add the feature-request label.

@bnoordhuis bnoordhuis added tls Issues and PRs related to the tls subsystem. feature request Issues that request new features to be added to Node.js. labels Oct 23, 2016
@mik-jozef
Copy link
Author

When doing https.createServer(options), the options parameter could contain an array of domains and a path to store certificates. The server would check the path and if there are no certificates, it would do what certbot certonly does, using the array of domains provided to createServer(). It would also periodically do certbot renew.

I am not familiar with how letsencrypt works internally, so I cannot give any technical details. The reason I created this issue is that I am not very familiar with how https certification works and I guess most people aren't, too. Mozilla's announcement created complaints that having to obtain a certificate will be hard for small websites and if most people will need it in the future, I think it's important for this process to be simple.

@mscdex
Copy link
Contributor

mscdex commented Oct 23, 2016

-1 from me, node core shouldn't be in the business of maintaining SSL certificates. That kind of thing is best left to userland.

@PaulBGD
Copy link

PaulBGD commented Oct 24, 2016

I disagree with this as well. I think Let's Encrypt is great, but in the end it's just regenerating certificates and that can be done with the hundreds of tools already created.

@mcollina
Copy link
Member

I think we should put out an official guide in the docs on how to do this with libraries on userland.
This is usually an exceptionally painful process, so an "official" take on how to solve the problem would be very handy for newcomers.

@PaulBGD
Copy link

PaulBGD commented Oct 24, 2016

@mcollina As well we could contribute to the certbot website, which has a dropdown supporting different web servers already.
Website: https://certbot.eff.org/
GitHub: https://github.com/certbot/website

@mcollina
Copy link
Member

@PaulBGD yes of course!

@sam-github
Copy link
Contributor

Not going to happen as a feature in core, I added an issue for a guide if anyone has time to work on it: nodejs/docs#117

@sam-github sam-github added doc Issues and PRs related to the documentations. and removed feature request Issues that request new features to be added to Node.js. labels Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

No branches or pull requests

6 participants