Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adding Italo A. Casas PGP Fingerprint #11202

Closed

Conversation

italoacasas
Copy link
Contributor

Adding my PGP Fingerprint to the release team.

CTC vote: nodejs/CTC#48

I have been doing the first part of the release for the last 2 or 3 releases in the current branch (7.x), this week release (7.6.0) is going to be a small one and is going to be easier for me to do the complete release. I ask Evan Lucas in IRC and he is going to help me in the process.

Pending Items:

  • Be accepted in the release team in Github (I request access already)
  • Access to the release CI
  • Merge this PR

cc: @nodejs/release @evanlucas

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 6, 2017
@bnoordhuis
Copy link
Member

bnoordhuis commented Feb 6, 2017

Have you uploaded your (EDIT: public) key to https://sks-keyservers.net/? I can't seem to find you.

@italoacasas
Copy link
Contributor Author

italoacasas commented Feb 6, 2017

@bnoordhuis I did it but seems like is not working :(, working on that.

Fixed.

Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe wait to get signoff from a few other members of @nodejs/release since there are some additional steps to be taken (like getting your public key for promoting the binaries)

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once all the necessary other steps are complete :-)

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the key to the list below (line 378) that includes that command to import the key from the keyserver.

Once this is done I give permission to anyone to change my review to approved

@MylesBorins
Copy link
Contributor

I've verified that gpg --keyserver pool.sks-keyservers.net --recv-keys 56730D5401028683275BD3C23EFEFE93C4CFFFE works as expected. I have also taken the liberty of signing the key and sending it to the public key server

@italoacasas
Copy link
Contributor Author

I add the command as requested. Thanks, everyone.

jasnell pushed a commit that referenced this pull request Feb 11, 2017
PR-URL: #11202
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 11, 2017

Landed in c8fff70

@jasnell jasnell closed this Feb 11, 2017
italoacasas added a commit that referenced this pull request Feb 13, 2017
PR-URL: #11202
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017
PR-URL: nodejs#11202
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@italoacasas italoacasas deleted the readme/key-fingerprint branch February 20, 2017 01:30
@italoacasas italoacasas restored the readme/key-fingerprint branch February 20, 2017 01:30
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
PR-URL: nodejs#11202
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11202
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11202
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #11202
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #11202
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants