test: improve checks in test-path-parse-format #11223

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
6 participants
@cjihrig
Contributor

cjihrig commented Feb 7, 2017

  • validate full error messages
  • use assert.throws() instead of try...catch
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@jasnell

jasnell approved these changes Feb 7, 2017

@mscdex mscdex added the path label Feb 7, 2017

@jasnell

jasnell approved these changes Feb 7, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
test: improve checks in test-path-parse-format
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: #11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

@cjihrig cjihrig merged commit 0700927 into nodejs:master Feb 9, 2017

@cjihrig cjihrig deleted the cjihrig:path-test branch Feb 9, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

test: improve checks in test-path-parse-format
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: #11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: improve checks in test-path-parse-format
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: nodejs#11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: improve checks in test-path-parse-format
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: nodejs#11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

Would require a backport PR to land in v4

Member

jasnell commented Mar 7, 2017

Would require a backport PR to land in v4

jasnell added a commit that referenced this pull request Mar 7, 2017

test: improve checks in test-path-parse-format
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: #11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: improve checks in test-path-parse-format
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: #11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment