Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
inspector: make `debug` an alias for `inspect` #11441
lib / src
Feb 17, 2017
changed the title from
inspector: make `debug` and alias for `inspect`
inspector: make `debug` an alias for `inspect`
Feb 22, 2017
referenced this pull request
Feb 24, 2017
Summary: I think we should wait to alias
debug till Node integrates V8 5.8+, and not at the start of Node 8, assuming Node 8 uses V8 5.7. This provides more notification time for those depending on the legacy interface.
Also, there's a lot of code here unrelated to aliasing
debug. Could that be separated into another PR? It would make review easier. Thanks!
Rebased. I needed to cherry-pick a fix from node-inspect. This is ready for review again.
code LGTM, a couple considerations in comments though