Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change Mac OS X to macOS #12106

Closed
wants to merge 3 commits into from

Conversation

@jrmce
Copy link
Contributor

commented Mar 28, 2017

This update changes references to "Mac OS X", "OS X", and "OSX" in
markdown files to "macOS".

Fixes: #12086

Checklist
Affected core subsystem(s)

doc

doc/api/fs.md Outdated
@@ -1374,12 +1374,12 @@ The kernel ignores the position argument and always appends the data to
the end of the file.

_Note: The behavior of `fs.open()` is platform specific for some flags. As such,
opening a directory on OS X and Linux with the `'a+'` flag - see example below -
opening a directory on macOS and Linux with the `'a+'` flag - see example below -

This comment has been minimized.

Copy link
@vsemozhetbyt

vsemozhetbyt Mar 29, 2017

Contributor

It seems this line length is more than 80 characters.

doc/api/process.md Outdated
@@ -1631,7 +1631,7 @@ the current value of `ps`.

*Note*: When a new value is assigned, different platforms will impose different
maximum length restrictions on the title. Usually such restrictions are quite
limited. For instance, on Linux and OS X, `process.title` is limited to the size
limited. For instance, on Linux and macOS, `process.title` is limited to the size

This comment has been minimized.

Copy link
@vsemozhetbyt

vsemozhetbyt Mar 29, 2017

Contributor

It seems this line length is more than 80 characters as well.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2017

Thank you for the contribution. A nit: the docs use line length limit: 80 characters (see the style guide). Could you please wrap the above-mentioned fragments?

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2017

And one nit more: the commit guidelines requires an imperative verb after the subsystem prefix. Could you also replace doc: changes by doc: change?

@vsemozhetbyt vsemozhetbyt removed the build label Mar 29, 2017

jrmce added 2 commits Mar 28, 2017
doc: change Mac OS X to macOS
This update changes references to "Mac OS X", "OS X", and "OSX" in
markdown files to "macOS".

Fixes: #12086
doc: correct markdown file line lengths
This commit updates two paragraphs that exceeded the 80 line standard
after updating to macOS.

Fixes: #12086

@jrmce jrmce changed the title doc: changes Mac OS X to macOS doc: change Mac OS X to macOS Mar 29, 2017

@jrmce

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2017

@vsemozhetbyt Thanks for the review. I believe I have correct the above mentioned items.

@mscdex mscdex added the macos label Mar 29, 2017

@lpinca
lpinca approved these changes Mar 29, 2017
@aqrln

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

What about doc/releases.md (lines 191, 197 and 207)?

@jrmce

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2017

@aqrln Good catch. I originally avoided touching anything like release/changelog, but looks like this one should have been changed. I'll update.

doc: update Mac OS X references in releases.md
This commit updates 3 additional references to Mac OS X in
releases.md to macOS.

Fixes: #12086
@ghost

This comment has been minimized.

Copy link

commented Apr 3, 2017

Please also correct this missing #12161

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2017

@andmeics Is it a correct link?

@ghost

This comment has been minimized.

Copy link

commented Apr 3, 2017

@vsemozhetbyt What does you mean,you can`t reach this link?

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2017

@andmeics Sorry, I just can't understand how this PR is connected with that issue. Can you elaborate?

@gibfahn

This comment has been minimized.

Copy link
Member

commented Apr 3, 2017

@andmeics

Please also correct this missing #12161

To echo what @vsemozhetbyt said, "Please also correct this missing" suggests that #12161 should have more OS X -> macOS changes, but it seems to be completely unrelated to this PR. Why did you link to it here?


image

@ghost

This comment has been minimized.

Copy link

commented Apr 3, 2017

Maybe I think the doc relative issues can be fix in one commit

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2017

@andmeics Oh. I see. However, if I get it right, this repo prefers more granularity in PRs and issues, so it would better be fixed in a separate PR.

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 4, 2017

Yes, in general we prefer more granularity. This PR should be fine as is tho. The changes aren't that significant but are definitely good.

jasnell added a commit that referenced this pull request Apr 4, 2017
doc: change Mac OS X to macOS
This update changes references to "Mac OS X", "OS X", and "OSX" in
markdown files to "macOS".

PR-URL: #12106
Fixes: #12086
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell added a commit that referenced this pull request Apr 4, 2017
doc: correct markdown file line lengths
This commit updates two paragraphs that exceeded the 80 line standard
after updating to macOS.

PR-URL: #12106
Fixes: #12086
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell added a commit that referenced this pull request Apr 4, 2017
doc: update Mac OS X references in releases.md
This commit updates 3 additional references to Mac OS X in
releases.md to macOS.

PR-URL: #12106
Fixes: #12086
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 4, 2017

Landed in 7a5d07c...503342d

@jasnell jasnell closed this Apr 4, 2017

@jasnell jasnell referenced this pull request Apr 4, 2017
italoacasas added a commit to italoacasas/node that referenced this pull request Apr 10, 2017
doc: update Mac OS X references in releases.md
This commit updates 3 additional references to Mac OS X in
releases.md to macOS.

PR-URL: nodejs#12106
Fixes: nodejs#12086
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Apr 18, 2017

this will require a backport for v6

@jrmce

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

@MylesBorins I'm not sure about the process for a backport, but is there something I can do to help with that?

@gibfahn

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

@jrmce the process is defined here: https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md

If you have any issues with it, feel free to comment in here.

MylesBorins added a commit that referenced this pull request May 16, 2017
doc: change Mac OS X to macOS
This update changes references to "Mac OS X", "OS X", and "OSX" in
markdown files to "macOS".

Fixes: #12086
PR-URL: #12106
Backport-PR-URL: #12650
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2017
doc: correct markdown file line lengths
This commit updates two paragraphs that exceeded the 80 line standard
after updating to macOS.

Fixes: #12086
PR-URL: #12106
Backport-PR-URL: #12650
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2017
doc: update Mac OS X references in releases.md
This commit updates 3 additional references to Mac OS X in
releases.md to macOS.

Fixes: #12086
PR-URL: #12106
Backport-PR-URL: #12650
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 18, 2017
doc: change Mac OS X to macOS
This update changes references to "Mac OS X", "OS X", and "OSX" in
markdown files to "macOS".

Fixes: #12086
PR-URL: #12106
Backport-PR-URL: #12650
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 18, 2017
doc: correct markdown file line lengths
This commit updates two paragraphs that exceeded the 80 line standard
after updating to macOS.

Fixes: #12086
PR-URL: #12106
Backport-PR-URL: #12650
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 18, 2017
doc: update Mac OS X references in releases.md
This commit updates 3 additional references to Mac OS X in
releases.md to macOS.

Fixes: #12086
PR-URL: #12106
Backport-PR-URL: #12650
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request May 23, 2017
andrew749 added a commit to michielbaird/node that referenced this pull request Jul 19, 2017
doc: change Mac OS X to macOS
This update changes references to "Mac OS X", "OS X", and "OSX" in
markdown files to "macOS".

Fixes: nodejs/node#12086
PR-URL: nodejs/node#12106
Backport-PR-URL: nodejs/node#12650
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
andrew749 added a commit to michielbaird/node that referenced this pull request Jul 19, 2017
doc: correct markdown file line lengths
This commit updates two paragraphs that exceeded the 80 line standard
after updating to macOS.

Fixes: nodejs/node#12086
PR-URL: nodejs/node#12106
Backport-PR-URL: nodejs/node#12650
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
andrew749 added a commit to michielbaird/node that referenced this pull request Jul 19, 2017
doc: update Mac OS X references in releases.md
This commit updates 3 additional references to Mac OS X in
releases.md to macOS.

Fixes: nodejs/node#12086
PR-URL: nodejs/node#12106
Backport-PR-URL: nodejs/node#12650
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.