Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace port in dgram cb address test #12944

Closed
wants to merge 1 commit into from

Conversation

@arturgvieira
Copy link
Contributor

commented May 10, 2017

Replaced common.PORT in the following test.
test-dgram-send-callback-buffer-length-empty-address.js

Ref: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test dgram

@mscdex mscdex added the dgram label May 10, 2017

@arturgvieira arturgvieira changed the title test: remove common.PORT from test test: replace port in dgram cb address test May 10, 2017

@arturgvieira arturgvieira changed the title test: replace port in dgram cb address test test: move to sequential dgram cb address test May 10, 2017

@arturgvieira arturgvieira deleted the arturgvieira:commonPort06-branch branch May 11, 2017

@arturgvieira arturgvieira restored the arturgvieira:commonPort06-branch branch May 11, 2017

@arturgvieira arturgvieira reopened this May 11, 2017

@lpinca

This comment has been minimized.

Copy link
Member

commented May 11, 2017

For anyone reviewing, see discussion in #12929.

@arturgvieira arturgvieira changed the title test: move to sequential dgram cb address test test: replace port in dgram cb address test May 11, 2017

test/parallel/test-dgram-send-callback-buffer-length-empty-address.js Outdated
@@ -17,4 +17,4 @@ const onMessage = common.mustCall(function messageSent(err, bytes) {
client.close();
});

client.send(buf, offset, len, common.PORT, onMessage);
client.bind(0, () => client.send(buf, offset, len, client.address().port, onMessage));

This comment has been minimized.

Copy link
@lpinca

lpinca May 12, 2017

Member

Long line.

@lpinca
lpinca approved these changes May 12, 2017
@arturgvieira

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2017

All done, wrapped arguments to shorten line length.

@lpinca

This comment has been minimized.

test: replace port in dgram cb address test
Replaced common.PORT in the following test.
test-dgram-send-callback-buffer-length-empty-address.js

Ref: #12376
@lpinca

This comment has been minimized.

Copy link
Member

commented May 12, 2017

@mhdawson
Copy link
Member

left a comment

LGTM

@lpinca

This comment has been minimized.

Copy link
Member

commented May 22, 2017

Landed in ad4765a.

@lpinca lpinca closed this May 22, 2017

lpinca added a commit that referenced this pull request May 22, 2017
test: remove common.PORT from dgram test
Remove common.PORT from
test-dgram-send-callback-buffer-length-empty-address to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12944
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
@Trott Trott referenced this pull request May 22, 2017
55 of 64 tasks complete
jasnell added a commit that referenced this pull request May 23, 2017
test: remove common.PORT from dgram test
Remove common.PORT from
test-dgram-send-callback-buffer-length-empty-address to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12944
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
jasnell added a commit that referenced this pull request May 23, 2017
test: remove common.PORT from dgram test
Remove common.PORT from
test-dgram-send-callback-buffer-length-empty-address to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12944
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.