test: replace port in dgram cb address test #12944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturgvieira-zz
changed the title
arturgvieira-zz
changed the title
|
For anyone reviewing, see discussion in #12929. |
arturgvieira-zz
changed the title
lpinca
reviewed
May 12, 2017
| @@ -17,4 +17,4 @@ const onMessage = common.mustCall(function messageSent(err, bytes) { | |||
| client.close(); | |||
| }); | |||
|
|
|||
| client.send(buf, offset, len, common.PORT, onMessage); | |||
| client.bind(0, () => client.send(buf, offset, len, client.address().port, onMessage)); | |||
lpinca
approved these changes
May 12, 2017
|
All done, wrapped arguments to shorten line length. |
Replaced common.PORT in the following test. test-dgram-send-callback-buffer-length-empty-address.js Ref: #12376
cjihrig
approved these changes
May 12, 2017
|
Landed in ad4765a. |
lpinca
pushed a commit
that referenced
this pull request
May 22, 2017
Remove common.PORT from test-dgram-send-callback-buffer-length-empty-address to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12944 Refs: #12376 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com>
64 tasks
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
Remove common.PORT from test-dgram-send-callback-buffer-length-empty-address to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12944 Refs: #12376 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com>
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
Remove common.PORT from test-dgram-send-callback-buffer-length-empty-address to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12944 Refs: #12376 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced common.PORT in the following test.
test-dgram-send-callback-buffer-length-empty-address.js
Ref: #12376
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test dgram