build: avoid /docs/api and /docs/doc/api upload #12957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: nodejs#12833 PR-URL:
nodejs-github-bot
added
the
build
|
/cc @nodejs/build note on the branch name .. that I forgot to change .. initial solution switched to |
This was referenced May 11, 2017
|
tested this @ https://nodejs.org/download/test/v8.0.0-test201705113064a21223/docs/ and it's fine, it's not a perfect replication of a release build as the promotion is automatic so I had to un-promote the docs before running again, also I had to add in the patch in #12958 to get it to build, but I believe it's close enough to realistic. |
gibfahn
approved these changes
May 11, 2017
|
I can land tomorrow if there's no objection. @rvagg let me know if you want to land this yourself. |
|
Landed in 7a1dc1f |
3 tasks
Merged
Closed
Merged
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Nov 23, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Dec 3, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24575 Refs: nodejs#24551 Refs: nodejs#12958 Refs: nodejs#12957 Refs: nodejs#8325 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg
added a commit
that referenced
this pull request
Feb 28, 2019
BethGriggs
pushed a commit
that referenced
this pull request
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem of having /docs/api and /docs/doc/api directories in our distributions, caused by a double (or more) build on CI server prior to promotion as reported and discussed in #12833.
scp -pr out/doc/ server:.../docs/first sees a missing/docs/directory so puts the out/doc/ contents into /docs/, second pass it sees an existing directory so makes a new /docs/doc/ directory for the upload.This fix ensures the directory exists initially and then does an
scpof the contents of the out/doc/ directory rather than the directory itself.Needs to be backported to all active release lines once confirmed working.