Changed the second parameter of assert.throws to match the errors #13035
Conversation
|
|
||
|
|
||
| console.error('undefined reference'); | ||
| script = new Script('foo.bar = 5;'); | ||
| assert.throws(function() { | ||
| script.create; |
There was a problem hiding this comment.
No it was there earlier, but it had no semi-colon. So it was one of the errors that popped up during make jslint
There was a problem hiding this comment.
I just re-checked it with https://github.com/nodejs/node/blob/master/test/parallel/test-vm-new-script-new-context.js
It's a sure-shot mistake.
There was a problem hiding this comment.
Please remove this added line. Thanks
|
|
||
|
|
||
| console.error('undefined reference'); | ||
| script = new Script('foo.bar = 5;'); | ||
| assert.throws(function() { | ||
| script.create; |
There was a problem hiding this comment.
Please remove this added line. Thanks
|
|
||
|
|
||
| console.error('undefined reference'); | ||
| script = new Script('foo.bar = 5;'); | ||
| assert.throws(function() { | ||
|
|
There was a problem hiding this comment.
Still adding a blank line. Can we remove that addition, please?
|
CI: https://ci.nodejs.org/job/node-test-commit/9952/ P.S. There might be a problem to land this, @AkshayIyer12 we'll need you to "rebase" this PR |
|
Landed in a593c74. |
Changed the second parameter of assert.throws to match the errors. PR-URL: #13035 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Changed the second parameter of assert.throws to match the errors. PR-URL: nodejs#13035 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Changed the second parameter of assert.throws to match the errors. PR-URL: #13035 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Checklist
Affected core subsystem(s)