Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add hasCrypto check to async-wrap-GH13045 #13141

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented May 21, 2017

This test currently fails if node was configured --without-ssl. This
commit adds crypto check and skips this test if crypto support is
not available.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add hasCrypto check to async-wrap-GH13045
This test currently fails if node was configured --without-ssl. This
commit adds crypto check and skips this test if crypto support is
not available.
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 21, 2017

@lpinca
lpinca approved these changes May 22, 2017
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 23, 2017

test/osx failure looks unrelated to this PR.

danbev added a commit to danbev/node that referenced this pull request May 23, 2017
test: add hasCrypto check to async-wrap-GH13045
This test currently fails if node was configured --without-ssl. This
commit adds crypto check and skips this test if crypto support is
not available.

PR-URL: nodejs#13141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 23, 2017

Landed in 485be99

@danbev danbev closed this May 23, 2017

@danbev danbev deleted the danbev:async-wrap-GH13045-hasCrypto branch May 23, 2017

jasnell added a commit that referenced this pull request May 23, 2017
test: add hasCrypto check to async-wrap-GH13045
This test currently fails if node was configured --without-ssl. This
commit adds crypto check and skips this test if crypto support is
not available.

PR-URL: #13141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell added a commit that referenced this pull request May 23, 2017
test: add hasCrypto check to async-wrap-GH13045
This test currently fails if node was configured --without-ssl. This
commit adds crypto check and skips this test if crypto support is
not available.

PR-URL: #13141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.