Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win,node-gyp: enable delay-load hook by default #1433

Closed

Conversation

piscisaureus
Copy link
Contributor

The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe for more background.
I want to consider seizing the opportunity that comes with a major version bump to switch to a reasonable default.

This PR is against the v1.x branch but it obviously should not land on this branch.
@iojs/tc

The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.
@piscisaureus piscisaureus added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 15, 2015
@piscisaureus piscisaureus changed the title semvarEnable delay load hook win,node-gyp: enable delay-load hook by default Apr 15, 2015
@bnoordhuis
Copy link
Member

As discussed on today's TC meeting: LGTM :-)

@Fishrock123 Fishrock123 added this to the 2.0.0 milestone Apr 15, 2015
@mscdex mscdex added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 15, 2015
@piscisaureus piscisaureus added the windows Issues and PRs related to the Windows platform. label Apr 16, 2015
@rvagg rvagg mentioned this pull request Apr 27, 2015
piscisaureus added a commit that referenced this pull request Apr 27, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@piscisaureus
Copy link
Contributor Author

Thanks Ben - merged in 3bda6cb.

@piscisaureus piscisaureus deleted the enable-delay-load-hook branch April 27, 2015 01:45
rvagg added a commit that referenced this pull request May 4, 2015
PR-URL: #1532

Notable Changes:

* crypto: significantly reduced memory usage for TLS (Fedor Indutny & Сковорода
  Никита Андреевич) #1529
* net: socket.connect() now accepts a 'lookup' option for a custom DNS
  resolution mechanism, defaults to dns.lookup() (Evan Lucas) #1505
* npm: Upgrade npm to 2.9.0. See the v2.8.4 and v2.9.0 release notes for
  details. Notable items:
  - Add support for default author field to make npm init -y work without
    user-input (@othiym23) npm/npm/d8eee6cf9d
  - Include local modules in npm outdated and npm update (@ArnaudRinquin)
    npm/npm#7426
  - The prefix used before the version number on npm version is now configurable
    via tag-version-prefix (@kkragenbrink) npm/npm#8014
* os: os.tmpdir() is now cross-platform consistent and will no longer returns a
  path with a trailling slash on any platform (Christian Tellnes) #747
* process:
  - process.nextTick() performance has been improved by between 2-42% across the
    benchmark suite, notable because this is heavily used across core (Brian White) #1548
  - New process.geteuid(), process.seteuid(id), process.getegid() and
    process.setegid(id) methods allow you to get and set effective UID and GID
    of the process (Evan Lucas) #1536
* repl:
  - REPL history can be persisted across sessions if the NODE_REPL_HISTORY_FILE
    environment variable is set to a user accessible file,
    NODE_REPL_HISTORY_SIZE can set the maximum history size and defaults to 1000
    (Chris Dickinson) #1513
  - The REPL can be placed in to one of three modes using the NODE_REPL_MODE
    environment variable: sloppy, strict or magic (default); the new magic mode
    will automatically run "strict mode only" statements in strict mode
    (Chris Dickinson) #1513
* smalloc: the 'smalloc' module has been deprecated due to changes coming in V8
  4.4 that will render it unusable
* util: add Promise, Map and Set inspection support (Christopher Monsanto) #1471
* V8: upgrade to 4.2.77.18, see the ChangeLog for full details. Notable items:
  - Classes have moved out of staging; the class keyword is now usable in strict
    mode without flags
  - Object literal enhancements have moved out of staging; shorthand method and
    property syntax is now usable ({ method() { }, property })
  - Rest parameters (function(...args) {}) are implemented in staging behind the
    --harmony-rest-parameters flag
  - Computed property names ({['foo'+'bar']:'bam'}) are implemented in staging
    behind the --harmony-computed-property-names flag
  - Unicode escapes ('\u{xxxx}') are implemented in staging behind the
    --harmony_unicode flag and the --harmony_unicode_regexps flag for use in
    regular expressions
* Windows:
  - Random process termination on Windows fixed (Fedor Indutny) #1512 / #1563
  - The delay-load hook introduced to fix issues with process naming (iojs.exe /
    node.exe) has been made opt-out for native add-ons. Native add-ons should
    include 'win_delay_load_hook': 'false' in their binding.gyp to disable this
    feature if they experience problems . (Bert Belder) #1433
* Governance:
  - Rod Vagg (@rvagg) was added to the Technical Committee (TC)
  - Jeremiah Senkpiel (@Fishrock123) was added to the Technical Committee (TC)
piscisaureus added a commit that referenced this pull request May 9, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123 added a commit to Fishrock123/node that referenced this pull request May 15, 2015
PR-URL: nodejs#1679

Notable Changes:

* win,node-gyp: the delay-load hook for windows addons has now been
correctly enabled by default, it had wrongly defaulted to off in the
release version of 2.0.0 (Bert Belder) nodejs#1433
* os: tmpdir()'s trailing slash stripping has been refined to fix an
issue when the temp directory is at '/'. Also considers which slash is
used by the operating system. (cjihrig) nodejs#1673
* tls: default ciphers have been updated to use gcm and aes128 (Mike
MacCana) nodejs#1660
* build: v8 snapshots have been re-enabled by default as suggested by
the v8 team, since prior security issues have been resolved. This
should give some perf improvements to both startup and vm context
creation. (Trevor Norris) nodejs#1663
* src: fixed preload modules not working when other flags were used
before --require (Yosuke Furukawa) nodejs#1694
* dgram: fixed send()'s callback not being asynchronous (Yosuke
Furukawa) nodejs#1313
* readline: emitKeys now keeps buffering data until it has enough to
parse. This fixes an issue with parsing split escapes. (Alex Kocharin)
* cluster: works now properly emit 'disconnect' to cluser.worker (Oleg
Elifantiev) nodejs#1386
events: uncaught errors now provide some context (Evan Lucas) nodejs#1654
iarna pushed a commit to npm/node that referenced this pull request May 22, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
zkat pushed a commit to npm/node that referenced this pull request Jun 5, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
zkat pushed a commit to npm/node that referenced this pull request Jun 6, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus added a commit that referenced this pull request Jun 10, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg mentioned this pull request Jun 11, 2015
iarna pushed a commit to npm/node that referenced this pull request Jun 12, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus added a commit that referenced this pull request Jun 15, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg mentioned this pull request Jun 16, 2015
othiym23 pushed a commit to npm/node that referenced this pull request Jun 19, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus added a commit that referenced this pull request Jun 19, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
zkat pushed a commit to npm/node that referenced this pull request Jul 6, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus added a commit that referenced this pull request Jul 6, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
othiym23 pushed a commit to npm/node that referenced this pull request Jul 10, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus added a commit that referenced this pull request Jul 16, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
zkat pushed a commit to npm/node that referenced this pull request Jul 21, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus added a commit that referenced this pull request Jul 21, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
zkat pushed a commit to npm/node that referenced this pull request Jul 24, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus added a commit that referenced this pull request Jul 25, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
zkat pushed a commit to npm/node that referenced this pull request Aug 1, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus added a commit that referenced this pull request Aug 1, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg mentioned this pull request Aug 4, 2015
zkat pushed a commit to npm/node that referenced this pull request Aug 8, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
zkat pushed a commit to npm/node that referenced this pull request Aug 28, 2015
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants