Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve assertion fail messages #14949

Closed
wants to merge 2 commits into from
Closed

test: improve assertion fail messages #14949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21b1820
test: improve assertion fail messages
refack Aug 19, 2017
a17829d
[sqwsh] typo /s/inherits/inherit
refack Aug 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions test/parallel/test-stream-inheritance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,26 @@ assert.ok(!(undefined instanceof Writable));

// Simple inheritance check for `Writable` works fine in a subclass constructor.
function CustomWritable() {
assert.ok(this instanceof Writable, 'inherits from Writable');
assert.ok(this instanceof CustomWritable, 'inherits from CustomWritable');
assert.ok(
this instanceof CustomWritable,
`${this} does not inherit from CustomWritable`
);
assert.ok(
this instanceof Writable,
`${this} does not inherit from Writable`
);
}

Object.setPrototypeOf(CustomWritable, Writable);
Object.setPrototypeOf(CustomWritable.prototype, Writable.prototype);

new CustomWritable();

assert.throws(CustomWritable,
common.expectsError({
code: 'ERR_ASSERTION',
message: /^inherits from Writable$/
}));
common.expectsError(
CustomWritable,
{
code: 'ERR_ASSERTION',
type: assert.AssertionError,
message: 'undefined does not inherit from CustomWritable'
}
);