Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace assert.equal with assert.strictEqual #18119

Closed
wants to merge 1 commit into from
Closed

test: replace assert.equal with assert.strictEqual #18119

wants to merge 1 commit into from

Conversation

shqld
Copy link

@shqld shqld commented Jan 12, 2018

Overview

Replaced assert.equal with assert.strictEqual as pointed out in nodejs/code-and-learn#58 (comment).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 12, 2018
BridgeAR
BridgeAR approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
Member

Personally I feel like a even nicer solution would be to require the strict mode (require('assert').strict;).

@shqld
Copy link
Author

shqld commented Jan 12, 2018 •
edited
Loading

@BridgeAR @Leko Thanks so much for your reviews!
This time I used just assert.strictEqual because one file has deepEqual used purposefully(

node/test/es-module/test-esm-dynamic-import.js

Line 47 in 69affae

assert.deepEqual(ns, { default: true });
) and I feel like the mix could confuse people here

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/12570/

@BridgeAR
Copy link
Member

Landed in f576341

@BridgeAR BridgeAR closed this Jan 19, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 19, 2018
@BridgeAR
test: replace assert.equal with assert.strictEqual
f576341 
PR-URL: nodejs#18119
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MayaLekova
test: replace assert.equal with assert.strictEqual
7df2355 
PR-URL: nodejs#18119
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Aug 2, 2018
@codebytere
test: replace assert.equal with assert.strictEqual
bdd0325 
PR-URL: #18119
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@rvagg
test: replace assert.equal with assert.strictEqual
e98efcf 
PR-URL: #18119
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Leko Leko Leko approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@shqld @BridgeAR @joyeecheung @jasnell @Leko @cjihrig @MylesBorins @codebytere @nodejs-github-bot