Code And Learn at NodeFest 2016 #58

Closed
yosuke-furukawa opened this Issue Sep 28, 2016 · 45 comments

Comments

Projects
None yet
@yosuke-furukawa
Member

yosuke-furukawa commented Sep 28, 2016

Hi folks.
NodeFest is the largest Node.js conference at Japan.

I am an organizer of the conference, I would like to open code-and-learn-jp on NodeFest.
Japan has 1 collaborator (me) and 1 core team member (shigeki) and some great nodeschool staffs (martin, ledsun, watilde, tako-black, etc). We would like to support contribution to nodejs/core.

And I would like to list up the contribution point of Japanese node beginners.
I guess we will receive some PRs on 12th November.
We will follow English communication and some other commit techniques.

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 6, 2016

Member

Contributing Point:

doc typo:

  • doc/modules.md: line 132 lookups, it would be better looks up.
  • doc/cluster.md: line 147, 499 has eg., it would be better e.g..
  • doc/repl: line 6 has includable, it would be better includible. http://wikidiff.com/includable/includible
  • doc/dns.md: line 263 e.g., => e.g.
  • doc/http.md: line 553/856 e.g., => e.g.
  • doc/tls.md: line 762 836 1026 e.g., => e.g.

doc improvement:

  • doc/url.md does not have WHATWG-URL standard link and the description.
Member

yosuke-furukawa commented Nov 6, 2016

Contributing Point:

doc typo:

  • doc/modules.md: line 132 lookups, it would be better looks up.
  • doc/cluster.md: line 147, 499 has eg., it would be better e.g..
  • doc/repl: line 6 has includable, it would be better includible. http://wikidiff.com/includable/includible
  • doc/dns.md: line 263 e.g., => e.g.
  • doc/http.md: line 553/856 e.g., => e.g.
  • doc/tls.md: line 762 836 1026 e.g., => e.g.

doc improvement:

  • doc/url.md does not have WHATWG-URL standard link and the description.
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 6, 2016

Member

If you need more issues, one thing you can do is search through the test files for assert.equal(). In almost all cases, the test could be improved by using assert.strictEqual() instead. The one exception I can think of might be test-assert.js where use of assert.equa() may be necessary.

Member

Trott commented Nov 6, 2016

If you need more issues, one thing you can do is search through the test files for assert.equal(). In almost all cases, the test could be improved by using assert.strictEqual() instead. The one exception I can think of might be test-assert.js where use of assert.equa() may be necessary.

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 6, 2016

Member

Contributing Point:

test:

  • test/parallel/test-http-status-reason-invalid-chars.js: use port 0 instead of common.PORT,
const server = http.createServer((req, res) => {
  if (req.url === '/explicit') {
    explicit(req, res);
  } else {
    implicit(req, res);
  }
}).listen(common.PORT, common.mustCall(() => { // should use 0
  const url = `http://localhost:${common.PORT}`; // should use server.address().port
  let left = 2;
  const check = common.mustCall((res) => {
    left--;
    assert.notEqual(res.headers['content-type'], 'text/html');
    assert.notEqual(res.headers['content-type'], 'gotcha');
    if (left === 0) server.close();
  }, 2);
  http.get(`${url}/explicit`, check).end();
  http.get(`${url}/implicit`, check).end();
}));
Member

yosuke-furukawa commented Nov 6, 2016

Contributing Point:

test:

  • test/parallel/test-http-status-reason-invalid-chars.js: use port 0 instead of common.PORT,
const server = http.createServer((req, res) => {
  if (req.url === '/explicit') {
    explicit(req, res);
  } else {
    implicit(req, res);
  }
}).listen(common.PORT, common.mustCall(() => { // should use 0
  const url = `http://localhost:${common.PORT}`; // should use server.address().port
  let left = 2;
  const check = common.mustCall((res) => {
    left--;
    assert.notEqual(res.headers['content-type'], 'text/html');
    assert.notEqual(res.headers['content-type'], 'gotcha');
    if (left === 0) server.close();
  }, 2);
  http.get(`${url}/explicit`, check).end();
  http.get(`${url}/implicit`, check).end();
}));
@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 6, 2016

Member

@Trott thank you!!! sound so good. I am currently searching contribution point on code-and-learn on nodefest.

Member

yosuke-furukawa commented Nov 6, 2016

@Trott thank you!!! sound so good. I am currently searching contribution point on code-and-learn on nodefest.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 6, 2016

Member

Here's another one: There are a number of instances of setTimeout() where the function is called without a duration (the second argument). Node.js will treat that the same as calling it with a duration of 1. In many of these cases, it might be better to use setImmediate().

Here are some of those cases. I have not reviewed them to verify that setImmediate() is better, but that might be an appropriate exercise for a first time committer.

  • test/sequential/test-next-tick-error-spin.js line 43
  • test/parallel/test-tls-hello-parser-failure.js line 30
  • test/parallel/test-stream2-writable.js line 331
Member

Trott commented Nov 6, 2016

Here's another one: There are a number of instances of setTimeout() where the function is called without a duration (the second argument). Node.js will treat that the same as calling it with a duration of 1. In many of these cases, it might be better to use setImmediate().

Here are some of those cases. I have not reviewed them to verify that setImmediate() is better, but that might be an appropriate exercise for a first time committer.

  • test/sequential/test-next-tick-error-spin.js line 43
  • test/parallel/test-tls-hello-parser-failure.js line 30
  • test/parallel/test-stream2-writable.js line 331
@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 6, 2016

Member

test: use port 0 instead of common.PORT

  • test/parallel/test-cluster-net-send.js
  server.listen(common.PORT, function() { // use 0 port
    socket = net.connect(common.PORT, '127.0.0.1', socketConnected); // use server.address().port
  });
  • test/parallel/test-tls-connect-address-family.js
  • test/parallel/test-net-socket-destroy-twice.js
Member

yosuke-furukawa commented Nov 6, 2016

test: use port 0 instead of common.PORT

  • test/parallel/test-cluster-net-send.js
  server.listen(common.PORT, function() { // use 0 port
    socket = net.connect(common.PORT, '127.0.0.1', socketConnected); // use server.address().port
  });
  • test/parallel/test-tls-connect-address-family.js
  • test/parallel/test-net-socket-destroy-twice.js
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 6, 2016

Member

Japan has 1 collaborator (me) and 1 core team member (shigeki)

@ronkorving is a collaborator and lives in Tokyo.

Member

Trott commented Nov 6, 2016

Japan has 1 collaborator (me) and 1 core team member (shigeki)

@ronkorving is a collaborator and lives in Tokyo.

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 6, 2016

Member

@Trott ah, that's so good.
I will list these points.

Member

yosuke-furukawa commented Nov 6, 2016

@Trott ah, that's so good.
I will list these points.

@ronkorving

This comment has been minimized.

Show comment
Hide comment
@ronkorving

ronkorving Nov 7, 2016

@Trott @yosuke-furukawa Indeed :) I'm not too active in the Japanese Node community, but wouldn't mind trying harder :) My Japanese is not yet 100% what I would like it to be. In any case, I signed up for Sunday (visitor) and wouldn't mind helping with the organization next year either if that's appreciated. I'll see you on Sunday. 楽しみにしてます ^^

@Trott @yosuke-furukawa Indeed :) I'm not too active in the Japanese Node community, but wouldn't mind trying harder :) My Japanese is not yet 100% what I would like it to be. In any case, I signed up for Sunday (visitor) and wouldn't mind helping with the organization next year either if that's appreciated. I'll see you on Sunday. 楽しみにしてます ^^

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 7, 2016

Member

@yosuke-furukawa I'm definitely looking forward to being there and will help out in whatever way that I can. I just want to confirm that the Code and Learn is scheduled for Saturday afternoon, correct? I want to take a little bit of time Saturday morning to sight see a little bit and I want to make sure I plan things so I won't be late to the Code and Learn :-)

Member

jasnell commented Nov 7, 2016

@yosuke-furukawa I'm definitely looking forward to being there and will help out in whatever way that I can. I just want to confirm that the Code and Learn is scheduled for Saturday afternoon, correct? I want to take a little bit of time Saturday morning to sight see a little bit and I want to make sure I plan things so I won't be late to the Code and Learn :-)

@shigeki

This comment has been minimized.

Show comment
Hide comment
@shigeki

shigeki Nov 8, 2016

I'm going to join it to help participants and take care of what tests and docs can be good for the first contributions. But actually, the class is just one and half hour so I think it is too short for novices.

Instead of submitting a new PR to nodejs repo, I made an alternative repo of node to give such users the first experiences of contributions in https://github.com/shigeki/node_testpr/ . It can be a training for them if they submit a fake PR such as shigeki/node_testpr#1 .

Users can choice which repo they want to work on during the course.

shigeki commented Nov 8, 2016

I'm going to join it to help participants and take care of what tests and docs can be good for the first contributions. But actually, the class is just one and half hour so I think it is too short for novices.

Instead of submitting a new PR to nodejs repo, I made an alternative repo of node to give such users the first experiences of contributions in https://github.com/shigeki/node_testpr/ . It can be a training for them if they submit a fake PR such as shigeki/node_testpr#1 .

Users can choice which repo they want to work on during the course.

@shigeki

This comment has been minimized.

Show comment
Hide comment
@shigeki

shigeki Nov 8, 2016

I've just submitted some issues of test failures to be reserved for this course in nodejs/node#9509, nodejs/node#9510 and nodejs/node#9511

shigeki commented Nov 8, 2016

I've just submitted some issues of test failures to be reserved for this course in nodejs/node#9509, nodejs/node#9510 and nodejs/node#9511

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 9, 2016

Member

@jasnell

I just want to confirm that the Code and Learn is scheduled for Saturday afternoon, correct?

Yes!!! Code And Learn will begin 15:45 on Saturday, and the end time is 17:15.

And I really would like you to attend NodeDiscussion on Saturday morning, almost 90 min (11:00-12:30). This discussion is unconference style. We would like to discuss about Node.js good point/bad point/wishlist. I would like share our opinions to node core committers.

If you don't have any time on Saturday morning, it is OK, but if you have time, please come!!!!!

Member

yosuke-furukawa commented Nov 9, 2016

@jasnell

I just want to confirm that the Code and Learn is scheduled for Saturday afternoon, correct?

Yes!!! Code And Learn will begin 15:45 on Saturday, and the end time is 17:15.

And I really would like you to attend NodeDiscussion on Saturday morning, almost 90 min (11:00-12:30). This discussion is unconference style. We would like to discuss about Node.js good point/bad point/wishlist. I would like share our opinions to node core committers.

If you don't have any time on Saturday morning, it is OK, but if you have time, please come!!!!!

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 9, 2016

Member

@ronkorving Ya!!! please help us !!!! You can come our venue and speak to our receptionist as mentor. you can join :)

Member

yosuke-furukawa commented Nov 9, 2016

@ronkorving Ya!!! please help us !!!! You can come our venue and speak to our receptionist as mentor. you can join :)

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 9, 2016

Member

@shigeki awesome!!! I will wrap up these contribution point on this Thursday.

Member

yosuke-furukawa commented Nov 9, 2016

@shigeki awesome!!! I will wrap up these contribution point on this Thursday.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 10, 2016

Member

test/sequential/test-next-tick-error-spin.js line 43

You can remove that one from the list as I'm in the process of fixing it while refactoring a bunch of other things in the test. Sorry about that.

You can replace it, though with these tests which all have at least one instance of setTimeout() called without a second argument, and thus are candidates for possibly using setImmediate() instead:

  • test/parallel/test-stream2-readable-wrap.js line 61
  • test/parallel/test-stream2-readable-non-empty-end.js lines 19 and 34
  • test/parallel/test-stream2-push.js line 116
  • test/parallel/test-stream2-large-read-stall.js line 49
  • test/parallel/test-stream-unshift-read-race.js line 44
  • test/parallel/test-stream-unshift-empty-chunk.js line 16
  • test/parallel/test-stream-transform-objectmode-falsey-value.js line 33
Member

Trott commented Nov 10, 2016

test/sequential/test-next-tick-error-spin.js line 43

You can remove that one from the list as I'm in the process of fixing it while refactoring a bunch of other things in the test. Sorry about that.

You can replace it, though with these tests which all have at least one instance of setTimeout() called without a second argument, and thus are candidates for possibly using setImmediate() instead:

  • test/parallel/test-stream2-readable-wrap.js line 61
  • test/parallel/test-stream2-readable-non-empty-end.js lines 19 and 34
  • test/parallel/test-stream2-push.js line 116
  • test/parallel/test-stream2-large-read-stall.js line 49
  • test/parallel/test-stream-unshift-read-race.js line 44
  • test/parallel/test-stream-unshift-empty-chunk.js line 16
  • test/parallel/test-stream-transform-objectmode-falsey-value.js line 33
@ronkorving

This comment has been minimized.

Show comment
Hide comment
@ronkorving

ronkorving Nov 10, 2016

@yosuke-furukawa Sounds good, I'll try to make it! :) Basically just show up before 3:45?

@yosuke-furukawa Sounds good, I'll try to make it! :) Basically just show up before 3:45?

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 10, 2016

Member

@Trott thank you soooooooooooooooo much!!!!!!!!!!!!!!!!!!!!!!

Member

yosuke-furukawa commented Nov 10, 2016

@Trott thank you soooooooooooooooo much!!!!!!!!!!!!!!!!!!!!!!

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 10, 2016

Member

@ronkorving Yes! we will start at 15:45 on dots Shibuya, tokyo. https://eventdots.jp/space

Member

yosuke-furukawa commented Nov 10, 2016

@ronkorving Yes! we will start at 15:45 on dots Shibuya, tokyo. https://eventdots.jp/space

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Nov 11, 2016

Member

https://coverage.nodejs.org/coverage-fb05e31466ac0bad/root/internal/process/stdio.js.html

  1. A pseudo-tty test that manually fires 'SIGWINCH' and makes sure none of the properties set by _refreshSize have been changed.
  2. Add the stderr.destroy/stderr.destroySoon error checking to the test which already checks that for stdout.
Member

Fishrock123 commented Nov 11, 2016

https://coverage.nodejs.org/coverage-fb05e31466ac0bad/root/internal/process/stdio.js.html

  1. A pseudo-tty test that manually fires 'SIGWINCH' and makes sure none of the properties set by _refreshSize have been changed.
  2. Add the stderr.destroy/stderr.destroySoon error checking to the test which already checks that for stdout.
@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 12, 2016

Member

@Fishrock123
Thank you sooooooooo much !!!!! This coverage information is really helpful for us.

Member

yosuke-furukawa commented Nov 12, 2016

@Fishrock123
Thank you sooooooooo much !!!!! This coverage information is really helpful for us.

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 12, 2016

Member

All contribution point:
docs:

  • doc/modules.md: line 132 lookups, it would be better looks up.
  • doc/cluster.md: line 147, 499 has eg., it would be better e.g..
  • doc/repl: line 6 has includable, it would be better includible. http://wikidiff.com/includable/includible
  • doc/dns.md: line 263 e.g., => e.g.
  • doc/http.md: line 553/856 e.g., => e.g.
  • doc/tls.md: line 762 836 1026 e.g., => e.g.

doc improvement:

  • doc/url.md does not have WHATWG-URL standard link and the description.

test assertion improvement:

  • assert.equal would be better to use assert.strictEqual

test failure with build option :

test timing API improvement:
Use setImmediate instead of setTimeout().

  • test/parallel/test-tls-hello-parser-failure.js line 30
  • test/parallel/test-stream2-writable.js line 331
  • test/parallel/test-stream2-readable-wrap.js line 61
  • test/parallel/test-stream2-readable-non-empty-end.js lines 19 and 34
  • test/parallel/test-stream2-push.js line 116
  • test/parallel/test-stream2-large-read-stall.js line 49
  • test/parallel/test-stream-unshift-read-race.js line 44
  • test/parallel/test-stream-unshift-empty-chunk.js line 16
  • test/parallel/test-stream-transform-objectmode-falsey-value.js line 33

test use port:0 instead of common.PORT :

  • test/parallel/test-http-status-reason-invalid-chars.js: use port 0 instead of common.PORT,
  • test/parallel/test-cluster-net-send.js
  • test/parallel/test-tls-connect-address-family.js
  • test/parallel/test-net-socket-destroy-twice.js

coverage improvement:

  • A pseudo-tty test that manually fires 'SIGWINCH' and makes sure none of the properties set by _refreshSize have been changed.
  • Add the stderr.destroy/stderr.destroySoon error checking to the test which already checks that for stdout.

https://coverage.nodejs.org/coverage-fb05e31466ac0bad/root/internal/process/stdio.js.html

Member

yosuke-furukawa commented Nov 12, 2016

All contribution point:
docs:

  • doc/modules.md: line 132 lookups, it would be better looks up.
  • doc/cluster.md: line 147, 499 has eg., it would be better e.g..
  • doc/repl: line 6 has includable, it would be better includible. http://wikidiff.com/includable/includible
  • doc/dns.md: line 263 e.g., => e.g.
  • doc/http.md: line 553/856 e.g., => e.g.
  • doc/tls.md: line 762 836 1026 e.g., => e.g.

doc improvement:

  • doc/url.md does not have WHATWG-URL standard link and the description.

test assertion improvement:

  • assert.equal would be better to use assert.strictEqual

test failure with build option :

test timing API improvement:
Use setImmediate instead of setTimeout().

  • test/parallel/test-tls-hello-parser-failure.js line 30
  • test/parallel/test-stream2-writable.js line 331
  • test/parallel/test-stream2-readable-wrap.js line 61
  • test/parallel/test-stream2-readable-non-empty-end.js lines 19 and 34
  • test/parallel/test-stream2-push.js line 116
  • test/parallel/test-stream2-large-read-stall.js line 49
  • test/parallel/test-stream-unshift-read-race.js line 44
  • test/parallel/test-stream-unshift-empty-chunk.js line 16
  • test/parallel/test-stream-transform-objectmode-falsey-value.js line 33

test use port:0 instead of common.PORT :

  • test/parallel/test-http-status-reason-invalid-chars.js: use port 0 instead of common.PORT,
  • test/parallel/test-cluster-net-send.js
  • test/parallel/test-tls-connect-address-family.js
  • test/parallel/test-net-socket-destroy-twice.js

coverage improvement:

  • A pseudo-tty test that manually fires 'SIGWINCH' and makes sure none of the properties set by _refreshSize have been changed.
  • Add the stderr.destroy/stderr.destroySoon error checking to the test which already checks that for stdout.

https://coverage.nodejs.org/coverage-fb05e31466ac0bad/root/internal/process/stdio.js.html

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 12, 2016

Member

assert.deepEqual would be better to use assert.deepStrictEqual

We have a lint rule for that so you shouldn't find any examples of deepEqual that haven't been explicitly excused as necessary exceptions (e.g., in test-assert.js).

Member

Trott commented Nov 12, 2016

assert.deepEqual would be better to use assert.deepStrictEqual

We have a lint rule for that so you shouldn't find any examples of deepEqual that haven't been explicitly excused as necessary exceptions (e.g., in test-assert.js).

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 12, 2016

Member

@Trott OK, I updated.

Member

yosuke-furukawa commented Nov 12, 2016

@Trott OK, I updated.

@dorako321

This comment has been minimized.

Show comment
Hide comment
@dorako321

dorako321 Nov 12, 2016

i will try to fix this doc/dns.md: line 263 e.g., => e.g.

dorako321 commented Nov 12, 2016

i will try to fix this doc/dns.md: line 263 e.g., => e.g.

@akito0107

This comment has been minimized.

Show comment
Hide comment
@akito0107

akito0107 Nov 12, 2016

I will try to fix test/parallel/test-cluster-net-send.js !

I will try to fix test/parallel/test-cluster-net-send.js !

@fossamagna

This comment has been minimized.

Show comment
Hide comment
@fossamagna

fossamagna Nov 12, 2016

I try to fix test: test/parallel/test-net-socket-destroy-twice.js
use port 0 instead of common.PORT
#58 (comment)

fossamagna commented Nov 12, 2016

I try to fix test: test/parallel/test-net-socket-destroy-twice.js
use port 0 instead of common.PORT
#58 (comment)

@fand

This comment has been minimized.

Show comment
Hide comment
@fand

fand Nov 12, 2016

I'm gonna try test/parallel/test-stream-transform-objectmode-falsey-value.js line 33!

fand commented Nov 12, 2016

I'm gonna try test/parallel/test-stream-transform-objectmode-falsey-value.js line 33!

@ikasumiwt

This comment has been minimized.

Show comment
Hide comment
@ikasumiwt

ikasumiwt Nov 12, 2016

I'll try to fix doc/http.md: line 553/856 e.g., => e.g.

ikasumiwt commented Nov 12, 2016

I'll try to fix doc/http.md: line 553/856 e.g., => e.g.

@saitoxu

This comment has been minimized.

Show comment
Hide comment
@saitoxu

saitoxu Nov 12, 2016

I'll try to fix test/parallel/test-http-status-reason-invalid-chars.js: use port 0 instead of common.PORT

saitoxu commented Nov 12, 2016

I'll try to fix test/parallel/test-http-status-reason-invalid-chars.js: use port 0 instead of common.PORT

@nanocloudx

This comment has been minimized.

Show comment
Hide comment
@nanocloudx

nanocloudx Nov 12, 2016

I will try to fix doc/tls.md: line 762 836 1026 e.g., => e.g.

I will try to fix doc/tls.md: line 762 836 1026 e.g., => e.g.

@YutamaKotaro

This comment has been minimized.

Show comment
Hide comment
@YutamaKotaro

YutamaKotaro Nov 12, 2016

I will try to fix doc/cluster.md: line 147, 499 has eg., it would be better e.g..

I will try to fix doc/cluster.md: line 147, 499 has eg., it would be better e.g..

@mkamakura

This comment has been minimized.

Show comment
Hide comment
@mkamakura

mkamakura Nov 12, 2016

I'll try to fix test/parallel/test-tls-connect-address-family.js : use port 0 instead of common.PORT

I'll try to fix test/parallel/test-tls-connect-address-family.js : use port 0 instead of common.PORT

@utano320

This comment has been minimized.

Show comment
Hide comment
@utano320

utano320 Nov 12, 2016

I'll try to fix doc/repl: line 6 has includable, it would be better includible.

I'll try to fix doc/repl: line 6 has includable, it would be better includible.

@pg-ito

This comment has been minimized.

Show comment
Hide comment
@pg-ito

pg-ito Nov 12, 2016

I'll try to fix doc/modules.md: line 132 lookups, it would be better looks up.

pg-ito commented Nov 12, 2016

I'll try to fix doc/modules.md: line 132 lookups, it would be better looks up.

MylesBorins added a commit to nodejs/node that referenced this issue Dec 13, 2016

doc: fix e.g., to e.g. in doc/http.md
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
PR-URL: #9564
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 13, 2016

doc: fix typo in doc/tls.md
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 13, 2016

doc: fix typo about cluster doc, (eg. -> e.g.)
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 13, 2016

doc: fix typo about cluster doc, (eg. -> e.g.)
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 13, 2016

doc: fix typo e.g., => e.g.
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 13, 2016

doc: fix typo e.g., => e.g.
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 13, 2016

doc: fix typo in doc/repl.md line: 6
fix doc/api/repl.md line 6 "includable" => "includible"

Fixes: nodejs/code-and-learn#58
PR-URL: #9582
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 20, 2016

test: improve test-stream2-objects.js
This commit improves the test cases in
test-stream2-objects.js by using assert.strictEqual
instead of assert.equal.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9565
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 20, 2016

test: change from setTimeout to setImmediate
This is a part of Code And Learn at NodeFest 2016 Challenge

Fixes: nodejs/code-and-learn#58
PR-URL: #9578
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 20, 2016

test: add test case of PassThrough
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9581
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 20, 2016

test: use setImmediate() in test of stream2
use setImmediate() insted of setTimeout()
 in test of stream2 push.
The test is in test/parallel/test-stream2-push.js

Fixes: nodejs/code-and-learn#58
PR-URL: #9583
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

test: improve test-stream2-objects.js
This commit improves the test cases in
test-stream2-objects.js by using assert.strictEqual
instead of assert.equal.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9565
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

test: change from setTimeout to setImmediate
This is a part of Code And Learn at NodeFest 2016 Challenge

Fixes: nodejs/code-and-learn#58
PR-URL: #9578
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

test: add test case of PassThrough
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9581
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

test: use setImmediate() in test of stream2
use setImmediate() insted of setTimeout()
 in test of stream2 push.
The test is in test/parallel/test-stream2-push.js

Fixes: nodejs/code-and-learn#58
PR-URL: #9583
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

doc: fix e.g., to e.g. in doc/http.md
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
PR-URL: #9564
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

doc: fix typo in doc/tls.md
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

doc: fix typo about cluster doc, (eg. -> e.g.)
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

doc: fix typo e.g., => e.g.
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

doc: fix typo in doc/repl.md line: 6
fix doc/api/repl.md line 6 "includable" => "includible"

Fixes: nodejs/code-and-learn#58
PR-URL: #9582
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

doc: fix e.g., to e.g. in doc/http.md
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
PR-URL: #9564
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

doc: fix typo about cluster doc, (eg. -> e.g.)
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

doc: fix typo e.g., => e.g.
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

test: improve test-stream2-objects.js
This commit improves the test cases in
test-stream2-objects.js by using assert.strictEqual
instead of assert.equal.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9565
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

test: change from setTimeout to setImmediate
This is a part of Code And Learn at NodeFest 2016 Challenge

Fixes: nodejs/code-and-learn#58
PR-URL: #9578
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

test: add test case of PassThrough
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9581
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 21, 2016

test: use setImmediate() in test of stream2
use setImmediate() insted of setTimeout()
 in test of stream2 push.
The test is in test/parallel/test-stream2-push.js

Fixes: nodejs/code-and-learn#58
PR-URL: #9583
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

@shqld shqld referenced this issue in nodejs/node Jan 12, 2018

Closed

test: replace assert.equal with assert.strictEqual #18119

3 of 3 tasks complete

sreepurnajasti added a commit to sreepurnajasti/node that referenced this issue Jan 25, 2018

@sreepurnajasti sreepurnajasti referenced this issue in nodejs/node Jan 25, 2018

Closed

doc: fix e.g., to e.g. in docs #18369

2 of 2 tasks complete

vsemozhetbyt added a commit to nodejs/node that referenced this issue Jan 25, 2018

doc: fix e.g., to e.g. in docs
PR-URL: #18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

maclover7 added a commit to nodejs/node that referenced this issue Jan 26, 2018

doc: fix e.g., to e.g. in docs
PR-URL: #18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

evanlucas added a commit to nodejs/node that referenced this issue Jan 30, 2018

doc: fix e.g., to e.g. in docs
PR-URL: #18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

evanlucas added a commit to nodejs/node that referenced this issue Jan 30, 2018

doc: fix e.g., to e.g. in docs
PR-URL: #18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

msoechting added a commit to hpicgs/node that referenced this issue Feb 5, 2018

doc: fix e.g., to e.g. in docs
PR-URL: nodejs#18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

msoechting added a commit to hpicgs/node that referenced this issue Feb 7, 2018

doc: fix e.g., to e.g. in docs
PR-URL: nodejs#18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins added a commit to nodejs/node that referenced this issue Feb 27, 2018

doc: fix e.g., to e.g. in docs
PR-URL: #18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MayaLekova added a commit to MayaLekova/node that referenced this issue May 8, 2018

doc: fix e.g., to e.g. in docs
PR-URL: nodejs#18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment