errors: pass missing message parameter to internalAssert
#19908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes the `message` parameter to `internalAssert` when `ERR_INVALID_ARG_TYPE` is thrown with invalid arguments.
nodejs-github-bot
added
the
errors
BridgeAR
approved these changes
Apr 10, 2018
BridgeAR
added
fast-track
|
@cjihrig I agree that we should normally have a test for these things but this will only ever be triggered by trying to wrongly implement the error type, so I guess it is not that important here? |
|
Yea, I suppose so. |
4 tasks
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 12, 2018
Passes the `message` parameter to `internalAssert` when `ERR_INVALID_ARG_TYPE` is thrown with invalid arguments. PR-URL: nodejs#19908 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in bb6de0d 🎉 |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
Passes the `message` parameter to `internalAssert` when `ERR_INVALID_ARG_TYPE` is thrown with invalid arguments. PR-URL: #19908 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the
messageparameter tointernalAssertwhenERR_INVALID_ARG_TYPEis thrown with invalid arguments.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes