test: remove third argument(string literal) from strictEqual() #20920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In test/parallel/test-stream-pip-await-drain-push-while-write.js, There are two calls in it to assert.strictEqual(). Both calls are provided with three arguments. The third argument in each case is a string literal. Unfortunately, that will suppress the presentation of the values of the first two arguments in the case of an AssertionError This is fixed by removing the third argument from the call. The third argument in the call is basically a string literal. Refs: https://www.nodetodo.org/getting-started
lpinca
approved these changes
May 24, 2018
sagirk
approved these changes
May 24, 2018
| @@ -7,17 +7,15 @@ const writable = new stream.Writable({ | |||
| write: common.mustCall(function(chunk, encoding, cb) { | |||
| assert.strictEqual( | |||
| readable._readableState.awaitDrain, | |||
| 0, | |||
| 'State variable awaitDrain is not correct.' | |||
There was a problem hiding this comment.
Would it be a good idea to preserve this message in a comment above the call to assert.strictEqual() — something like this // State variable awaitDrain should be 0?
cc: @Trott
There was a problem hiding this comment.
A static value is always bad. Someone will look at the line anyway, so the context will be clear.
There was a problem hiding this comment.
@sagirk I don't think it's needed in this case. A comment that says "awaitDrain should be 0" is superfluous above await.strictEqual(awaitDrain, 0).
BridgeAR
approved these changes
May 24, 2018
|
@BridgeAR why these following errors are coming up? |
|
@AbhimanyuVashisht our test suite has flaky tests. Just ignore that. |
Trott
approved these changes
May 24, 2018
jasnell
approved these changes
May 24, 2018
trivikr
approved these changes
May 25, 2018
BridgeAR
added
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 25, 2018
Remove obsolete string literals from `assert.strictEqual()` calls in test/parallel/test-stream-pip-await-drain-push-while-write.js. PR-URL: nodejs#20920 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 4970cd6 🎉 I fixed the commit message while landing to adhere to the 72 character rule as described in our guidelines and minimized the text somewhat. @AbhimanyuVashisht congratulations on your first commit to Node.js! 🎉 |
targos
pushed a commit
that referenced
this pull request
May 25, 2018
Remove obsolete string literals from `assert.strictEqual()` calls in test/parallel/test-stream-pip-await-drain-push-while-write.js. PR-URL: #20920 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
test/parallel/test-stream-pip-await-drain-push-while-write.js, There are twocalls in it to
assert.strictEqual(). Both calls are provided with threearguments. The third argument in each case is a string literal. Unfortunately,
that will suppress the presentation of the values of the first two arguments in
the case of an
AssertionErrorThis is fixed by removing the third argument from the call. The third argument
in the call is basically a string literal.
This particular issue is provided by @Trott, Thank you so much for getting me started.
Refs: https://www.nodetodo.org/getting-started
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes