-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: fix promises reads with pos > 4GB #21148
Conversation
PR-URL: nodejs#21148 Fixes: nodejs#21121 Refs: nodejs#21003 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@cjihrig neat! Is this an interface change in GitHub or did you use the interface for landing this? |
For consistency: Landed in 5012587 🎉 |
@ryzokuken I'm not exactly sure what you mean. I landed it from the command line though. |
@cjihrig that's what I wanted to ask, sorry. If you landed this in the standard NCU way, then it's a welcome interface change by GitHub that you didn't have to close this manually and place a comment, it identified that and tagged it as "merged". |
@ryzokuken There is one more step required for this to work. Using ncu, it would look like this:
|
@ryzokuken You can do that manually, GitHub marks commits as merged when the top commit of the PR gets included in the target branch. If you rebase, then push first to the PR branch and then to master — GitHub labels PR as merged. |
If we track the pr branch in ncu then ncu can prompt the command as well (a suggestion with a placeholder for PR branch name also works although). |
Cool, I never knew. Thanks for sharing. |
This commit fixes
fs.promises
based reads with a position greater than 4GB. This ports the changes from #21003 to thefs.promises
module.Refs: #21003
Fixes: #21121
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes