fs: fix promises reads with pos > 4GB

[cjihrig]

This commit fixes fs.promises based reads with a position greater than 4GB. This ports the changes from #21003 to the fs.promises module.

Refs: #21003
Fixes: #21121

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/15267/

[ryzokuken]

@cjihrig neat! Is this an interface change in GitHub or did you use the interface for landing this?

[ryzokuken]

For consistency: Landed in 5012587 🎉

[cjihrig]

@ryzokuken I'm not exactly sure what you mean. I landed it from the command line though.

[ryzokuken]

@cjihrig that's what I wanted to ask, sorry. If you landed this in the standard NCU way, then it's a welcome interface change by GitHub that you didn't have to close this manually and place a comment, it identified that and tagged it as "merged".

[targos]

@ryzokuken There is one more step required for this to work. Using ncu, it would look like this:

...
git node land --final
git push --force origin HEAD:pr-branch
git push upstream master

[ChALkeR]

@ryzokuken You can do that manually, GitHub marks commits as merged when the top commit of the PR gets included in the target branch. If you rebase, then push first to the PR branch and then to master — GitHub labels PR as merged.

[joyeecheung]

If we track the pr branch in ncu then ncu can prompt the command as well (a suggestion with a placeholder for PR branch name also works although).

[ryzokuken]

Cool, I never knew. Thanks for sharing.