win, build: skip building cctest by default #21408

bzoz · 2018-06-19T19:19:50Z

vcbuild will build cctest only if it will be run, or for CI and release builds.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

/cc @nodejs/build-files @nodejs/platform-windows

nodejs-github-bot · 2018-06-19T19:19:51Z

@bzoz build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/99/pipeline

bzoz · 2018-06-19T19:20:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/15525/

BridgeAR · 2018-06-20T16:35:37Z

@nodejs/platform-windows PTAL

seishun · 2018-06-20T16:50:42Z

What's the logic behind building it for release builds?

bzoz · 2018-06-20T23:05:06Z

@seishun: so that CI (which uses something like vcbuild release nosign) will also build cctest.exe

richardlau · 2018-06-20T23:07:52Z

vcbuild.bat

@@ -147,6 +149,7 @@ if defined build_release (
  set licensertf=1
  set download_arg="--download=all"
  set i18n_arg=small-icu
+  set cctest=1


AFAIK on the release CI (where build_release is used) tests aren't run. Anyone from @nodejs/releasers / @nodejs/build / @nodejs/platform-windows able to confirm?

They are probably not, but I guess someone somewhere might depend on that. This change will not make big change in terms of building release binaries, it is mostly aimed to help out when developing Node.

bzoz · 2018-06-26T06:57:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/15626/

bzoz · 2018-06-26T16:58:05Z

CI is green, can I have +1?

/cc @nodejs/platform-windows @nodejs/build-files

bzoz · 2018-06-28T14:18:26Z

ping?

joyeecheung · 2018-07-04T11:50:29Z

I am a bit confused by the title, does this patch skip building cctest by default in normal dev workflows?

bzoz · 2018-07-04T12:57:28Z

Yes. It will get built if you do vcbuild test though.

joyeecheung · 2018-07-04T13:07:39Z

@bzoz Oh right I understand now, this moves cctest out of vcbuild that's not supposed to build tests.

joyeecheung · 2018-07-04T13:09:33Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/15724/

addaleax · 2018-07-18T14:14:19Z

ping @nodejs/platform-windows ?

joaocgreis

Left two comments, otherwise looks good.

vcbuild.bat

lundibundi · 2018-08-27T21:55:36Z

@bzoz ping? =)

bzoz · 2018-08-28T12:00:36Z

Updated, but now it fails to build node from clean checkout:

LINK : fatal error LNK1104: cannot open file 'C:\...\node\Release\obj\global_intermediate\openssl.def' [C:\...\node\node.vcxproj]

lundibundi · 2018-08-28T20:20:12Z

vcbuild.bat

+  if "%test_args%"=="" set target=rename_node_bin_win 
+  if defined cctest set target="Build"
+)
+if "%target%"=="rename_node_bin_win" if exist "%config%\cctest.exe" del "%config%\cctest.exe"


First time seeing this file, so may be completely wrong, but: shouldn't you actually also assign target = node here?

@lundibundi not sure I understand your question, target might have just been changed above. This uses rename_node_bin_win instead of just node to be compatible with vcbuild dll, but should be the same otherwise.

Yeah rename_node_bin_win is an old kludge.

node/node.gyp

Lines 834 to 842 in d1a55d3

{

# When using shared lib to build executable in Windows, in order to avoid

# filename collision, the executable name is node-win.exe. Need to rename

# it back to node.exe

'target_name': 'rename_node_bin_win',

'type': 'none',

'dependencies': [

'<(node_core_target_name)',

],

I have a refactor for this in the pipeline.

lundibundi · 2018-09-19T11:05:33Z

ping @bzoz.

bzoz · 2018-10-24T11:04:52Z

Updated, PTAL.

It looks like the linking issue got resolved, the codebase builds correctly after clean checkout.

bzoz · 2018-10-24T11:05:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/18109/

bzoz · 2018-10-25T11:17:34Z

Resumed with fixed vcbuild: https://ci.nodejs.org/job/node-test-pull-request/18138/

joaocgreis · 2018-11-22T01:04:03Z

vcbuild.bat

-if "%target%"=="Build" if defined no_cctest set target=node
+if "%target%"=="Build" (
+  if defined no_cctest set target=rename_node_bin_win
+  if "%test_args%"=="" set target=rename_node_bin_win 


Suggested change

if "%test_args%"=="" set target=rename_node_bin_win

if "%test_args%"=="" set target=rename_node_bin_win

nit: trailing whitespace

refack · 2018-11-22T01:16:08Z

vcbuild.bat

 set openssl_no_asm=
 set doc=

 :next-arg
 if "%1"=="" goto args-done
 if /i "%1"=="debug"         set config=Debug&goto arg-ok
-if /i "%1"=="release"       set config=Release&set ltcg=1&set "pch="&goto arg-ok
+if /i "%1"=="release"       set config=Release&set ltcg=1&set "pch="&set cctest=1&goto arg-ok


maybe we should create a ci target, since the "real" release doesn't need cctest either.

SGTM, this should converge to be like the Makefile, including the distinction between compiling and js-only targets. Currently cctest runs and the addons are compiled everywhere, unnecessarily.

vcbuild will build cctest only if it will be run, or for CI and release builds

bzoz · 2018-11-22T11:03:51Z

Fixed whitespace and reabased, PTAL

bzoz · 2018-11-22T11:22:58Z

looks like Travis is having issues, cc @nodejs/build-infra ?

rvagg · 2018-11-22T11:37:57Z

https://travis-ci.com/nodejs/node/jobs/160294272

"message": "API rate limit exceeded for 35.192.187.174. (But here'''s the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
"documentation_url": "https://developer.github.com/v3/#rate-limiting"

@bzoz Ignore the error for now, it's clear that your commit message is fine.

We only get 60 requests per hour unauthenticated.. I suppose we'll need to get authentication into that script.

@richardlau @addaleax thoughts on where we should log an issue about this? Is it something we should take on in Build since it's going to require credentials and inclusion of secrets?

rvagg · 2018-11-22T11:39:01Z

Oh, and we're sharing rate limiting with everyone else using these Travis hosts, so we're bound to run into this with some regularity. I'm surprised it hasn't come up before; maybe it has?

richardlau · 2018-11-22T11:53:47Z

Oh, and we're sharing rate limiting with everyone else using these Travis hosts, so we're bound to run into this with some regularity. I'm surprised it hasn't come up before; maybe it has?

Yes, it has. I've opened #24567 to track separately.

bzoz · 2018-11-22T14:07:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/18883/

bzoz · 2018-11-29T09:43:42Z

Landed in 2c473d6

vcbuild will build cctest only if it will be run, or for CI and release builds PR-URL: #21408 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

vcbuild will build cctest only if it will be run, or for CI and release builds PR-URL: nodejs#21408 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

vcbuild will build cctest only if it will be run, or for CI and release builds PR-URL: #21408 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jun 19, 2018

richardlau reviewed Jun 20, 2018

View reviewed changes

bzoz force-pushed the bartek-cctest-when-needed branch from 66b12aa to 1115174 Compare June 27, 2018 09:05

joaocgreis suggested changes Jul 24, 2018

View reviewed changes

vcbuild.bat Show resolved Hide resolved

vcbuild.bat Outdated Show resolved Hide resolved

bzoz force-pushed the bartek-cctest-when-needed branch from 1115174 to 7535c04 Compare August 28, 2018 11:59

lundibundi reviewed Aug 28, 2018

View reviewed changes

jasnell added the stalled Issues and PRs that are stalled. label Oct 17, 2018

bzoz force-pushed the bartek-cctest-when-needed branch from 7535c04 to 4167341 Compare October 24, 2018 10:48

bzoz removed the stalled Issues and PRs that are stalled. label Oct 24, 2018

joaocgreis approved these changes Nov 22, 2018

View reviewed changes

refack reviewed Nov 22, 2018

View reviewed changes

refack approved these changes Nov 22, 2018

View reviewed changes

win, build: skip building cctest by default

c525367

vcbuild will build cctest only if it will be run, or for CI and release builds

bzoz force-pushed the bartek-cctest-when-needed branch from 82e34f3 to c525367 Compare November 22, 2018 10:54

richardlau mentioned this pull request Nov 22, 2018

Hitting rate limits with Travis commit message linting #24567

Closed

bzoz closed this Nov 29, 2018

BridgeAR mentioned this pull request Dec 5, 2018

v11.4.0 proposal #24854

Merged

4 tasks

BethGriggs added the land-on-v10.x label Feb 12, 2019

BethGriggs mentioned this pull request Feb 12, 2019

v10.15.3 proposal #26063

Merged

	{
	# When using shared lib to build executable in Windows, in order to avoid
	# filename collision, the executable name is node-win.exe. Need to rename
	# it back to node.exe
	'target_name': 'rename_node_bin_win',
	'type': 'none',
	'dependencies': [
	'<(node_core_target_name)',
	],

	if "%test_args%"=="" set target=rename_node_bin_win
	if "%test_args%"=="" set target=rename_node_bin_win

win, build: skip building cctest by default #21408

win, build: skip building cctest by default #21408

Conversation

bzoz commented Jun 19, 2018

Checklist

nodejs-github-bot commented Jun 19, 2018

bzoz commented Jun 19, 2018

BridgeAR commented Jun 20, 2018 • edited Loading

seishun commented Jun 20, 2018

bzoz commented Jun 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bzoz commented Jun 26, 2018

bzoz commented Jun 26, 2018

bzoz commented Jun 28, 2018

joyeecheung commented Jul 4, 2018

bzoz commented Jul 4, 2018

joyeecheung commented Jul 4, 2018

joyeecheung commented Jul 4, 2018

addaleax commented Jul 18, 2018

joaocgreis left a comment

Choose a reason for hiding this comment

lundibundi commented Aug 27, 2018

bzoz commented Aug 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lundibundi commented Sep 19, 2018

bzoz commented Oct 24, 2018

bzoz commented Oct 24, 2018

bzoz commented Oct 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bzoz commented Nov 22, 2018

bzoz commented Nov 22, 2018

rvagg commented Nov 22, 2018

rvagg commented Nov 22, 2018

richardlau commented Nov 22, 2018

bzoz commented Nov 22, 2018

bzoz commented Nov 29, 2018

BridgeAR commented Jun 20, 2018 •

edited

Loading