-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: add HandleWrap::AddWrapMethods #21769
Conversation
Extracts common setters to a single location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just fyi, I’d love to eventually move to using real function template inheritance for this :)
src/handle_wrap.cc
Outdated
@@ -130,4 +131,13 @@ void HandleWrap::OnClose(uv_handle_t* handle) { | |||
} | |||
|
|||
|
|||
void HandleWrap::AddWrapMethods(Environment* env, | |||
Local<FunctionTemplate> t) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: indent alignment is slightly off on this line
CI before landing: https://ci.nodejs.org/job/node-test-pull-request/15848/ |
Landed in 45732c7 |
Extracts common setters to a single location PR-URL: #21769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Should land cleanly on v10.x-staging after #21458 |
Extracts common setters to a single location PR-URL: #21769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Extracts common setters to a single location
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes