-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add CONFIG_FLAGS to with-code-cache target #22207
Conversation
@nodejs/build-files |
Makefile
Outdated
.PHONY: with-code-cache | ||
with-code-cache: | ||
$(PYTHON) ./configure | ||
$(PYTHON) ./configure $(debug_flag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be better to make the ./configure
invocations in this recipe take $(CONFIG_FLAGS)
(like the other invocations of ./configure
in this file) and then the ifeq
statement a few lines up could append --debug
to that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was not aware of the CONFIG_FLAGS
, I'll take a look. Thanks!
This commit adds CONFIG_FLAGS to allow the with-code-cache target to be used with a debug build. The motivation for this is to make it easier to debug a build with the code cache enabled. The suggested usage: $ make BUILDTYPE=Debug with-code-cache The BUILDTYPE option is not needed if ./configure was already configured with --debug.
cd54fa3
to
2345a6c
Compare
Updated and rebased CI: https://ci.nodejs.org/job/node-test-pull-request/16333/ |
(One failure on CI is due to a SmartOS 17 machine that has been having issues, this should be safe to land) |
Landed in ec8f31d |
This commit adds CONFIG_FLAGS to allow the with-code-cache target to be used with a debug build. The motivation for this is to make it easier to debug a build with the code cache enabled. The suggested usage: $ make BUILDTYPE=Debug with-code-cache The BUILDTYPE option is not needed if ./configure was already configured with --debug. PR-URL: #22207 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
This commit adds CONFIG_FLAGS to allow the with-code-cache target to be used with a debug build. The motivation for this is to make it easier to debug a build with the code cache enabled. The suggested usage: $ make BUILDTYPE=Debug with-code-cache The BUILDTYPE option is not needed if ./configure was already configured with --debug. PR-URL: #22207 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
This commit adds CONFIG_FLAGS to allow the
with-code-cache
target to beused with a debug build. The motivation for this is to make it easier to
debug a build with the code cache enabled.
The suggested usage:
The
BUILDTYPE
option is not needed if ./configure was alreadyconfigured with --debug.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes