build: add CONFIG_FLAGS to with-code-cache target #22207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
@nodejs/build-files |
richardlau
reviewed
Aug 9, 2018
Makefile
Outdated
| .PHONY: with-code-cache | ||
| with-code-cache: | ||
| $(PYTHON) ./configure | ||
| $(PYTHON) ./configure $(debug_flag) |
There was a problem hiding this comment.
Perhaps it would be better to make the ./configure invocations in this recipe take $(CONFIG_FLAGS) (like the other invocations of ./configure in this file) and then the ifeq statement a few lines up could append --debug to that?
There was a problem hiding this comment.
Ah, I was not aware of the CONFIG_FLAGS, I'll take a look. Thanks!
This commit adds CONFIG_FLAGS to allow the with-code-cache target to be used with a debug build. The motivation for this is to make it easier to debug a build with the code cache enabled. The suggested usage: $ make BUILDTYPE=Debug with-code-cache The BUILDTYPE option is not needed if ./configure was already configured with --debug.
danbev
force-pushed
the
build_codecache_debug_flag
branch
from
cd54fa3
to
2345a6c
Compare
danbev
changed the title
|
Updated and rebased CI: https://ci.nodejs.org/job/node-test-pull-request/16333/ |
richardlau
approved these changes
Aug 10, 2018
joyeecheung
approved these changes
Aug 10, 2018
refack
approved these changes
Aug 10, 2018
maclover7
approved these changes
Aug 11, 2018
maclover7
added
the
author ready
|
(One failure on CI is due to a SmartOS 17 machine that has been having issues, this should be safe to land) |
|
Landed in ec8f31d |
maclover7
pushed a commit
that referenced
this pull request
Aug 12, 2018
This commit adds CONFIG_FLAGS to allow the with-code-cache target to be used with a debug build. The motivation for this is to make it easier to debug a build with the code cache enabled. The suggested usage: $ make BUILDTYPE=Debug with-code-cache The BUILDTYPE option is not needed if ./configure was already configured with --debug. PR-URL: #22207 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos
pushed a commit
that referenced
this pull request
Aug 12, 2018
This commit adds CONFIG_FLAGS to allow the with-code-cache target to be used with a debug build. The motivation for this is to make it easier to debug a build with the code cache enabled. The suggested usage: $ make BUILDTYPE=Debug with-code-cache The BUILDTYPE option is not needed if ./configure was already configured with --debug. PR-URL: #22207 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds CONFIG_FLAGS to allow the
with-code-cachetarget to beused with a debug build. The motivation for this is to make it easier to
debug a build with the code cache enabled.
The suggested usage:
The
BUILDTYPEoption is not needed if ./configure was alreadyconfigured with --debug.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes