-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: add missing HandleScope in FieldType::PrintTo #22890
Conversation
25eb609
to
4e596b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hashseed Hope it’s okay to ask… Is it always okay to “just” add a HandleScope
, or can V8 be in a state where that (or allocating handles in general) is not allowed?
Given the narrow scope of the change, would it make sense to fast track this to get CI back to green? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the test that's been failing, so I'm 👍. Since this is a change in deps/v8/src
, do we have to do anything special to make sure the patch gets re-floated when we update? (I guess that question may be for @nodejs/v8-update.)
@Trott no need to refloat. It has been fixed as a byproduct of a refactoring. @addaleax creating handle scopes and handles only hurts if done in a loop, it could slow down performance. You can't create handles outside the main thread of course. Also a handle scopes also limits handles created inside it to that scope. |
Resume build: https://ci.nodejs.org/job/node-test-pull-request/17258/ I think arm-fanned doesn't play well with Resume Build so that one may need a Rebuild... Anyway, all failures look unrelated to this change, of course (and mostly build/infra related). |
Landed in dafaa6e. |
Closing, since this has landed :) |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes (https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)