src: deprecate UVException() without Isolate*
#23175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method, like all other methods which use `Isolate::GetCurrent()`, should be avoided. This was probably overlooked in 75adde0.
addaleax
added
c++
tniessen
approved these changes
Sep 30, 2018
cjihrig
approved these changes
Sep 30, 2018
joyeecheung
approved these changes
Sep 30, 2018
2 tasks
devsnek
approved these changes
Sep 30, 2018
jasnell
approved these changes
Oct 1, 2018
BridgeAR
approved these changes
Oct 1, 2018
addaleax
added
the
author ready
|
Landed in c3aaaa7. |
danbev
pushed a commit
that referenced
this pull request
Oct 4, 2018
This method, like all other methods which use `Isolate::GetCurrent()`, should be avoided. This was probably overlooked in 75adde0. PR-URL: #23175 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2018
This method, like all other methods which use `Isolate::GetCurrent()`, should be avoided. This was probably overlooked in 75adde0. PR-URL: #23175 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Oct 10, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
This method, like all other methods which use `Isolate::GetCurrent()`, should be avoided. This was probably overlooked in 75adde0. PR-URL: #23175 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method, like all other methods which use
Isolate::GetCurrent(), should be avoided.This was probably overlooked in 75adde0.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes