Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix order of parameters to assert.strictEqual #23590

Closed
wants to merge 1 commit into from
Closed

test: fix order of parameters to assert.strictEqual #23590

wants to merge 1 commit into from

Conversation

jasonnutter
Copy link
Contributor

@jasonnutter jasonnutter commented Oct 12, 2018 •
edited

Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

This should be reversed, per the assert documentation.

Refs: https://nodejs.org/api/assert.html#assert_assert_strictequal_actual_expected_message

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targos targos added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
@addaleax addaleax added net Issues and PRs related to the net subsystem. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 12, 2018
thefourtheye
thefourtheye approved these changes Oct 13, 2018
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message line length should be < 72 characters.

@jasonnutter
test: fix order of parameters to assert.strictEqual
e8e5ea3 
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

This should be reversed, per the assert documentation.

Refs: https://nodejs.org/api/assert.html#assert_assert_strictequal_actual_expected_message
@jasonnutter
Copy link
Contributor Author

@thefourtheye Whoops, fixed.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@jasonnutter @BridgeAR
test: fix order of parameters to assert.strictEqual
6e017f9 
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

PR-URL: nodejs#23590
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@jasonnutter @BridgeAR
test: fix order of parameters to assert.strictEqual
1343891 
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

PR-URL: nodejs#23590
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@BridgeAR
Copy link
Member

Landed in 1343891 🎉

@jasonnutter congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jasonnutter @jasnell
test: fix order of parameters to assert.strictEqual
59a221d 
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

PR-URL: #23590
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@jasonnutter @addaleax
test: fix order of parameters to assert.strictEqual
7d60a22 
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

PR-URL: #23590
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@jasonnutter @MylesBorins
test: fix order of parameters to assert.strictEqual
9439e3e 
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

PR-URL: #23590
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasonnutter @rvagg
test: fix order of parameters to assert.strictEqual
7c32282 
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

PR-URL: #23590
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jasonnutter @MylesBorins
test: fix order of parameters to assert.strictEqual
ff22625 
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

PR-URL: #23590
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@jasonnutter @BridgeAR @jasnell @thefourtheye @cjihrig @gireeshpunathil @trivikr @addaleax @targos @nodejs-github-bot