Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding test coverage for SourceTextModule.evaluate #23595

Closed
wants to merge 4 commits into from
Closed

test: adding test coverage for SourceTextModule.evaluate #23595

wants to merge 4 commits into from

Conversation

kaltepeter
Copy link
Contributor

This checks that invalid option throws an error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@kaltepeter
test: adding test coverage for SourceTextModule.evaluate
704bc13 
This checks that invalid option throws an error.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@addaleax
Copy link
Member

(Also: Nice first contribution!)

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17759/

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. vm Issues and PRs related to the vm subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. labels Oct 12, 2018
@Trott
Copy link
Member

Trott commented Oct 12, 2018 •
edited
Loading

Collaborators, 👍 to approve fast-tracking this PR.

UPDATE: @addaleax has 👍 this for fast-tracking offline.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 12, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 13, 2018
@kaltepeter @Trott
test: adding test coverage for SourceTextModule.evaluate
6cd5c74 
This checks that invalid option throws an error.

PR-URL: nodejs#23595
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 13, 2018

Landed in 6cd5c74

@Trott Trott closed this Oct 13, 2018
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@kaltepeter @addaleax
test: adding test coverage for SourceTextModule.evaluate
61cb4cf 
This checks that invalid option throws an error.

PR-URL: #23595
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@kaltepeter @jasnell
test: adding test coverage for SourceTextModule.evaluate
0579784 
This checks that invalid option throws an error.

PR-URL: #23595
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@kaltepeter @MylesBorins
test: adding test coverage for SourceTextModule.evaluate
484dccb 
This checks that invalid option throws an error.

PR-URL: #23595
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@kaltepeter @rvagg
test: adding test coverage for SourceTextModule.evaluate
066b106 
This checks that invalid option throws an error.

PR-URL: #23595
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@kaltepeter @MylesBorins
test: adding test coverage for SourceTextModule.evaluate
f55b4f1 
This checks that invalid option throws an error.

PR-URL: #23595
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@kaltepeter kaltepeter deleted the code-coverage branch May 8, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kaltepeter @addaleax @Trott @jasnell @TimothyGu @BridgeAR @targos @nodejs-github-bot