New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: fix priority queue removeAt fn #23870

Closed
wants to merge 1 commit into
base: master
from

Conversation

@apapirovski
Member

apapirovski commented Oct 25, 2018

🤷‍♂️ I'm an idiot... and we probably should get a release out (11.0.1)... @nodejs/tsc

Fixes: #23860

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@apapirovski apapirovski requested review from ChALkeR and Fishrock123 Oct 25, 2018

@apapirovski

This comment has been minimized.

Member

apapirovski commented Oct 25, 2018

@targos

This comment has been minimized.

Member

targos commented Oct 25, 2018

I suppose you want to fast-track?

I can promote the release today or tomorrow, if someone else prepares it.

@apapirovski

This comment has been minimized.

Member

apapirovski commented Oct 25, 2018

Please 👍 this if you approve fast tracking.

@apapirovski apapirovski added the timers label Oct 25, 2018

@mcollina

LGTM and +1 to fast track. Can you add a test with timers as well?

@Trott

This comment has been minimized.

Member

Trott commented Oct 25, 2018

Commit pushed since last CI. CI again: https://ci.nodejs.org/job/node-test-pull-request/18147/

@apapirovski

This comment has been minimized.

Member

apapirovski commented Oct 25, 2018

@Trott technically I updated the CI after the commit :)

@jasnell

A fast-track is good. There are a few more commits landed in master that should be in an 11.0.1 release. Let's make sure we pull in the other semver-patch commits.

@Trott

This comment has been minimized.

Member

Trott commented Oct 25, 2018

+1 to fast-track

Trott added a commit to Trott/io.js that referenced this pull request Oct 25, 2018

timers: fix priority queue removeAt fn
PR-URL: nodejs#23870
Fixes: nodejs#23860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Member

Trott commented Oct 25, 2018

Landed in 958d5b7.

The request from @mcollina for an additional test can be added as a separate PR if highly desirable. I assumed it was an optional nit based on their approval. Hope that was OK.

@Trott Trott closed this Oct 25, 2018

@mcollina

This comment has been minimized.

Member

mcollina commented Oct 25, 2018

targos added a commit that referenced this pull request Oct 26, 2018

timers: fix priority queue removeAt fn
PR-URL: #23870
Fixes: #23860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos targos referenced this pull request Oct 27, 2018

Merged

Release proposal: v11.1.0 #23922

targos added a commit that referenced this pull request Oct 28, 2018

2018-10-30, Version 11.1.0 (Current)
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

targos added a commit that referenced this pull request Nov 1, 2018

timers: fix priority queue removeAt fn
PR-URL: #23870
Fixes: #23860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Nov 1, 2018

2018-11-02, Version 11.1.0 (Current)
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

targos added a commit that referenced this pull request Nov 2, 2018

2018-11-02, Version 11.1.0 (Current)
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922
@podarok

This comment has been minimized.

podarok commented Nov 15, 2018

Thank you for the fix.
I spent 3 days to blame node-red hanging at 100%CPU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment