New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icu4c 63.1 #23715

Merged
merged 0 commits into from Oct 24, 2018

Conversation

@srl295
Member

srl295 commented Oct 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

The usual 63.1 bump:

  • icu 63.1 bump (CLDR 34) …
    • The following languages have been added to ICU: Sindhi, Maori, Turkmen, Javanese, Interlingua, Kurdish (ku), Xhosa, plus many data improvements.
    • Japanese new era testing support
  • Full release notes: http://site.icu-project.org/download/63

Fixes: #22344

  • Also, support URL failover for downloading ICU (full-icu mode). I added 2 extra URLs.
    Note shiny new github URL as primary!

@srl295 srl295 added the intl label Oct 17, 2018

@srl295 srl295 self-assigned this Oct 17, 2018

@srl295 srl295 requested a review from refack Oct 17, 2018

@srl295

This comment has been minimized.

Member

srl295 commented Oct 19, 2018

confirmed that #22156 is fixed with this merge

@srl295 srl295 requested a review from devsnek Oct 19, 2018

@@ -38,6 +38,9 @@ def retrievefile(url, targetfile):
ConfigOpener().retrieve(url, targetfile, reporthook=reporthook)
print '' # clear the line
return targetfile
except IOError as err:
print ' ** IOError %s\n' % err

This comment has been minimized.

@cclauss

cclauss Oct 21, 2018

Contributor

Please put from __future__ import print_function at the top of this file above other imports and then use the print() function instead of the print statement to be ready for Python 3. There are 437 days until Python 2 end of life.

This comment has been minimized.

@srl295

srl295 Oct 22, 2018

Member

@cclauss thanks, will do.

@refack

refack approved these changes Oct 22, 2018

Python changes LGTM with nit fixed
ICU bump RSLGTM

@cclauss

LGTM, thanks.

@richardlau

Build files/tools changes LGTM.
RSLGTM ICU bump.

@srl295

This comment has been minimized.

Member

srl295 commented Oct 23, 2018

@srl295

This comment has been minimized.

Member

srl295 commented Oct 23, 2018

should be semver minor

@srl295

This comment has been minimized.

Member

srl295 commented Oct 24, 2018

@srl295

This comment has been minimized.

Member

srl295 commented Oct 24, 2018

Ci now good

@mhdawson

Rubber stamp LGTM

@srl295 srl295 closed this Oct 24, 2018

srl295 added a commit to srl295/node that referenced this pull request Oct 24, 2018

tools, icu: actually failover if there are multiple URLs
Building on nodejs#23269, if multiple ICU download URLs are present, try the
next one in case of error.

Part of the ICU 63.1 bump, but independent code-wise.
nodejs#23244

PR-URL: nodejs#23715
Fixes: nodejs#22344
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@srl295 srl295 merged commit 6786ff4 into nodejs:master Oct 24, 2018

@cclauss

This comment has been minimized.

Contributor

cclauss commented Oct 24, 2018

Awesome work here! Thanks.

@srl295 srl295 deleted the srl295:icu4c-63.1 branch Oct 24, 2018

targos added a commit that referenced this pull request Oct 26, 2018

tools, icu: actually failover if there are multiple URLs
Building on #23269, if multiple ICU download URLs are present, try the
next one in case of error.

Part of the ICU 63.1 bump, but independent code-wise.
#23244

PR-URL: #23715
Fixes: #22344
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos added a commit that referenced this pull request Oct 26, 2018

deps: icu 63.1 bump (CLDR 34)
- Full release notes: http://site.icu-project.org/download/63

Fixes: #22344

PR-URL: #23715
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@targos targos referenced this pull request Oct 27, 2018

Merged

Release proposal: v11.1.0 #23922

targos added a commit that referenced this pull request Oct 28, 2018

2018-10-30, Version 11.1.0 (Current)
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

hashseed added a commit to v8/node that referenced this pull request Oct 31, 2018

deps: icu 63.1 bump (CLDR 34)
- Full release notes: http://site.icu-project.org/download/63

Fixes: nodejs#22344

PR-URL: nodejs#23715
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos added a commit that referenced this pull request Nov 1, 2018

2018-11-02, Version 11.1.0 (Current)
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

targos added a commit that referenced this pull request Nov 2, 2018

2018-11-02, Version 11.1.0 (Current)
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

@richardlau richardlau referenced this pull request Nov 5, 2018

Closed

deps: ICU4C 63.1 #23244

rvagg added a commit to nodejs/changelog-maker that referenced this pull request Nov 9, 2018

minor nit
Fake PR-URL for testing:

PR-URL: nodejs/node#23715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment