Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code property added for rangeError #23968

Closed
wants to merge 1 commit into from

Conversation

@mritunjayz
Copy link
Contributor

commented Oct 30, 2018

Checklist
@lpinca
lpinca approved these changes Oct 30, 2018
@Trott

This comment has been minimized.

@Trott Trott added the author ready label Oct 31, 2018

@AyushG3112

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

Typo in commit message: rangrError -> RangeError

@mritunjayz mritunjayz force-pushed the mritunjayz:to-do-buffer-copy branch from 74a3436 to b220d42 Oct 31, 2018

@mritunjayz mritunjayz changed the title code property added for rangrError code property added for rangeError Oct 31, 2018

@Trott

This comment has been minimized.

@mritunjayz

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2018

1 failing test ? @Trott

@cjihrig
cjihrig approved these changes Nov 1, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Landed in a6e836a

@Trott Trott closed this Nov 2, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 2, 2018
test: add property for RangeError in test-buffer-copy
PR-URL: nodejs#23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos added a commit that referenced this pull request Nov 2, 2018
test: add property for RangeError in test-buffer-copy
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Nov 14, 2018
MylesBorins added a commit that referenced this pull request Nov 27, 2018
test: add property for RangeError in test-buffer-copy
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 27, 2018
test: add property for RangeError in test-buffer-copy
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
test: add property for RangeError in test-buffer-copy
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: add property for RangeError in test-buffer-copy
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
test: add property for RangeError in test-buffer-copy
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
MylesBorins added a commit that referenced this pull request Dec 3, 2018
test: add property for RangeError in test-buffer-copy
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.