Join GitHub today
crypto: add key object API #24234
Preamble: This is a huge change and I will do my best to help with reviewing it. There might still be dozens of places that need some work, but so far, everything seems to be working nicely. I summarized the motivation behind this change in #15113 (comment). There are also lots of possible discussions around this, e.g. whether key derivation should consume / produce key objects etc.
This commit makes multiple important changes:
referenced this pull request
Nov 7, 2018
What are the differences between this new API and the API exposed through web crypto? Could we realistically change this API to be compatible?
WebCrypto has a very different design. I originally called the new API
Rebased, old HEAD was 6c92496.
I really like the direction, I think its a good API. Left some comments, mostly on the API. The C++ is a lot to read through, sorry, I ran out of time. I would prefer this not be experimental. I assume it doesn't intentionally break current APIs, and it also isn't particularly complex in terms of its API, so its hard to see it generating much comment or controversy or need to change. Would be great if it can go into 11.x, get some mileage there, and be stable in 12.xx. I doubt it can make it into 10.x, its a lot of churn.