Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update remark version to v10 from v8 #24333

Closed
wants to merge 3 commits into from

Conversation

@watilde
Copy link
Member

commented Nov 13, 2018

Including the below two updates:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@richardlau

This comment has been minimized.

Copy link
Member

commented Nov 13, 2018

I think we also need to regenerate tools/lint-md.js.

@watilde

This comment has been minimized.

Copy link
Member Author

commented Nov 13, 2018

@richardlau That's right. Apparently, lint-md-rollup was always using the latest version by using npm up and I replaced it with npm install to bring the versions under a control. Then I regenerated tools/lint-md.js.

cc @refack

@refack
refack approved these changes Nov 13, 2018
Copy link
Member

left a comment

LGTM

@refack

This comment has been minimized.

Copy link
Member

commented Nov 13, 2018

I saw make lint-md-rollup as an all-in-one recepie to update lint-md.js. But I agree it makes sense to have a way that deterministically reproduces it...

@watilde

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2018

@danbev
danbev approved these changes Nov 16, 2018
@danbev

This comment has been minimized.

Copy link
Member

commented Nov 16, 2018

Landed in 62d053b, 195b7c2, and eeed6d9.

@danbev danbev closed this Nov 16, 2018

danbev added a commit that referenced this pull request Nov 16, 2018
tools: update remark version to v10 from v8
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
danbev added a commit that referenced this pull request Nov 16, 2018
tools: update remark-lint to v6.0.3 from v6.0.2
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
danbev added a commit that referenced this pull request Nov 16, 2018
tools: fix `make lint-md-rollup` and run it
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

@watilde watilde deleted the watilde:feature/update-remark branch Nov 16, 2018

targos added a commit that referenced this pull request Nov 18, 2018
tools: update remark version to v10 from v8
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos added a commit that referenced this pull request Nov 18, 2018
tools: update remark-lint to v6.0.3 from v6.0.2
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos added a commit that referenced this pull request Nov 18, 2018
tools: fix `make lint-md-rollup` and run it
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
tools: update remark version to v10 from v8
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
tools: update remark-lint to v6.0.3 from v6.0.2
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
tools: fix `make lint-md-rollup` and run it
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 12, 2019
tools: update remark version to v10 from v8
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere added a commit that referenced this pull request Jan 12, 2019
tools: update remark-lint to v6.0.3 from v6.0.2
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere added a commit that referenced this pull request Jan 12, 2019
tools: fix `make lint-md-rollup` and run it
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
codebytere added a commit that referenced this pull request Jan 29, 2019
tools: update remark version to v10 from v8
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
tools: update remark-lint to v6.0.3 from v6.0.2
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
tools: fix `make lint-md-rollup` and run it
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.