Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused function arguments in async-hooks tests #24368

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Nov 14, 2018

Remove unused function arguments in two async-hooks tests.

(This actually started as a bigger change but then I realized the bigger change was wrong. Oops.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: remove unused function arguments in async-hooks tests
Remove unused function arguments in two async-hooks tests.
@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2018

@lpinca
lpinca approved these changes Nov 14, 2018
@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2018

@mhdawson
Copy link
Member

left a comment

LGTM

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2018

Took problematic host offline. Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18620/

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2018

Landed in b7e9804

@Trott Trott closed this Nov 16, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 16, 2018
test: remove unused function arguments in async-hooks tests
Remove unused function arguments in two async-hooks tests.

PR-URL: nodejs#24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos added a commit that referenced this pull request Nov 18, 2018
test: remove unused function arguments in async-hooks tests
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: remove unused function arguments in async-hooks tests
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 12, 2019
test: remove unused function arguments in async-hooks tests
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
codebytere added a commit that referenced this pull request Jan 29, 2019
test: remove unused function arguments in async-hooks tests
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.