Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unused function arguments in async-hooks tests #24368

Closed
wants to merge 1 commit into from
Closed

test: remove unused function arguments in async-hooks tests #24368

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 14, 2018

Remove unused function arguments in two async-hooks tests.

(This actually started as a bigger change but then I realized the bigger change was wrong. Oops.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: remove unused function arguments in async-hooks tests
291ac64 
Remove unused function arguments in two async-hooks tests.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1616/pipeline

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Nov 14, 2018
@Trott
Copy link
Member Author

Trott commented Nov 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18617/

@Trott
Copy link
Member Author

Trott commented Nov 14, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18618/

mhdawson
mhdawson approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Nov 14, 2018

Took problematic host offline. Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18620/

@Trott
Copy link
Member Author

Trott commented Nov 16, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18668/

@Trott
Copy link
Member Author

Trott commented Nov 16, 2018

Landed in b7e9804

@Trott Trott closed this Nov 16, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 16, 2018
@Trott
test: remove unused function arguments in async-hooks tests
b7e9804 
Remove unused function arguments in two async-hooks tests.

PR-URL: nodejs#24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 18, 2018
@Trott @targos
test: remove unused function arguments in async-hooks tests
3682561 
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
test: remove unused function arguments in async-hooks tests
ee64ae0 
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@Trott @codebytere
test: remove unused function arguments in async-hooks tests
979ea16 
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@Trott @codebytere
test: remove unused function arguments in async-hooks tests
987df27 
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the async-hooks-unused branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @nodejs-github-bot @fhinkel @addaleax @lpinca @mhdawson