Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace anonymous closure for test-http-expect-handling.js #24423

Closed
wants to merge 1 commit into from

Conversation

@Jayasankar-m
Copy link
Contributor

commented Nov 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@Jayasankar-m Jayasankar-m force-pushed the Jayasankar-m:jsnew branch from b79f924 to c792fb7 Nov 17, 2018

@targos
targos approved these changes Nov 17, 2018
Copy link
Member

left a comment

Changes LGTM.

Commit message should start with test: replace ...

@targos

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track label Nov 17, 2018

@gireeshpunathil

This comment has been minimized.

@Trott Trott added the author ready label Nov 18, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

Landed in 1dadaf9

@Trott Trott closed this Nov 18, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 18, 2018
test:replace anonymous closure for test-http-expect-handling.js
PR-URL: nodejs#24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 18, 2018
test:replace anonymous closure for test-http-expect-handling.js
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

@Trott did core-validate-commit accept the message? I'm asking because there should be a space after the colon.

@richardlau

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

@Trott did core-validate-commit accept the message? I'm asking because there should be a space after the colon.

Apparently it did:

https://travis-ci.com/nodejs/node/jobs/159274629#L695-L703

test:replace anonymous closure for test-http-expect-handling.js
+npx -q core-validate-commit --no-validate-metadata https://api.github.com/repos/nodejs/node/commits/c792fb7a10120092bfb3847d76d7691490152226
  ✔  c792fb7a10120092bfb3847d76d7691490152226
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
@targos

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

rvagg added a commit that referenced this pull request Nov 28, 2018
test:replace anonymous closure for test-http-expect-handling.js
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
test:replace anonymous closure for test-http-expect-handling.js
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test:replace anonymous closure for test-http-expect-handling.js
PR-URL: nodejs#24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
codebytere added a commit that referenced this pull request Jan 29, 2019
test:replace anonymous closure for test-http-expect-handling.js
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.