Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src:Elevate v8 namespaces of repeatedly referenced artifacts with #24429

Closed
wants to merge 1 commit into from

Conversation

@manilson
Copy link

commented Nov 17, 2018

'using' keyword in src/node_i18n.cc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
src/node_i18n.cc Outdated Show resolved Hide resolved
@targos

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

The commit message should start with src: elevate ... and its first line should be shorter (max 50 characters)

@refack
refack approved these changes Nov 17, 2018
Copy link
Member

left a comment

LGTM % duplicate line

@refack refack added the fast-track label Nov 17, 2018

@refack

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

Please 👍 for fast-track (nits could be resolved during landing)

@refack

This comment has been minimized.

@Trott

This comment has been minimized.

@refack

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

Hello @manilson and welcome. Thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

P.S. If you have any questions you can also feel free to contact me directly.

P.P.S. If you like you can associate your email address with you GitHub account. That way your contributions will be properly credited to you. See https://help.github.com/articles/setting-your-commit-email-address-on-github/

@refack refack added blocked and removed fast-track labels Nov 19, 2018

@refack

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

blocking to give the OP a chance to set their email address.

@manilson manilson force-pushed the manilson:master branch from bb5dffe to 4cd7be8 Nov 20, 2018

@addaleax addaleax removed the blocked label Nov 20, 2018

@addaleax

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

Landed in 77c2cf9.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 20, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 20, 2018
src: elevate namespaces of repeated artifacts
PR-URL: nodejs#24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos added a commit that referenced this pull request Nov 21, 2018
src: elevate namespaces of repeated artifacts
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
src: elevate namespaces of repeated artifacts
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
src: elevate namespaces of repeated artifacts
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
src: elevate namespaces of repeated artifacts
PR-URL: nodejs#24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
src: elevate namespaces of repeated artifacts
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
src: elevate namespaces of repeated artifacts
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.