Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Using arrow functions #24436

Closed

Conversation

@NoSkillGirl
Copy link
Contributor

commented Nov 17, 2018

Using arrow functions in test-tls-client-resume.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@targos
Copy link
Member

left a comment

Commit message should look like test: use arrow functions

const server = tls.Server(options, common.mustCall(function(socket) {
socket.end('Goodbye');
}, 2));
const server = tls.Server(options, common.mustCall( socket => socket.end('Goodbye'), 2));

This comment has been minimized.

Copy link
@targos

targos Nov 17, 2018

Member
Suggested change
const server = tls.Server(options, common.mustCall( socket => socket.end('Goodbye'), 2));
const server = tls.Server(options, common.mustCall(socket => socket.end('Goodbye'), 2));

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 0ee9e42 to 75cf1d4 Nov 20, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 20, 2018
test: Using arrow functions
 - Using arrow functions in test-tls-client-resume.js

 PR URL: nodejs#24436

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 75cf1d4 to 362b69d Nov 21, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 21, 2018
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js

    PR-URL: nodejs#24436

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 0d6b3c8 to 272d172 Nov 21, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 21, 2018
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Error thrown in Travis - 41:52  error  Expected parentheses around arrow function argument  arrow-parens, This got fixed

    PR-URL: nodejs#24436

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 272d172 to e12f560 Nov 21, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 21, 2018
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Error thrown in Travis - 41:52  error  Expected parentheses around arrow function argument  arrow-parens, This got fixed

    PR-URL: nodejs#24436
@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from e12f560 to 0dbe2f8 Nov 21, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 21, 2018
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function argument arrow-parens

    PR-URL: nodejs#24436
@NoSkillGirl

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2018

Pong @gireeshpunathil

test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

    PR-URL: #24436

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 0dbe2f8 to d91a981 Nov 21, 2018

@danbev

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

@danbev

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Landed in 282e533. 🎉

@danbev danbev closed this Nov 22, 2018

danbev added a commit that referenced this pull request Nov 22, 2018
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@NoSkillGirl

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

Thank You @danbev

targos added a commit that referenced this pull request Nov 24, 2018
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: nodejs#24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: using arrow functions
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.