Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,meta: update PR approving info #24561

Closed
wants to merge 1 commit into from
Closed

doc,meta: update PR approving info #24561

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Refs: #22255

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 21, 2018
@nodejs-github-bot
Copy link
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1672/pipeline

@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Nov 21, 2018
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 22, 2018
@Trott
Copy link
Member

Trott commented Nov 22, 2018

Landed in 9c7b87b

@Trott Trott closed this Nov 22, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 22, 2018
@vsemozhetbyt @Trott
doc,meta: update PR approving info
9c7b87b 
Refs: nodejs#22255

PR-URL: nodejs#24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@vsemozhetbyt vsemozhetbyt deleted the doc-contrib-guide-2-approvals branch November 22, 2018 05:29
targos pushed a commit that referenced this pull request Nov 24, 2018
@vsemozhetbyt @targos
doc,meta: update PR approving info
b46596f 
Refs: #22255

PR-URL: #24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@vsemozhetbyt @rvagg
doc,meta: update PR approving info
2245e5e 
Refs: #22255

PR-URL: #24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@vsemozhetbyt @codebytere
doc,meta: update PR approving info
b4494ee 
Refs: #22255

PR-URL: #24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@vsemozhetbyt @refack
doc,meta: update PR approving info
fff4f20 
Refs: nodejs#22255

PR-URL: nodejs#24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@vsemozhetbyt @codebytere
doc,meta: update PR approving info
e2b10ff 
Refs: #22255

PR-URL: #24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@vsemozhetbyt @codebytere
doc,meta: update PR approving info
b827db0 
Refs: #22255

PR-URL: #24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vsemozhetbyt @nodejs-github-bot @Trott @apapirovski