Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Convert to Arrow Function #24615

Closed
wants to merge 1 commit into from
Closed

lib: Convert to Arrow Function #24615

wants to merge 1 commit into from

Conversation

darai0512
Copy link
Contributor

@darai0512 darai0512 commented Nov 24, 2018 •
edited
Loading

Converts to Arrow Function and tests it by ./tools/test.py tick-processor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

lib: Convert to Arrow Function
8423ef3 
Converts to Arrow Function and tests by `./tools/test.py tick-processor`
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 24, 2018
@hiroppy hiroppy removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 24, 2018
@hiroppy hiroppy added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18937

@shisama
Copy link
Contributor

shisama commented Nov 28, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18975/

@gireeshpunathil
Copy link
Member

landed as b02cac5

gireeshpunathil pushed a commit that referenced this pull request Nov 28, 2018
@gireeshpunathil
lib: convert to Arrow Function
b02cac5 
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: #24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
targos pushed a commit that referenced this pull request Nov 28, 2018
@targos
lib: convert to Arrow Function
e5c85ef 
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: #24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
lib: convert to Arrow Function
6e25344 
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: nodejs#24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
lib: convert to Arrow Function
e5abfe1 
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: #24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
lib: convert to Arrow Function
db2358e 
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: #24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@shisama shisama shisama approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@darai0512 @gireeshpunathil @shisama @addaleax @lpinca @cjihrig @joyeecheung @hiroppy @BethGriggs @nodejs-github-bot