Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
buffer: fix crash for invalid index types #25154
As part of the discussion back then, we wanted to explore a “fix” for v11.x and master that involved introducing typechecking along the lines of #23840, but since that hasn’t happened, it seems like a good idea to apply this on all affected branches, in order to make sure the bug is fixed everywhere.
This does not keep #23840 from happening in any way (except that this makes it a semver-major PR).
2555cb4 introduced a crash
We do not always have JS typechecking for that in place, though.
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19876/ (green)