Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: port encoding WPT into core #25321

Closed
wants to merge 4 commits into from

Conversation

@joyeecheung
Copy link
Member

commented Jan 3, 2019

Note: the test runner does not yet support scanning and running tests under subdirectories, but in the case of encoding it's fine because the subdirectory stream contains tests for Text*CoderStream that we do not support yet.

There are still some tests failing, I've marked them in the test/wpt/status/encoding.json and opened #25315 to track one of the failures.

The first commit, and the biggest one, is generated with git node wpt.

test: pull enconding WPT test fixtures

test: support more icu requirements in the WPT status file

Support small-icu and full-icu requirements, where full-icu
implies small-icu.

test: use WPT runner to run encoding tests

test: remove duplicate encoding tests in favor of WPT

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
joyeecheung added 4 commits Dec 4, 2018
test: support more icu requirements in the WPT status file
Support `small-icu` and `full-icu` requirements, where `full-icu`
implies `small-icu`.
@joyeecheung

This comment has been minimized.

@joyeecheung joyeecheung requested a review from jasnell Jan 3, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

@Trott
Trott approved these changes Jan 9, 2019
Copy link
Member

left a comment

RSLGTM if CI is green

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

@jasnell
jasnell approved these changes Jan 9, 2019
@jasnell
jasnell approved these changes Jan 9, 2019
@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

Landed in 2d2f82c...dce2f3e

joyeecheung added a commit that referenced this pull request Jan 10, 2019
test: pull enconding WPT test fixtures
PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
joyeecheung added a commit that referenced this pull request Jan 10, 2019
test: support more icu requirements in the WPT status file
Support `small-icu` and `full-icu` requirements, where `full-icu`
implies `small-icu`.

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
joyeecheung added a commit that referenced this pull request Jan 10, 2019
test: use WPT runner to run encoding tests
PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
joyeecheung added a commit that referenced this pull request Jan 10, 2019
test: remove duplicate encoding tests in favor of WPT
PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request Jan 14, 2019
test: pull enconding WPT test fixtures
PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request Jan 14, 2019
test: support more icu requirements in the WPT status file
Support `small-icu` and `full-icu` requirements, where `full-icu`
implies `small-icu`.

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request Jan 14, 2019
test: use WPT runner to run encoding tests
PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request Jan 14, 2019
test: remove duplicate encoding tests in favor of WPT
PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: pull enconding WPT test fixtures
PR-URL: nodejs#25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: support more icu requirements in the WPT status file
Support `small-icu` and `full-icu` requirements, where `full-icu`
implies `small-icu`.

PR-URL: nodejs#25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: use WPT runner to run encoding tests
PR-URL: nodejs#25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: remove duplicate encoding tests in favor of WPT
PR-URL: nodejs#25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.