Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,worker_threads: refactor test-worker-cleanup-handles #25401

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 8, 2019

  • alphabetize require() statements for built-in modules by module name
  • remove unused function argument code in callback
  • replace common.expectsError() with assert.throws()
  • remove unneeded line-wrap
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test,worker_threads: refactor test-worker-cleanup-handles
* alphabetize require() statements for built-in modules by module name
* remove unused function argument `code` in callback
* replace common.expectsError() with assert.throws()
* remove unneeded line-wrap
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2019

@Trott Trott added the author ready label Jan 8, 2019

@jasnell
jasnell approved these changes Jan 9, 2019
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

Landed in 906db44

@Trott Trott closed this Jan 11, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 11, 2019
test,worker: refactor test-worker-cleanup-handles
* alphabetize require() statements for built-in modules by module name
* remove unused function argument `code` in callback
* replace common.expectsError() with assert.throws()
* remove unneeded line-wrap

PR-URL: nodejs#25401
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
test,worker: refactor test-worker-cleanup-handles
* alphabetize require() statements for built-in modules by module name
* remove unused function argument `code` in callback
* replace common.expectsError() with assert.throws()
* remove unneeded line-wrap

PR-URL: #25401
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test,worker: refactor test-worker-cleanup-handles
* alphabetize require() statements for built-in modules by module name
* remove unused function argument `code` in callback
* replace common.expectsError() with assert.throws()
* remove unneeded line-wrap

PR-URL: nodejs#25401
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.