Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove outdated `Neuter()` call in `node_buffer.cc` #25479

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Jan 13, 2019

This call was introduced in 827ee49 to avoid a crash in a
later Neuter() call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: remove outdated `Neuter()` call in `node_buffer.cc`
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Jan 13, 2019

@addaleax sadly an error occured when I tried to trigger a build :(

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 21, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 21, 2019

Landed in 30f4568

@addaleax addaleax closed this Jan 21, 2019

@addaleax addaleax deleted the addaleax:no-neuter branch Jan 21, 2019

addaleax added a commit that referenced this pull request Jan 21, 2019
src: remove outdated `Neuter()` call in `node_buffer.cc`
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos added a commit that referenced this pull request Jan 24, 2019
src: remove outdated `Neuter()` call in `node_buffer.cc`
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 29, 2019
src: remove outdated `Neuter()` call in `node_buffer.cc`
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
src: remove outdated `Neuter()` call in `node_buffer.cc`
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
src: remove outdated `Neuter()` call in `node_buffer.cc`
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
deepak1556 added a commit to electron/node that referenced this pull request Jul 10, 2019
src: remove outdated `Neuter()` call in `node_buffer.cc`
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: nodejs/node#3624
Refs: nodejs/node#5204

PR-URL: nodejs/node#25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.