-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: fix call process.reallyExit, vs., binding #25655
Conversation
all thanks goes to @addaleax for this patch. |
👍 for fix and test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion
Should we fast track this to get the fix for 11.7.0 out asap? |
Some user-land modules, e.g., nyc, mocha, currently rely on patching process.reallyExit.
@MylesBorins looks like folks are okay with fast-track, I will land this as soon as the smoke test finishes with @joyeecheung's copy edits. |
Some user-land modules, e.g., nyc, mocha, currently rely on patching process.reallyExit. PR-URL: nodejs#25655 Fixes: nodejs#25650 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in a6286e6 |
@MylesBorins landed \o/ need to run to coffee, perhaps someone else can cherry-pick it to 11.7? |
Some user-land modules, e.g., nyc, mocha, currently rely on patching process.reallyExit. PR-URL: #25655 Fixes: #25650 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Some user-land modules, e.g., nyc, mocha, currently rely on patching
process.reallyExit.
Node@11.7.0 breaks the interaction between nyc and mocha; ultimately it appears as though the problem is that nyc relies on overriding
process.reallyExit
to output coverage to disk, which was replaced withbinding.reallyExit
(dde7152).fixes: #25650
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes