Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: throw for duplicates in transfer list #25815

Closed
wants to merge 1 commit into from
Closed

worker: throw for duplicates in transfer list #25815

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Throw a DataCloneError exception when encountering duplicate
ArrayBuffers or MessagePorts in the transfer list.

Fixes: #25786

(Fyi @chjj)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
worker: throw for duplicates in transfer list
8c9ede1 
Throw a `DataCloneError` exception when encountering duplicate
`ArrayBuffer`s or `MessagePort`s in the transfer list.

Fixes: nodejs#25786
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 30, 2019
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2447/pipeline

@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20440/

@addaleax addaleax added the worker Issues and PRs related to Worker support. label Jan 30, 2019
@addaleax addaleax mentioned this pull request Jan 30, 2019
Closed
@addaleax
Copy link
Member Author

addaleax commented Jan 30, 2019 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20448/ (:heavy_check_mark:)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 1, 2019

Landed in 0ff0af5

@addaleax addaleax closed this Feb 1, 2019
@addaleax addaleax deleted the message-duplicate-transfers branch February 1, 2019 15:12
addaleax added a commit that referenced this pull request Feb 1, 2019
@addaleax
worker: throw for duplicates in transfer list
0ff0af5 
Throw a `DataCloneError` exception when encountering duplicate
`ArrayBuffer`s or `MessagePort`s in the transfer list.

Fixes: #25786

PR-URL: #25815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Feb 1, 2019
@addaleax
worker: throw for duplicates in transfer list
55c2702 
Throw a `DataCloneError` exception when encountering duplicate
`ArrayBuffer`s or `MessagePort`s in the transfer list.

Fixes: #25786

PR-URL: #25815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

worker_threads: multiple crashes caused by duplicate objects in transferList
6 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @joyeecheung @richardlau