Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix code lang in repl.md #26075

Closed
wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

commented Feb 13, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
doc/api/repl.md Outdated Show resolved Hide resolved
@richardlau

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

There are other instances in this file of the repl being started from the command line (node ...) and they're currently using js. Either all of them should be changed for consistency or the instance being changed here left alone.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

It seems they were marked as js so that code and outputted literals are js-highlighted.

@gengjiawen gengjiawen force-pushed the gengjiawen:fix-repl-doc branch from 7420d6f to 5ae3347 Feb 14, 2019

@gengjiawen

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

It's not js actually. So better to change it.

@gengjiawen gengjiawen force-pushed the gengjiawen:fix-repl-doc branch from 5ae3347 to cc67a4c Feb 14, 2019

@lance
Copy link
Contributor

left a comment

I don't understand how changing the code sections to bash is an improvement. It's not pure JavaScript since it's in the REPL, but it seems closer to JS than to bash, in my opinion. If we're going to be strict about it, I would say that in most code examples on this file, there should be no language specified.

@gengjiawen gengjiawen force-pushed the gengjiawen:fix-repl-doc branch from cc67a4c to 84ded87 Feb 14, 2019

@gengjiawen

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

Refactor it to console, inspired by https://stackoverflow.com/a/49004070/1713757.

@gengjiawen gengjiawen force-pushed the gengjiawen:fix-repl-doc branch from 84ded87 to 99fc860 Feb 14, 2019

@lance
lance approved these changes Feb 14, 2019
@danbev
danbev approved these changes Feb 19, 2019
@danbev

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

Landed in a993160.

@danbev danbev closed this Feb 19, 2019

danbev added a commit that referenced this pull request Feb 19, 2019
doc: fix code lang in repl.md
PR-URL: #26075
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax added a commit that referenced this pull request Feb 19, 2019
doc: fix code lang in repl.md
PR-URL: #26075
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR referenced this pull request Feb 26, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
doc: fix code lang in repl.md
PR-URL: #26075
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.