Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: simplify InspectorConsoleCall #26168

Closed

Conversation

Projects
None yet
6 participants
@addaleax
Copy link
Member

commented Feb 17, 2019

Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.

(Based on @joyeecheung’s suggestion in #26113)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: simplify InspectorConsoleCall
Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2019

Landed in a34a84d

@addaleax addaleax closed this Feb 20, 2019

@addaleax addaleax deleted the addaleax:simplify-InspectorConsoleCall branch Feb 20, 2019

addaleax added a commit that referenced this pull request Feb 20, 2019

src: simplify InspectorConsoleCall
Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.

PR-URL: #26168
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>

addaleax added a commit that referenced this pull request Feb 21, 2019

src: simplify InspectorConsoleCall
Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.

PR-URL: #26168
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>

@BridgeAR BridgeAR referenced this pull request Feb 26, 2019

Merged

v11.11.0 proposal #26322

rvagg added a commit that referenced this pull request Feb 28, 2019

src: simplify InspectorConsoleCall
Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.

PR-URL: #26168
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.