Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 6.8.0 #26208

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 6.8.0 #26208

wants to merge 1 commit into from

Conversation

aeschright
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Where this should land
  • Node 11
  • Node 10
  • Node 8
Notable Changes

The npm@6.8.0 release includes an implementation of RFC #10, documenting an optional field that can be used to specify the directory path for a package within a monorepo.

Changelog

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Feb 19, 2019
Trott
Trott approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

BridgeAR
BridgeAR approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@MylesBorins
Copy link
Contributor

6.8.0 was published 8 days ago, as such we can land this in 6 days on Wed the 27th

@zkat zkat mentioned this pull request Feb 21, 2019
Closed
4 tasks
@MylesBorins
Copy link
Contributor

So today is the 27th, but I'm seeing

https://npm.community/t/npm-pack-leaving-out-files-6-8-0-only/5382

is this something to be concerned about?

/cc @zkat @iarna

@MylesBorins
Copy link
Contributor

ping @zkat

@bricss
Copy link

bricss commented Mar 8, 2019

Seems like npm 6.9.0 is here. It will better to close this one in favor of #26244, which is needs slight update.

/cc @zkat

@tristanls
Copy link
Contributor

https://npm.community/t/npm-list-version-6-7-0-fails-to-list-dependencies-from-linked-modules/6373

@MylesBorins
Copy link
Contributor

Closing in lieu of #26244

@MylesBorins MylesBorins closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aeschright @MylesBorins @bricss @tristanls @Trott @BridgeAR @nodejs-github-bot