Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: reduce usage of require('util') #26783

Closed
wants to merge 1 commit into from
Closed

fs: reduce usage of require('util') #26783

wants to merge 1 commit into from

Conversation

toshi1127
Copy link
Contributor

Remove the usage of public require('util'), as described in issue:
#26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Mar 19, 2019
@toshi1127 toshi1127 mentioned this pull request Mar 20, 2019
Closed
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21773/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR
Copy link
Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21790/

@ZYSzys
Copy link
Member

ZYSzys commented Mar 24, 2019

@toshi1127 hi, there are some conflicts so we need to rebase this.

@toshi1127
Copy link
Contributor Author

@ZYSzys
I resolved the conflict !!
Please confirm.

@BridgeAR
Copy link
Member

@toshi1127 thanks a lot for following up on the comment! It seems like you used the merge command while we require the plain commits without any merge commits to run our CI. Would you please run git rebase -i upstream/master and git push --force-with-lease afterwards? That removes the merge commit and resolved all conflicts as well.

@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2019
@toshi1127
Copy link
Contributor Author

@BridgeAR
@ZYSzys
I resolved the conflict by running git rebase -i upstream / master and git push --force-with-lease.
Please confirm.

@ZYSzys
Copy link
Member

ZYSzys commented Mar 25, 2019

new CI: https://ci.nodejs.org/job/node-test-pull-request/21859/

@ZYSzys ZYSzys changed the title lib: reduce usage of require('util') fs: reduce usage of require('util') Mar 25, 2019
@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 26, 2019

Landed in 51256e5 🎉🎉

@ZYSzys ZYSzys closed this Mar 26, 2019
dnalborczyk pushed a commit to dnalborczyk/node that referenced this pull request Mar 26, 2019
@toshi1127 @ZYSzys
fs: reduce usage of require('util')
51256e5 
PR-URL: nodejs#26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs pushed a commit that referenced this pull request Mar 26, 2019
@toshi1127 @BethGriggs
fs: reduce usage of require('util')
5d4c0db 
PR-URL: #26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 28, 2019
@toshi1127 @targos
fs: reduce usage of require('util')
07af0f0 
PR-URL: #26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 29, 2019
@toshi1127 @targos
fs: reduce usage of require('util')
0da5b7c 
PR-URL: #26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@toshi1127 @targos
fs: reduce usage of require('util')
bb9f1cc 
PR-URL: #26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toshi1127 @BridgeAR @ZYSzys @jasnell @nodejs-github-bot