Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: use const to define constants #2707

Closed
wants to merge 28 commits into from
Closed

timers: use const to define constants #2707

wants to merge 28 commits into from

Conversation

JungMinu
Copy link
Member

@JungMinu JungMinu commented Sep 5, 2015

len and length var in timers.js are constants.
Therefore, this commit replaces length,len var statements with const statements

skomski and others added 28 commits September 2, 2015 18:39
@skomski @trevnorris
src: fix memory leak in ExternString
617ee32 
v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: #1374
PR-URL: #2402
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis @trevnorris
child_process: add callback parameter to .send()
56d9584 
Add an optional callback parameter to `ChildProcess.prototype.send()`
that is invoked when the message has been sent.

Juggle the control channel's reference count so that in-flight messages
keep the event loop (and therefore the process) alive until they have
been sent.

`ChildProcess.prototype.send()` and `process.send()` used to operate
synchronously but became asynchronous in commit libuv/libuv@393c1c5
("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which landed
in io.js in commit 07bd05b ("deps: update libuv to 1.2.1").

Fixes: #760
PR-URL: #2620
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
@orangemocha
test: mark eval_messages as flaky
abbc8db 
This test has failed recently during a PR test in Jenkins, for
reasons seemingly not related to the change in the PR.

PR-URL: #2648
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
@jbergstroem
doc: reorder collaborators by their usernames
6ce8f5f 
Fixes: #1972
PR-URL: #2322
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Fishrock123
doc: update url doc to account for escaping
47e5cf7 
Fixes: #2113
Ref: 17a379e
PR-URL: #2605
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: mscdex - Brian White <mscdex@mscdex.net>
@Trott
test: refactor to eliminate flaky test
8ca9ea2 
This retains the key elements of test-child-process-fork-getconnections
(forks a child process, sends a bunch of sockets, uses getConnections()
to enumerate them) but contains some code to work around an apparent
intermittent bug that occurs on OS X where a socket seems to close
itself unexpectedly.

#2610 was opened for the bug that
was causing the problem in the first place.

PR-URL: #2609
Fixes: #1100
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
@jasnell
child_process: check execFile and fork args
107cbd6 
Port of joyent/node commits:

 * nodejs/node-v0.x-archive@e17c5a7
 * nodejs/node-v0.x-archive@70dafa7

Pull over test-child-process-spawn-typeerror.js from v0.12, replacing
the existing test in master. The new test includes a broader set of
tests on the various arg choices and throws.

Reviewed-By: trevnorris - Trevor Norris <trevnorris@nodejs.org>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani
PR-URL: #2667
Fixes: #2515
@skomski @indutny
build: add --enable-asan with builtin leakcheck
4a1b519 
PR-URL: #2376
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Fishrock123
events,lib: don't require EE#listenerCount()
b513a33 
Now parts of our public and public-ish APIs fall back to old-style
listenerCount() if the emitter does not have a listenerCount function.

Fixes: #2655
Refs: 8f58fb9

PR-URL: #2661
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ofrobots
deps: upgrade V8 to 4.5.103.24
1134188 
Upgrade to the latest branch-head for V8 4.5. For the full commit log see
https://github.com/v8/v8-git-mirror/commits/4.5.103.24

PR-URL: #2509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@ofrobots
src: apply debug force load fixups from 41e63fb
a7392ff 
Apply the src/node_contextify.cc and lib/module.js fixups from @bnoordhuis
41e63fb

PR-URL: #2509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@indutny @ofrobots
contextify: ignore getters during initialization
709ed15 
The `context_` is not initialized until the `CreateV8Context` will
return. Make sure that it will be empty (by moving away initialization
from constructor) at start, and ignore getter callbacks until it will
have some value.

PR-URL: #2091
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@ofrobots
test: fix test-repl-tab-complete.js for V8 4.5
06f38de 
The list of Array properties needed to be updated to match the new ones added
in V8 4.5.

PR-URL: #2509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis @ofrobots
src: enable v8 deprecation warnings and fix them
39aa573 
Turn on V8 API deprecation warnings.  Fix up the no-arg Isolate::New()
calls in src/node.cc and src/debug-agent.cc.

PR-URL: #2091
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@targos @ofrobots
src: replace usage of v8::Handle with v8::Local
d08bb97 
v8::Handle is deprecated: https://codereview.chromium.org/1224623004

PR-URL: #2202
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@ofrobots
src: enable vector ics on arm again
564e214 
The flag is no longer supported by V8 4.5, and the original issue [1] on ARMv6
no longer manifests with (at least) 4.5.103.20.

[1] See https://code.google.com/p/v8/issues/detail?id=4338

PR-URL: #2509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos @ofrobots
src: re-enable fast math on arm
074315f 
Ref: #1376
Ref: #1398
Issue fixed in V8: https://chromium.googlesource.com/v8/v8/+/81703350bbb9923d211fe5b79e90bd458b0916e2
V8-Bug: https://code.google.com/p/v8/issues/detail?id=4019

PR-URL: #2592
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@ofrobots
deps: upgrade V8 to 4.5.103.30
64beab0 
Pick up v8/v8@f9a0a16
Commit log at https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5

PR-URL: #2632
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
@rvagg
test: fix use of common before required
fc66eed 
PR-URL: #2685
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@targos
buffer: SlowBuffer only accept valid numeric values
eefe14c 
Fixes a regression that appeared with the new Buffer implementation in v3.
Without this change, calling the SlowBuffer constructor with something else
than a number would abort on the C++ side. This makes sure that the length
argument is coerced to number or is 0.

Fixes: #2634
PR-URL: #2635
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
@thefourtheye @silverwind
doc,test: enable recursive file watching in Windows
a338eb3 
Recursive file watching is supported by libuv since 1.7.0. Refer
https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126. This
patch notes that in the docs and enables testing this feature. It also
adds proper TAP plugin parsable message for other platforms.

PR-URL: #2649
Fixes: #375
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: silverwind - Roman Reiss <me@silverwind.io>
@skomski @trevnorris
src: fix buffer overflow for long exception lines
80bcab9 
Long exception lines resulted in a stack buffer overflow or assertion
because it was assumed snprintf not counts discarded chars
or the assertion itself was incorrect: `(off) >= sizeof(arrow)`

PR-URL: #2404
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@skomski @trevnorris
src: use standard conform snprintf on windows
3a731da 
The version used before returned -1 on truncation which does not conform
to the standard.

PR-URL: #2404
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@silverwind
doc: update environment vars in manpage and --help
a6cb3a5 
- Added NODE_REPL_HISTORY to the environment variables in the --help
  and made all descriptions start with lower case for consistency.

- Added NODE_REPL_HISTORY and NODE_ICU_DATA to the man page.

PR-URL: #2690
Reviewed-By: fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
@rvagg
doc: add TSC meeting minutes 2015-09-02
880410d 
PR-URL: #2674
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@rvagg
build: fix .pkg creation tooling
63a628d 
PR-URL: #2687
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@ofrobots
deps: backport 75e43a6 from v8 upstream (again)
d0c682a 
Note: When this was cherry-picked for v8 v4.4 (landed in #2636),
test-heap.cc:1989 chunk did not exist. It now exists in
v8 v4.5.103.30. This PR completes the cherry pick of the whole commit
from v8.

PR-URL: #2692
Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>

Original commit message:
  Use static_cast<> for NULL (clang 3.7)

  The following errors come up when compiling v8
   with clang 3.7 on FreeBSD/amd64:

  src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from
  'nullptr_t' to 'v8::internal::Smi *' is not allowed
    local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL));
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

  test/cctest/test-heap.cc:131:20: error: reinterpret_cast from
        'nullptr_t' to 'v8::internal::Object *' is not allowed
    Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate);
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from
        'nullptr_t' to 'Address' (aka 'unsigned char *') is not
        allowed
    Address base = reinterpret_cast<Address>(NULL);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  +add myself to the AUTHORS file.

  BUG=

  Review URL: https://codereview.chromium.org/1277353002

  Cr-Commit-Position: refs/heads/master@{#30103}
@JungMinu
timers: use const to define constants
af8fd4e 
len and length var in timers.js are constants.
Therefore, this commit replaces length,len var statements with const statements
@ChALkeR ChALkeR added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Sep 5, 2015
@silverwind silverwind mentioned this pull request Sep 6, 2015
Closed
@Fishrock123
Copy link
Member

@JungMinu Sorry, but by (possibly unstated) policy, we avoid style changes in the code or code comments. This is to keep some git tools more clear, such as git blame or git bisect.

Given that this doesn't actually effect the functionality (and usually neither does ==, as used in node core), it qualifies as style changes. :/

We will encourage updating these things if the code lines they are change for functional purposes, though. :)

@Fishrock123 Fishrock123 closed this Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet