src: fix memory leak in ExternString #2402

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
@skomski
Contributor

skomski commented Aug 16, 2015

v8 will silently return an empty handle
which doesn't delete node's allocated data if string length is
above String::kMaxLength.

==3556==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x717a0b in operator new(unsigned long) /home/skomski/Code/llvm-related/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62:35
    #1 0x1a7d88e in node::ExternString<v8::String::ExternalOneByteStringResource, char>::New(v8::Isolate*, char const*, unsigned long) /home/skomski/Code/io.js/out/../src/string_bytes.cc:72:29
    #2 0x1a7d030 in node::StringBytes::Encode(v8::Isolate*, char const*, unsigned long, node::encoding) /home/skomski/Code/io.js/out/../src/string_bytes.cc:720:17
    #3 0x1a269c1 in void node::Buffer::StringSlice<(node::encoding)0>(v8::FunctionCallbackInfo<v8::Value> const&) /home/skomski/Code/io.js/out/../src/node_buffer.cc:495:7

Indirect leak of 268435441 byte(s) in 1 object(s) allocated from:
    #0 0x717b7b in operator new[](unsigned long) /home/skomski/Code/llvm-related/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:64:37
    #1 0x1a7b2a5 in node::StringBytes::Encode(v8::Isolate*, char const*, unsigned long, node::encoding) /home/skomski/Code/io.js/out/../src/string_bytes.cc:714:21
    #2 0x1a269c1 in void node::Buffer::StringSlice<(node::encoding)0>(v8::FunctionCallbackInfo<v8::Value> const&) /home/skomski/Code/io.js/out/../src/node_buffer.cc:495:7

SUMMARY: AddressSanitizer: 268435473 byte(s) leaked in 2 allocation(s).

v8 related commit: https://chromium.googlesource.com/v8/v8/+/85a0e8075f433fe92c9a4f2df3c86d14000580d9
Before v8 simply crashed: #1374

@mscdex mscdex added the C++ label Aug 16, 2015

@ChALkeR ChALkeR added the memory label Aug 17, 2015

@bnoordhuis

View changes

src/string_bytes.cc
@@ -49,6 +49,10 @@ class ExternString: public ResourceType {
size_t length) {
EscapableHandleScope scope(isolate);
+ if (length > String::kMaxLength) {
+ return Local<String>();
+ }

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 18, 2015

Member

I don't think this is quite the proper fix. It'd be better to try and create the string but release the memory when V8 returns an empty handle.

@bnoordhuis

bnoordhuis Aug 18, 2015

Member

I don't think this is quite the proper fix. It'd be better to try and create the string but release the memory when V8 returns an empty handle.

@bnoordhuis

View changes

src/string_bytes.cc
@@ -700,6 +708,11 @@ Local<Value> StringBytes::Encode(Isolate* isolate,
if (!buflen && encoding != BUFFER)
return scope.Escape(String::Empty(isolate));
+ if (buflen > String::kMaxLength && encoding != BUFFER) {
+ ThrowRangeError(isolate, "invalid String length");

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 18, 2015

Member

Throwing a JS exception from here feels like too much side effect, that should only be done at the edges of the JS/C++ bridge.

@bnoordhuis

bnoordhuis Aug 18, 2015

Member

Throwing a JS exception from here feels like too much side effect, that should only be done at the edges of the JS/C++ bridge.

@bnoordhuis

View changes

test/parallel/test-stringbytes-external.js
+// v8 fails silently if string length > v8::String::kMaxLength
+(function() {
+ var kStringMaxLength = (1 << 28) - 16;
+ var max_buf = new Buffer(kStringMaxLength).toString('binary');

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 18, 2015

Member

Style: maxBuf.

@bnoordhuis

bnoordhuis Aug 18, 2015

Member

Style: maxBuf.

@bnoordhuis

View changes

test/parallel/test-stringbytes-external.js
+
+// v8 fails silently if string length > v8::String::kMaxLength
+(function() {
+ var kStringMaxLength = (1 << 28) - 16;

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 18, 2015

Member

Can you add a comment explaining this mirrors v8::String::kMaxLength from v8.h?

@bnoordhuis

bnoordhuis Aug 18, 2015

Member

Can you add a comment explaining this mirrors v8::String::kMaxLength from v8.h?

@skomski

This comment has been minimized.

Show comment
Hide comment
@skomski

skomski Aug 19, 2015

Contributor

Updated.

Contributor

skomski commented Aug 19, 2015

Updated.

+ if (str.IsEmpty()) {
+ delete h_str;
+ return Local<String>();
+ }

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

Shouldn't NewFromCopy() have the same check?

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

Shouldn't NewFromCopy() have the same check?

This comment has been minimized.

@skomski

skomski Aug 19, 2015

Contributor

NewFromCopy uses New

@skomski

skomski Aug 19, 2015

Contributor

NewFromCopy uses New

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

Yes, but it leaks new_data on error now, doesn't it?

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

Yes, but it leaks new_data on error now, doesn't it?

This comment has been minimized.

@skomski

skomski Aug 19, 2015

Contributor

Why? new_data is used as data in new ExternString

@skomski

skomski Aug 19, 2015

Contributor

Why? new_data is used as data in new ExternString

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

Because it's the copy of the data? Maybe I'm misunderstanding the question.

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

Because it's the copy of the data? Maybe I'm misunderstanding the question.

This comment has been minimized.

@trevnorris

trevnorris Aug 19, 2015

Contributor

Using new TypeName[length] is a bug. If the machine is OOM then you're screwed. Here's an example script:

var a = [];
var f = false;

while (!f) {
  try {
    a.push(new Buffer(1024 * 1024 * 1024).fill('a'));
  } catch (e) {
    f = true;
  }
}

console.log(a[a.length - 1].length);      // 1073741824
console.log(a[a.length - 1].toString());  // undefined

So NewFromCopy() should use malloc(), check if ptr == nullptr and return Local<Object>() if that's the case. This will account for whether kStringMaxLength was exceeded and if ran out of memory while creating the string.

@trevnorris

trevnorris Aug 19, 2015

Contributor

Using new TypeName[length] is a bug. If the machine is OOM then you're screwed. Here's an example script:

var a = [];
var f = false;

while (!f) {
  try {
    a.push(new Buffer(1024 * 1024 * 1024).fill('a'));
  } catch (e) {
    f = true;
  }
}

console.log(a[a.length - 1].length);      // 1073741824
console.log(a[a.length - 1].toString());  // undefined

So NewFromCopy() should use malloc(), check if ptr == nullptr and return Local<Object>() if that's the case. This will account for whether kStringMaxLength was exceeded and if ran out of memory while creating the string.

This comment has been minimized.

@skomski

skomski Aug 19, 2015

Contributor

Your example code does not use NewFromCopy because it uses the fast lane via NewFromUtf8 and then returns undefined because v8 returns an empty handle if length > kStringMaxLength.

Example code with NewFromCopy:

var a = [];
var buffer = new Buffer(200 * 1024 * 1024);
while (true) {
  a.push(buffer.toString('binary'));
}

If new TypeName[length] fails:

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
[1]    2013 abort (core dumped)  ./iojs test
@skomski

skomski Aug 19, 2015

Contributor

Your example code does not use NewFromCopy because it uses the fast lane via NewFromUtf8 and then returns undefined because v8 returns an empty handle if length > kStringMaxLength.

Example code with NewFromCopy:

var a = [];
var buffer = new Buffer(200 * 1024 * 1024);
while (true) {
  a.push(buffer.toString('binary'));
}

If new TypeName[length] fails:

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
[1]    2013 abort (core dumped)  ./iojs test

This comment has been minimized.

@trevnorris

trevnorris Aug 19, 2015

Contributor

@skomski Thanks for the test fix. That's actually what I expected, but I ignored whether the value was intercepted in transit. So my comment about handling this case still stands. Don't want to see aborts on devices that have little memory (e.g. raspberry pi).

@trevnorris

trevnorris Aug 19, 2015

Contributor

@skomski Thanks for the test fix. That's actually what I expected, but I ignored whether the value was intercepted in transit. So my comment about handling this case still stands. Don't want to see aborts on devices that have little memory (e.g. raspberry pi).

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 20, 2015

Member

Complaint withdrawn, I misread the code.

Aside, it's kind of weird that both New() and NewFromCopy() call AdjustAmountOfExternalAllocatedMemory() but depend on the destructor to lower it again. I'd expect the constructor to take care of that, now the logic is duplicated.

@bnoordhuis

bnoordhuis Aug 20, 2015

Member

Complaint withdrawn, I misread the code.

Aside, it's kind of weird that both New() and NewFromCopy() call AdjustAmountOfExternalAllocatedMemory() but depend on the destructor to lower it again. I'd expect the constructor to take care of that, now the logic is duplicated.

This comment has been minimized.

@skomski

skomski Aug 20, 2015

Contributor

Only New calls AdjustAmountOfExternalAllocatedMemory and I think it's not called in the constructor of ExternString because it makes only sense after String::NewExternal.

It would make sense to only call AdjustAmountOfExternalAllocatedMemory after the returned Handle is not empty but since it is not the norm I guess it doesn't matter.

@skomski

skomski Aug 20, 2015

Contributor

Only New calls AdjustAmountOfExternalAllocatedMemory and I think it's not called in the constructor of ExternString because it makes only sense after String::NewExternal.

It would make sense to only call AdjustAmountOfExternalAllocatedMemory after the returned Handle is not empty but since it is not the norm I guess it doesn't matter.

@bnoordhuis

View changes

lib/buffer.js
+ case 'utf16le':
+ case 'utf-16le':
+ if (((end - start) / 2) > kStringMaxLength)
+ throw new RangeError('invalid String length');

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

I'm not sure how I feel about this. I'm inclined to say that it should try to create the string and throw an exception when that fails. @trevnorris WDYT?

Aside: you could write this as if ((end - start) > (kStringMaxLength >>> 1)), V8's optimizing compiler can probably constant-fold that.

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

I'm not sure how I feel about this. I'm inclined to say that it should try to create the string and throw an exception when that fails. @trevnorris WDYT?

Aside: you could write this as if ((end - start) > (kStringMaxLength >>> 1)), V8's optimizing compiler can probably constant-fold that.

This comment has been minimized.

@alexlamsl

alexlamsl Aug 19, 2015

Shouldn't it be if (end - start > kStringMaxLength * 2) or if (end - start > (kStringMaxLength << 1))?

@alexlamsl

alexlamsl Aug 19, 2015

Shouldn't it be if (end - start > kStringMaxLength * 2) or if (end - start > (kStringMaxLength << 1))?

This comment has been minimized.

@trevnorris

trevnorris Aug 19, 2015

Contributor

Agree. Likelihood of this failing is slim, so just places extra logic in the hot path. Use the MaybeLocal<> returned from V8 on the native side to see if it failed or not.

@trevnorris

trevnorris Aug 19, 2015

Contributor

Agree. Likelihood of this failing is slim, so just places extra logic in the hot path. Use the MaybeLocal<> returned from V8 on the native side to see if it failed or not.

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

The division by two is because UCS-2 and UTF-16 are two-byte encodings (i.e. each character is two bytes) and V8's String::kMaxLength is in bytes.

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

The division by two is because UCS-2 and UTF-16 are two-byte encodings (i.e. each character is two bytes) and V8's String::kMaxLength is in bytes.

This comment has been minimized.

@skomski

skomski Aug 20, 2015

Contributor

What should I do if it failed after MaybeLocal? I wanted to throw an exception but bnoordhuis only wants exceptions at the edges of the JS/C++ bridge. (Do you want to catch the context-free exception dcarney wants to implement?) So should I just check for an empty handle in StringSlice and then throw an exception?
I tested checking for undefined in Buffer.prototype.toString but that resulted in 100 ms more in the benchmark although it only adds movq, cmpq, jnz. Maybe returning undefined is enough :)
Edit: I tested again and both benches are jumping around 250~ ms differences. After 40 runs the test with the undefined check on average even performs better. ???

@skomski

skomski Aug 20, 2015

Contributor

What should I do if it failed after MaybeLocal? I wanted to throw an exception but bnoordhuis only wants exceptions at the edges of the JS/C++ bridge. (Do you want to catch the context-free exception dcarney wants to implement?) So should I just check for an empty handle in StringSlice and then throw an exception?
I tested checking for undefined in Buffer.prototype.toString but that resulted in 100 ms more in the benchmark although it only adds movq, cmpq, jnz. Maybe returning undefined is enough :)
Edit: I tested again and both benches are jumping around 250~ ms differences. After 40 runs the test with the undefined check on average even performs better. ???

This comment has been minimized.

@trevnorris

trevnorris Aug 21, 2015

Contributor

I don't have a problem throwing from wherever the check failed. Since the entire operation is sync anyway. @bnoordhuis you have anything against that?

@trevnorris

trevnorris Aug 21, 2015

Contributor

I don't have a problem throwing from wherever the check failed. Since the entire operation is sync anyway. @bnoordhuis you have anything against that?

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

I do, it's a very implicit side effect in what is essentially a library function. Errors should propagate to the caller, who can then deal with it as it sees fit.

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

I do, it's a very implicit side effect in what is essentially a library function. Errors should propagate to the caller, who can then deal with it as it sees fit.

@trevnorris

View changes

lib/buffer.js
@@ -20,6 +20,8 @@ function createPool() {
poolOffset = 0;
}
+// v8::String::kMaxLength defined in v8.h
+const kStringMaxLength = (1 << 28) - 16;

This comment has been minimized.

@trevnorris

trevnorris Aug 19, 2015

Contributor

I'm inclined to expose this via require('buffer').kStringMaxLength. Will make testing easier, and only have a single location to update in case the value changes in the future.

@trevnorris

trevnorris Aug 19, 2015

Contributor

I'm inclined to expose this via require('buffer').kStringMaxLength. Will make testing easier, and only have a single location to update in case the value changes in the future.

This comment has been minimized.

@trevnorris

trevnorris Aug 19, 2015

Contributor

Also set the value from node_buffer.cc using v8::String::kMaxLength. Sort of how Buffer::kMaxLength is now. This way the value is controlled by V8, and we don't have to worry about it.

@trevnorris

trevnorris Aug 19, 2015

Contributor

Also set the value from node_buffer.cc using v8::String::kMaxLength. Sort of how Buffer::kMaxLength is now. This way the value is controlled by V8, and we don't have to worry about it.

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

Can I suggest putting this in lib/internal/buffer.js instead of exposing it to user land?

@skomski You can access it in the test by adding // Flags: --expose-internals at the top, then require('internal/buffer').

@bnoordhuis

bnoordhuis Aug 19, 2015

Member

Can I suggest putting this in lib/internal/buffer.js instead of exposing it to user land?

@skomski You can access it in the test by adding // Flags: --expose-internals at the top, then require('internal/buffer').

This comment has been minimized.

@trevnorris

trevnorris Aug 19, 2015

Contributor

@bnoordhuis How would you suggest getting the value from C++? If not taking the require('buffer').kMaxLength route, then would probably want to use something like binding.setupBufferJS(). Though if placed in internal/buffer then would have to create a separate C++ call to pull that value out.

I'm not opposed to the change. Just slightly more complex than at face value.

@trevnorris

trevnorris Aug 19, 2015

Contributor

@bnoordhuis How would you suggest getting the value from C++? If not taking the require('buffer').kMaxLength route, then would probably want to use something like binding.setupBufferJS(). Though if placed in internal/buffer then would have to create a separate C++ call to pull that value out.

I'm not opposed to the change. Just slightly more complex than at face value.

@trevnorris

View changes

test/parallel/test-stringbytes-external.js
+// v8 fails silently if string length > v8::String::kMaxLength
+(function() {
+ // v8::String::kMaxLength defined in v8.h
+ var kStringMaxLength = (1 << 28) - 16;

This comment has been minimized.

@trevnorris

trevnorris Aug 19, 2015

Contributor

Pull this from require('buffer').kStringMaxLength once included.

@trevnorris

trevnorris Aug 19, 2015

Contributor

Pull this from require('buffer').kStringMaxLength once included.

@bnoordhuis

View changes

lib/buffer.js
+ var result = slowToString.apply(this, arguments);
+ if (result === undefined)
+ throw new Error('toString failed');
+ return result;

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 20, 2015

Member

Can be made a little more compact if you write it like this:

if (arguments.length === 0) {
  var result = this.utf8Slice(0, this.length);
} else {
  var result = slowToString.apply(this, arguments);
}
if (result === undefined)
  throw new Error('toString failed');
return result;

Can you the blank line at the top back in?

@bnoordhuis

bnoordhuis Aug 20, 2015

Member

Can be made a little more compact if you write it like this:

if (arguments.length === 0) {
  var result = this.utf8Slice(0, this.length);
} else {
  var result = slowToString.apply(this, arguments);
}
if (result === undefined)
  throw new Error('toString failed');
return result;

Can you the blank line at the top back in?

@bnoordhuis

View changes

test/parallel/test-stringbytes-external.js
+ assert.equal(maxString.length, kStringMaxLength);
+
+ var maxString = new Buffer(kStringMaxLength + 1).toString(
+ 'binary', 0, kStringMaxLength);

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 20, 2015

Member

Pico-style nit: the convention is to put the new Buffer(... on a new line, indented by four spaces (although the linter probably accepts it as is.)

@bnoordhuis

bnoordhuis Aug 20, 2015

Member

Pico-style nit: the convention is to put the new Buffer(... on a new line, indented by four spaces (although the linter probably accepts it as is.)

@bnoordhuis

View changes

test/parallel/test-stringbytes-external.js
+ assert.throws(function() {
+ var buf = new Buffer(kStringMaxLength + 1).toString('hex');
+ }, Error);
+})();

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 20, 2015

Member

Apropos all the new Buffer(..).toString(...) calls, you should probably put a .fill() in between to stop valgrind from complaining. See ac70bc8.

@bnoordhuis

bnoordhuis Aug 20, 2015

Member

Apropos all the new Buffer(..).toString(...) calls, you should probably put a .fill() in between to stop valgrind from complaining. See ac70bc8.

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Aug 21, 2015

Contributor

@skomski Thanks much for the changes. LGTM

Contributor

trevnorris commented Aug 21, 2015

@skomski Thanks much for the changes. LGTM

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Aug 21, 2015

Contributor

Multiple redeclarations of maxString in test.

Contributor

thefourtheye commented Aug 21, 2015

Multiple redeclarations of maxString in test.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Aug 22, 2015

Member

I think we do that elsewhere in tests as well. Let's see what the CI says: https://jenkins-iojs.nodesource.com/job/node-test-pull-request/128/

PR LGTM FWIW.

Member

bnoordhuis commented Aug 22, 2015

I think we do that elsewhere in tests as well. Let's see what the CI says: https://jenkins-iojs.nodesource.com/job/node-test-pull-request/128/

PR LGTM FWIW.

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Aug 22, 2015

Contributor

Oh, exporting a value via process binding means there's no need for an internal buffer file. Since the former can also be used in tests as well.

@bnoordhuis Leave it as is or remove internal/buffer.js?

Contributor

trevnorris commented Aug 22, 2015

Oh, exporting a value via process binding means there's no need for an internal buffer file. Since the former can also be used in tests as well.

@bnoordhuis Leave it as is or remove internal/buffer.js?

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Aug 22, 2015

Member

The armv7-ubuntu1404 buildbot is unhappy:

not ok 669 - test-stringbytes-external.js
#terminate called after throwing an instance of 'std::bad_alloc'
#  what():  std::bad_alloc

The other failures appear to be flakes.

Leave it as is or remove internal/buffer.js?

@trevnorris I'm fine with leaving it as is.

Member

bnoordhuis commented Aug 22, 2015

The armv7-ubuntu1404 buildbot is unhappy:

not ok 669 - test-stringbytes-external.js
#terminate called after throwing an instance of 'std::bad_alloc'
#  what():  std::bad_alloc

The other failures appear to be flakes.

Leave it as is or remove internal/buffer.js?

@trevnorris I'm fine with leaving it as is.

@bnoordhuis

View changes

lib/buffer.js
- return this.utf8Slice(0, length);
- return slowToString.apply(this, arguments);
+ if (arguments.length === 0) {
+ var result = this.utf8Slice(0, length);

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

Seeing how this is the only branch that uses length, you might as well fold it into the call, i.e. return utf8Slice(0, this.length).

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

Seeing how this is the only branch that uses length, you might as well fold it into the call, i.e. return utf8Slice(0, this.length).

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Aug 22, 2015

Contributor

@bnoordhuis The std::bad_alloc is something I recently have been thinking needs to be addressed for devices with low memory. I think we need to fail more gracefully when an allocation fails. In this case we should be catching and returning an undefined string. This is similar to what happens when a string allocation attempt is made larger than String::kMaxValue.

Contributor

trevnorris commented Aug 22, 2015

@bnoordhuis The std::bad_alloc is something I recently have been thinking needs to be addressed for devices with low memory. I think we need to fail more gracefully when an allocation fails. In this case we should be catching and returning an undefined string. This is similar to what happens when a string allocation attempt is made larger than String::kMaxValue.

@skomski

This comment has been minimized.

Show comment
Hide comment
@skomski

skomski Aug 22, 2015

Contributor

Updated to avoid std::bad_alloc in NewFromCopy and skip non-throwing tests on memory confined environments because you can't distinguish between toString error causes

Contributor

skomski commented Aug 22, 2015

Updated to avoid std::bad_alloc in NewFromCopy and skip non-throwing tests on memory confined environments because you can't distinguish between toString error causes

@bnoordhuis

View changes

src/string_bytes.cc
@@ -52,7 +53,11 @@ class ExternString: public ResourceType {
if (length == 0)
return scope.Escape(String::Empty(isolate));
- TypeName* new_data = new TypeName[length];
+ TypeName* new_data =
+ static_cast<TypeName*>(malloc(length * sizeof(TypeName)));

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

Can you use sizeof(*new_data) here?

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

Can you use sizeof(*new_data) here?

@bnoordhuis

View changes

test/parallel/test-stringbytes-external.js
+ try {
+ var maxBuffer = new Buffer(kStringMaxLength * 4);
+ } catch(e) {
+ assert(e.message === 'Buffer allocation failed - process out of memory');

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

Can you use assert.equal here?

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

Can you use assert.equal here?

@bnoordhuis

View changes

test/parallel/test-stringbytes-external.js
+ }, Error);
+
+ try {
+ var maxBuffer = new Buffer(kStringMaxLength * 4);

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

Can I suggest dropping the var maxBuffer = here? I don't think V8's lexical analysis pass is smart enough to figure out that this is a dead store, it'll keep a reference to the buffer alive until the function returns. Without the assignment, it's immediately collectible.

@bnoordhuis

bnoordhuis Aug 22, 2015

Member

Can I suggest dropping the var maxBuffer = here? I don't think V8's lexical analysis pass is smart enough to figure out that this is a dead store, it'll keep a reference to the buffer alive until the function returns. Without the assignment, it's immediately collectible.

@skomski

This comment has been minimized.

Show comment
Hide comment
@skomski

skomski Aug 22, 2015

Contributor

Next!

Contributor

skomski commented Aug 22, 2015

Next!

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Aug 23, 2015

Contributor

Don't see anything else. LGTM.

Contributor

trevnorris commented Aug 23, 2015

Don't see anything else. LGTM.

- return this.utf8Slice(0, length);
- return slowToString.apply(this, arguments);
+ if (arguments.length === 0) {
+ var result = this.utf8Slice(0, this.length);

This comment has been minimized.

@thefourtheye

thefourtheye Aug 23, 2015

Contributor

Re-declaration of result in different branches.

@thefourtheye

thefourtheye Aug 23, 2015

Contributor

Re-declaration of result in different branches.

This comment has been minimized.

@bnoordhuis

bnoordhuis Aug 24, 2015

Member

It's legal JS and we do it in other places as well.

@bnoordhuis

bnoordhuis Aug 24, 2015

Member

It's legal JS and we do it in other places as well.

@skomski

This comment has been minimized.

Show comment
Hide comment
@skomski

skomski Aug 28, 2015

Contributor

Needs a new CI because the last one got switched around but was actually green

Contributor

skomski commented Aug 28, 2015

Needs a new CI because the last one got switched around but was actually green

@skomski

This comment has been minimized.

Show comment
Hide comment
Contributor

skomski commented Aug 31, 2015

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Aug 31, 2015

Contributor

@rvagg This one should have made it into v4.

Contributor

trevnorris commented Aug 31, 2015

@rvagg This one should have made it into v4.

@rvagg

This comment has been minimized.

Show comment
Hide comment
@rvagg

rvagg Aug 31, 2015

Member

https://ci.nodejs.org/job/node-test-pull-request/219/

happy to bring this on to v4.x if it lands

Member

rvagg commented Aug 31, 2015

https://ci.nodejs.org/job/node-test-pull-request/219/

happy to bring this on to v4.x if it lands

@rvagg rvagg added this to the 4.0.0 milestone Aug 31, 2015

@indutny

This comment has been minimized.

Show comment
Hide comment
@indutny

indutny Sep 1, 2015

Member

LGTM

Member

indutny commented Sep 1, 2015

LGTM

@indutny

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

View changes

test/parallel/test-stringbytes-external.js
+ new Buffer(kStringMaxLength * 4);
+ } catch(e) {
+ assert.equal(e.message, 'Buffer allocation failed - process out of memory');
+ console.log('skip non-throwing toString tests due to memory confinements');

This comment has been minimized.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

Its generally not preferred to print anything to the console in tests.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

Its generally not preferred to print anything to the console in tests.

This comment has been minimized.

@indutny

indutny Sep 1, 2015

Member

Hm... we have lots of tests that do this. Is this some new policy?

@indutny

indutny Sep 1, 2015

Member

Hm... we have lots of tests that do this. Is this some new policy?

This comment has been minimized.

@Fishrock123

Fishrock123 Sep 1, 2015

Member

That's not quite accurate. This should log, but it should log out TAP skip formatted info. See https://github.com/nodejs/node/blob/master/test/parallel/test-tick-processor.js#L31 for an example.

@Fishrock123

Fishrock123 Sep 1, 2015

Member

That's not quite accurate. This should log, but it should log out TAP skip formatted info. See https://github.com/nodejs/node/blob/master/test/parallel/test-tick-processor.js#L31 for an example.

This comment has been minimized.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

@Fishrock123 If it logs in TAP skip format, then the entire test would be considered as skipped. This only skips a part of it, right?

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

@Fishrock123 If it logs in TAP skip format, then the entire test would be considered as skipped. This only skips a part of it, right?

This comment has been minimized.

@Fishrock123

Fishrock123 Sep 1, 2015

Member

I'd log TAP skip anyways. If it errors after it it'l still see it, since the error code will be non-zero. Afaik anyways.

@Fishrock123

Fishrock123 Sep 1, 2015

Member

I'd log TAP skip anyways. If it errors after it it'l still see it, since the error code will be non-zero. Afaik anyways.

This comment has been minimized.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

Why don't we have this test done at the last? We don't have to skip anything then.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

Why don't we have this test done at the last? We don't have to skip anything then.

This comment has been minimized.

@skomski

skomski Sep 1, 2015

Contributor

@thefourtheye This check is only done because you can't distinguish between toString error causes in the following tests which would fail in a memory confined environment

Changed log format to TAP skip.

@skomski

skomski Sep 1, 2015

Contributor

@thefourtheye This check is only done because you can't distinguish between toString error causes in the following tests which would fail in a memory confined environment

Changed log format to TAP skip.

This comment has been minimized.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

Will moving the following tests above this test help? We don't have to print TAP skip in that case

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

Will moving the following tests above this test help? We don't have to print TAP skip in that case

@thefourtheye

View changes

test/parallel/test-stringbytes-external.js
+
+ assert.throws(function() {
+ var buf = new Buffer(kStringMaxLength + 1).fill().toString();
+ }, Error);

This comment has been minimized.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

Instead of checking just Error, can we check the actual message itself?

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

Instead of checking just Error, can we check the actual message itself?

@thefourtheye

View changes

test/parallel/test-stringbytes-external.js
+ const kStringMaxLength = process.binding('buffer').kStringMaxLength;
+
+ assert.throws(function() {
+ var buf = new Buffer(kStringMaxLength + 1).fill().toString();

This comment has been minimized.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

If it is going to throw, var buf = is not necessary.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

If it is going to throw, var buf = is not necessary.

This comment has been minimized.

@trevnorris

trevnorris Sep 1, 2015

Contributor

Remove the fill(). kMaxStringLength is pretty large and will add unnecessary time to the test. Just use toString('binary') to ensure the correct string length is achieved.

/cc @bnoordhuis Some issue I might be missing by not filling it?

@trevnorris

trevnorris Sep 1, 2015

Contributor

Remove the fill(). kMaxStringLength is pretty large and will add unnecessary time to the test. Just use toString('binary') to ensure the correct string length is achieved.

/cc @bnoordhuis Some issue I might be missing by not filling it?

This comment has been minimized.

@thefourtheye

View changes

test/parallel/test-stringbytes-external.js
+
+ var maxString = new Buffer(kStringMaxLength).fill().toString();
+ assert.equal(maxString.length, kStringMaxLength);
+ maxString = undefined;

This comment has been minimized.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

This is not necessary. You can straight away assign some other object.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

This is not necessary. You can straight away assign some other object.

This comment has been minimized.

@skomski

skomski Sep 1, 2015

Contributor

I am doing it because else v8 would first free the memory at the end of the next assignment which would mean 512MB instead of 256MB.

@skomski

skomski Sep 1, 2015

Contributor

I am doing it because else v8 would first free the memory at the end of the next assignment which would mean 512MB instead of 256MB.

This comment has been minimized.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

@skomski If there is a specific reason why you do this, please explain the same in the comments in the code. Tomorrow, this line might get removed as it is generally not necessary here.

@thefourtheye

thefourtheye Sep 1, 2015

Contributor

@skomski If there is a specific reason why you do this, please explain the same in the comments in the code. Tomorrow, this line might get removed as it is generally not necessary here.

@skomski

This comment has been minimized.

Show comment
Hide comment
@skomski

skomski Sep 1, 2015

Contributor

Now the test timed out: https://ci.nodejs.org/job/node-test-commit-arm/nodes=pi1-raspbian-wheezy-2_of_2/423/tapTestReport/test.tap-336/
btw It should print something to indicate that.

The PR #2410 should made the test much faster but I can't find the mentioned landed commit bfb5a58 in any branch.

Contributor

skomski commented Sep 1, 2015

Now the test timed out: https://ci.nodejs.org/job/node-test-commit-arm/nodes=pi1-raspbian-wheezy-2_of_2/423/tapTestReport/test.tap-336/
btw It should print something to indicate that.

The PR #2410 should made the test much faster but I can't find the mentioned landed commit bfb5a58 in any branch.

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Sep 1, 2015

Contributor

@skomski The probable reason for timing out are all the .fill() calls. You can probably drop the check on all the different encodings. The 'binary' encoding will give you the shortest possible string and should be the only one that needs to be tested.

Contributor

trevnorris commented Sep 1, 2015

@skomski The probable reason for timing out are all the .fill() calls. You can probably drop the check on all the different encodings. The 'binary' encoding will give you the shortest possible string and should be the only one that needs to be tested.

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Sep 2, 2015

Contributor

@skomski Testing the patch on top of the string bytes perf fix, it still takes way too long. Check https://ci.nodejs.org/job/node-test-commit-arm/433/nodes=pi1-raspbian-wheezy-2_of_2/tapTestReport/

Execution time is 3:23, and it's also failing for some reason. I think the tests that check all the different encodings can be dropped. That should save a lot of time. Running gc() could prevent the test from reaching swap.

Contributor

trevnorris commented Sep 2, 2015

@skomski Testing the patch on top of the string bytes perf fix, it still takes way too long. Check https://ci.nodejs.org/job/node-test-commit-arm/433/nodes=pi1-raspbian-wheezy-2_of_2/tapTestReport/

Execution time is 3:23, and it's also failing for some reason. I think the tests that check all the different encodings can be dropped. That should save a lot of time. Running gc() could prevent the test from reaching swap.

src: fix memory leak in ExternString
v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength
@skomski

This comment has been minimized.

Show comment
Hide comment
@skomski

skomski Sep 2, 2015

Contributor

I think the different encodings test are needed because they use different paths and already catched two negligences and it's bad to compromise the tests only for the raspberry pi 1.

I moved the check up for memory confinement environments and removed the fill calls.

Contributor

skomski commented Sep 2, 2015

I think the different encodings test are needed because they use different paths and already catched two negligences and it's bad to compromise the tests only for the raspberry pi 1.

I moved the check up for memory confinement environments and removed the fill calls.

@jbergstroem

This comment has been minimized.

Show comment
Hide comment
@skomski

This comment has been minimized.

Show comment
Hide comment
@skomski

skomski Sep 2, 2015

Contributor

Last CI test finally passed. Now someone only needs to start node-accept-pull-request to do it all over again to end this torture.

Contributor

skomski commented Sep 2, 2015

Last CI test finally passed. Now someone only needs to start node-accept-pull-request to do it all over again to end this torture.

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Sep 2, 2015

Contributor

CI: https://ci.nodejs.org/job/node-merge-commit/148/

Link is 404 at time of posting b/c another build is running.

Contributor

trevnorris commented Sep 2, 2015

CI: https://ci.nodejs.org/job/node-merge-commit/148/

Link is 404 at time of posting b/c another build is running.

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Sep 2, 2015

Contributor

Sorry for botching the CI job. Here's the new one: https://ci.nodejs.org/job/node-merge-commit/151/

Contributor

trevnorris commented Sep 2, 2015

Sorry for botching the CI job. Here's the new one: https://ci.nodejs.org/job/node-merge-commit/151/

@orangemocha

This comment has been minimized.

Show comment
Hide comment
@orangemocha

orangemocha Sep 2, 2015

Member

On SmartOS:

not ok 36 - test-child-process-fork-net2.js

Member

orangemocha commented Sep 2, 2015

On SmartOS:

not ok 36 - test-child-process-fork-net2.js

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Sep 2, 2015

Contributor

@orangemocha That test is unrelated to this patch.

Contributor

trevnorris commented Sep 2, 2015

@orangemocha That test is unrelated to this patch.

@orangemocha

This comment has been minimized.

Show comment
Hide comment
@orangemocha

orangemocha Sep 2, 2015

Member

@trevnorris in that case feel free to add a commit to mark it as flaky : https://github.com/nodejs/node/wiki/Flaky-tests

Otherwise I'll get to it in a few hours.

Member

orangemocha commented Sep 2, 2015

@trevnorris in that case feel free to add a commit to mark it as flaky : https://github.com/nodejs/node/wiki/Flaky-tests

Otherwise I'll get to it in a few hours.

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Sep 2, 2015

Contributor

re-running CI to see if it was a fluke: https://ci.nodejs.org/job/node-merge-commit/154/

Contributor

trevnorris commented Sep 2, 2015

re-running CI to see if it was a fluke: https://ci.nodejs.org/job/node-merge-commit/154/

trevnorris added a commit that referenced this pull request Sep 2, 2015

src: fix memory leak in ExternString
v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: #1374
PR-URL: #2402
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
@orangemocha

This comment has been minimized.

Show comment
Hide comment
@orangemocha

orangemocha Sep 2, 2015

Member

Landed in 617ee32

Member

orangemocha commented Sep 2, 2015

Landed in 617ee32

@orangemocha

This comment has been minimized.

Show comment
Hide comment
@orangemocha

orangemocha Sep 3, 2015

Member

Following up on that flaky test here: #2670

Member

orangemocha commented Sep 3, 2015

Following up on that flaky test here: #2670

@rvagg rvagg referenced this pull request Sep 3, 2015

Closed

Node.js v4 Release Timeline #2522

9 of 10 tasks complete

@mscdex mscdex closed this Sep 3, 2015

@jbergstroem

This comment has been minimized.

Show comment
Hide comment
@jbergstroem

jbergstroem Sep 3, 2015

Member

(fyi, this merged commit seems to have a unixtime: 0 commit date)

Member

jbergstroem commented Sep 3, 2015

(fyi, this merged commit seems to have a unixtime: 0 commit date)

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Sep 3, 2015

Contributor

@jbergstroem Hm. strange

From 617ee324d29abedc95507d5f9d16b2f18778a484 Mon Sep 17 00:00:00 2001

@orangemocha Know how this could have happened?

Contributor

trevnorris commented Sep 3, 2015

@jbergstroem Hm. strange

From 617ee324d29abedc95507d5f9d16b2f18778a484 Mon Sep 17 00:00:00 2001

@orangemocha Know how this could have happened?

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Sep 3, 2015

Contributor

@jbergstroem Good spot. That's really weird.

Contributor

thefourtheye commented Sep 3, 2015

@jbergstroem Good spot. That's really weird.

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Sep 3, 2015

Contributor

Wait... The original commit itself had the same time stamp.

Contributor

thefourtheye commented Sep 3, 2015

Wait... The original commit itself had the same time stamp.

@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Sep 3, 2015

image

@jbergstroem

This comment has been minimized.

Show comment
Hide comment
@jbergstroem

jbergstroem Sep 3, 2015

Member

I've contacted @skomski since I found additional commits in his repo with the same issue. Btw, all credit to lpin@freenode which pointed it out first.

Member

jbergstroem commented Sep 3, 2015

I've contacted @skomski since I found additional commits in his repo with the same issue. Btw, all credit to lpin@freenode which pointed it out first.

@orangemocha

This comment has been minimized.

Show comment
Hide comment
@orangemocha

orangemocha Sep 3, 2015

Member

As you noted, this was not a Jenkins issue. Jenkins doesn't change the authoring date.

Member

orangemocha commented Sep 3, 2015

As you noted, this was not a Jenkins issue. Jenkins doesn't change the authoring date.

Fishrock123 added a commit that referenced this pull request Sep 3, 2015

src: fix memory leak in ExternString
v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: #1374
PR-URL: #2402
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 3, 2015

src: fix memory leak in ExternString
v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: nodejs#1374
PR-URL: nodejs#2402
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

@rvagg rvagg referenced this pull request Sep 5, 2015

Merged

Release proposal: v3.3.1 #2698

rvagg added a commit that referenced this pull request Sep 6, 2015

src: fix memory leak in ExternString
v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: #1374
PR-URL: #2402
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

Amended by @rvagg to change author date from
  "1970-08-16 16:09:02 +0200"
to
  "2015-08-16 16:09:02 +0200"
as per discussion @ #2713

rvagg added a commit that referenced this pull request Sep 6, 2015

src: fix memory leak in ExternString
v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: #1374
PR-URL: #2402
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

Amended by @rvagg to change author date from
  "1970-08-16 16:09:02 +0200"
to
  "2015-08-16 16:09:02 +0200"
as per discussion @ #2713

rvagg added a commit that referenced this pull request Sep 6, 2015

src: fix memory leak in ExternString
v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: #1374
PR-URL: #2402
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

Amended by @rvagg to change author date from
  "1970-08-16 16:09:02 +0200"
to
  "2015-08-16 16:09:02 +0200"
as per discussion @ #2713

rvagg added a commit that referenced this pull request Sep 6, 2015

src: fix memory leak in ExternString
v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: #1374
PR-URL: #2402
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

Amended by @rvagg to change author date from
  "1970-08-16 16:09:02 +0200"
to
  "2015-08-16 16:09:02 +0200"
as per discussion @ #2713

@rvagg rvagg referenced this pull request Sep 7, 2015

Merged

Release proposal: v4.0.0 #2715

jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Sep 9, 2015

ryoon
Update to 4.0.0
* OpenSSL 1.0.2 or later is required.

Changelog:
## 2015-09-08, Version 4.0.0 (Stable), @rvagg

### Notable changes

This list of changes is relative to the last io.js v3.x branch release, v3.3.0. Please see the list of notable changes in the v3.x, v2.x and v1.x releases for a more complete list of changes from 0.12.x. Note, that some changes in the v3.x series as well as major breaking changes in this release constitute changes required for full convergence of the Node.js and io.js projects.

* **child_process**: `ChildProcess.prototype.send()` and `process.send()` operate asynchronously across all platforms so an optional callback parameter has been introduced that will be invoked once the message has been sent, i.e. `.send(message[, sendHandle][, callback])` (Ben Noordhuis) [#2620](https://github.com/nodejs/node/pull/2620).
* **node**: Rename "io.js" code to "Node.js" (cjihrig) [#2367](https://github.com/nodejs/node/pull/2367).
* **node-gyp**: This release bundles an updated version of node-gyp that works with all versions of Node.js and io.js including nightly and release candidate builds. From io.js v3 and Node.js v4 onward, it will only download a headers tarball when building addons rather than the entire source. (Rod Vagg) [#2700](https://github.com/nodejs/node/pull/2700)
* **npm**: Upgrade to version 2.14.2 from 2.13.3, includes a security update, see https://github.com/npm/npm/releases/tag/v2.14.2 for more details, (Kat Marchán) [#2696](https://github.com/nodejs/node/pull/2696).
* **timers**: Improved timer performance from porting the 0.12 implementation, plus minor fixes (Jeremiah Senkpiel) [#2540](https://github.com/nodejs/node/pull/2540), (Julien Gilli) [nodejs/node-v0.x-archive#8751](https://github.com/nodejs/node-v0.x-archive/pull/8751) [nodejs/node-v0.x-archive#8905](https://github.com/nodejs/node-v0.x-archive/pull/8905)
* **util**: The `util.is*()` functions have been deprecated, beginning with deprecation warnings in the documentation for this release, users are encouraged to seek more robust alternatives in the npm registry, (Sakthipriyan Vairamani) [#2447](https://github.com/nodejs/node/pull/2447).
* **v8**: Upgrade to version 4.5.103.30 from 4.4.63.30 (Ali Ijaz Sheikh) [#2632](https://github.com/nodejs/node/pull/2632).
 - Implement new `TypedArray` prototype methods: `copyWithin()`, `every()`, `fill()`, `filter()`, `find()`, `findIndex()`, `forEach()`, `indexOf()`, `join()`, `lastIndexOf()`, `map()`, `reduce()`, `reduceRight()`, `reverse()`, `slice()`, `some()`, `sort()`. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information.
 - Implement new `TypedArray.from()` and `TypedArray.of()` functions. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information.
 - Implement arrow functions, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions for further information.
 - Full ChangeLog available at https://github.com/v8/v8-git-mirror/blob/4.5.103/ChangeLog

### Known issues

See https://github.com/nodejs/node/labels/confirmed-bug for complete and current list of known issues.

* Some uses of computed object shorthand properties are not handled correctly by the current version of V8. e.g. `[{ [prop]: val }]` evaluates to `[{}]`. [#2507](https://github.com/nodejs/node/issues/2507)
* Some problems with unreferenced timers running during `beforeExit` are still to be resolved. See [#1264](https://github.com/nodejs/node/issues/1264).
* Surrogate pair in REPL can freeze terminal. [#690](https://github.com/nodejs/node/issues/690)
* Calling `dns.setServers()` while a DNS query is in progress can cause the process to crash on a failed assertion. [#894](https://github.com/nodejs/node/issues/894)
* `url.resolve` may transfer the auth portion of the url when resolving between two full hosts, see [#1435](https://github.com/nodejs/node/issues/1435).

### Commits

* [[`4f50d3fb90`](https://github.com/nodejs/node/commit/4f50d3fb90)] - **(SEMVER-MAJOR)** This commit sets the value of process.release.name to "node". (cjihrig) [#2367](https://github.com/nodejs/node/pull/2367)
* [[`d3178d8b1b`](https://github.com/nodejs/node/commit/d3178d8b1b)] - **buffer**: SlowBuffer only accept valid numeric values (Michaël Zasso) [#2635](https://github.com/nodejs/node/pull/2635)
* [[`0cb0f4a6e4`](https://github.com/nodejs/node/commit/0cb0f4a6e4)] - **build**: fix v8_enable_handle_zapping override (Karl Skomski) [#2731](https://github.com/nodejs/node/pull/2731)
* [[`a7596d7efc`](https://github.com/nodejs/node/commit/a7596d7efc)] - **build**: remote commands on staging in single session (Rod Vagg) [#2717](https://github.com/nodejs/node/pull/2717)
* [[`be427e9efa`](https://github.com/nodejs/node/commit/be427e9efa)] - **build**: make .msi install to "nodejs", not "node" (Rod Vagg) [#2701](https://github.com/nodejs/node/pull/2701)
* [[`5652ce0dbc`](https://github.com/nodejs/node/commit/5652ce0dbc)] - **build**: fix .pkg creation tooling (Rod Vagg) [#2687](https://github.com/nodejs/node/pull/2687)
* [[`101db80111`](https://github.com/nodejs/node/commit/101db80111)] - **build**: add --enable-asan with builtin leakcheck (Karl Skomski) [#2376](https://github.com/nodejs/node/pull/2376)
* [[`2c3939c9c0`](https://github.com/nodejs/node/commit/2c3939c9c0)] - **child_process**: use stdio.fd even if it is 0 (Evan Lucas) [#2727](https://github.com/nodejs/node/pull/2727)
* [[`609db5a1dd`](https://github.com/nodejs/node/commit/609db5a1dd)] - **child_process**: check execFile and fork args (James M Snell) [#2667](https://github.com/nodejs/node/pull/2667)
* [[`d010568c23`](https://github.com/nodejs/node/commit/d010568c23)] - **(SEMVER-MAJOR)** **child_process**: add callback parameter to .send() (Ben Noordhuis) [#2620](https://github.com/nodejs/node/pull/2620)
* [[`c60857a81a`](https://github.com/nodejs/node/commit/c60857a81a)] - **cluster**: allow shared reused dgram sockets (Fedor Indutny) [#2548](https://github.com/nodejs/node/pull/2548)
* [[`b2ecbb6191`](https://github.com/nodejs/node/commit/b2ecbb6191)] - **contextify**: ignore getters during initialization (Fedor Indutny) [#2091](https://github.com/nodejs/node/pull/2091)
* [[`3711934095`](https://github.com/nodejs/node/commit/3711934095)] - **cpplint**: make it possible to run outside git repo (Ben Noordhuis) [#2710](https://github.com/nodejs/node/pull/2710)
* [[`03f900ab25`](https://github.com/nodejs/node/commit/03f900ab25)] - **crypto**: replace rwlocks with simple mutexes (Ben Noordhuis) [#2723](https://github.com/nodejs/node/pull/2723)
* [[`847459c29b`](https://github.com/nodejs/node/commit/847459c29b)] - **(SEMVER-MAJOR)** **crypto**: show exponent in decimal and hex (Chad Johnston) [#2320](https://github.com/nodejs/node/pull/2320)
* [[`e1c976184d`](https://github.com/nodejs/node/commit/e1c976184d)] - **deps**: improve ArrayBuffer performance in v8 (Fedor Indutny) [#2732](https://github.com/nodejs/node/pull/2732)
* [[`cc0ab17a23`](https://github.com/nodejs/node/commit/cc0ab17a23)] - **deps**: float node-gyp v3.0.0 (Rod Vagg) [#2700](https://github.com/nodejs/node/pull/2700)
* [[`b2c3c6d727`](https://github.com/nodejs/node/commit/b2c3c6d727)] - **deps**: create .npmrc during npm tests (Kat Marchán) [#2696](https://github.com/nodejs/node/pull/2696)
* [[`babdbfdbd5`](https://github.com/nodejs/node/commit/babdbfdbd5)] - **deps**: upgrade to npm 2.14.2 (Kat Marchán) [#2696](https://github.com/nodejs/node/pull/2696)
* [[`155783d876`](https://github.com/nodejs/node/commit/155783d876)] - **deps**: backport 75e43a6 from v8 upstream (again) (saper) [#2692](https://github.com/nodejs/node/pull/2692)
* [[`5424d6fcf0`](https://github.com/nodejs/node/commit/5424d6fcf0)] - **deps**: upgrade V8 to 4.5.103.30 (Ali Ijaz Sheikh) [#2632](https://github.com/nodejs/node/pull/2632)
* [[`c43172578e`](https://github.com/nodejs/node/commit/c43172578e)] - **(SEMVER-MAJOR)** **deps**: upgrade V8 to 4.5.103.24 (Ali Ijaz Sheikh) [#2509](https://github.com/nodejs/node/pull/2509)
* [[`714e96e8b9`](https://github.com/nodejs/node/commit/714e96e8b9)] - **deps**: backport 75e43a6 from v8 upstream (saper) [#2636](https://github.com/nodejs/node/pull/2636)
* [[`8637755cbf`](https://github.com/nodejs/node/commit/8637755cbf)] - **doc**: add TSC meeting minutes 2015-09-02 (Rod Vagg) [#2674](https://github.com/nodejs/node/pull/2674)
* [[`d3d5b93214`](https://github.com/nodejs/node/commit/d3d5b93214)] - **doc**: update environment vars in manpage and --help (Roman Reiss) [#2690](https://github.com/nodejs/node/pull/2690)
* [[`29f586ac0a`](https://github.com/nodejs/node/commit/29f586ac0a)] - **doc**: update url doc to account for escaping (Jeremiah Senkpiel) [#2605](https://github.com/nodejs/node/pull/2605)
* [[`ba50cfebef`](https://github.com/nodejs/node/commit/ba50cfebef)] - **doc**: reorder collaborators by their usernames (Johan Bergström) [#2322](https://github.com/nodejs/node/pull/2322)
* [[`8a9a3bf798`](https://github.com/nodejs/node/commit/8a9a3bf798)] - **doc**: update changelog for io.js v3.3.0 (Rod Vagg) [#2653](https://github.com/nodejs/node/pull/2653)
* [[`6cd0e2664b`](https://github.com/nodejs/node/commit/6cd0e2664b)] - **doc**: update io.js reference (Ben Noordhuis) [#2580](https://github.com/nodejs/node/pull/2580)
* [[`f9539c19e8`](https://github.com/nodejs/node/commit/f9539c19e8)] - **doc**: update changelog for io.js v3.2.0 (Rod Vagg) [#2512](https://github.com/nodejs/node/pull/2512)
* [[`cded6e7993`](https://github.com/nodejs/node/commit/cded6e7993)] - **doc**: fix CHANGELOG.md on master (Roman Reiss) [#2513](https://github.com/nodejs/node/pull/2513)
* [[`93e2830686`](https://github.com/nodejs/node/commit/93e2830686)] - **(SEMVER-MINOR)** **doc**: document deprecation of util.is* functions (Sakthipriyan Vairamani) [#2447](https://github.com/nodejs/node/pull/2447)
* [[`7038388558`](https://github.com/nodejs/node/commit/7038388558)] - **doc,test**: enable recursive file watching in Windows (Sakthipriyan Vairamani) [#2649](https://github.com/nodejs/node/pull/2649)
* [[`f3696f64a1`](https://github.com/nodejs/node/commit/f3696f64a1)] - **events,lib**: don't require EE#listenerCount() (Jeremiah Senkpiel) [#2661](https://github.com/nodejs/node/pull/2661)
* [[`45a2046f5d`](https://github.com/nodejs/node/commit/45a2046f5d)] - **(SEMVER-MAJOR)** **installer**: fix installers for node.js rename (Frederic Hemberger) [#2367](https://github.com/nodejs/node/pull/2367)
* [[`7a999a1376`](https://github.com/nodejs/node/commit/7a999a1376)] - **(SEMVER-MAJOR)** **lib**: add net.Socket#localFamily property (Ben Noordhuis) [#956](https://github.com/nodejs/node/pull/956)
* [[`de88255b0f`](https://github.com/nodejs/node/commit/de88255b0f)] - ***Revert*** "**lib,src**: add unix socket getsockname/getpeername" (Ben Noordhuis) [#2584](https://github.com/nodejs/node/pull/2584)
* [[`f337595441`](https://github.com/nodejs/node/commit/f337595441)] - **(SEMVER-MAJOR)** **lib,src**: add unix socket getsockname/getpeername (Ben Noordhuis) [#956](https://github.com/nodejs/node/pull/956)
* [[`3b602527d1`](https://github.com/nodejs/node/commit/3b602527d1)] - **(SEMVER-MAJOR)** **node**: additional cleanup for node rename (cjihrig) [#2367](https://github.com/nodejs/node/pull/2367)
* [[`a69ab27ab4`](https://github.com/nodejs/node/commit/a69ab27ab4)] - **(SEMVER-MAJOR)** **node**: rename from io.js to node (cjihrig) [#2367](https://github.com/nodejs/node/pull/2367)
* [[`9358eee9dd`](https://github.com/nodejs/node/commit/9358eee9dd)] - **node-gyp**: float 3.0.1, minor fix for download url (Rod Vagg) [#2737](https://github.com/nodejs/node/pull/2737)
* [[`d2d981252b`](https://github.com/nodejs/node/commit/d2d981252b)] - **src**: s/ia32/x86 for process.release.libUrl for win (Rod Vagg) [#2699](https://github.com/nodejs/node/pull/2699)
* [[`eba3d3dccd`](https://github.com/nodejs/node/commit/eba3d3dccd)] - **src**: use standard conform snprintf on windows (Karl Skomski) [#2404](https://github.com/nodejs/node/pull/2404)
* [[`cddbec231f`](https://github.com/nodejs/node/commit/cddbec231f)] - **src**: fix buffer overflow for long exception lines (Karl Skomski) [#2404](https://github.com/nodejs/node/pull/2404)
* [[`dd3f3417c7`](https://github.com/nodejs/node/commit/dd3f3417c7)] - **src**: re-enable fast math on arm (Michaël Zasso) [#2592](https://github.com/nodejs/node/pull/2592)
* [[`e137c1177c`](https://github.com/nodejs/node/commit/e137c1177c)] - **(SEMVER-MAJOR)** **src**: enable vector ics on arm again (Ali Ijaz Sheikh) [#2509](https://github.com/nodejs/node/pull/2509)
* [[`7ce749d722`](https://github.com/nodejs/node/commit/7ce749d722)] - **src**: replace usage of v8::Handle with v8::Local (Michaël Zasso) [#2202](https://github.com/nodejs/node/pull/2202)
* [[`b1a2d9509f`](https://github.com/nodejs/node/commit/b1a2d9509f)] - **src**: enable v8 deprecation warnings and fix them (Ben Noordhuis) [#2091](https://github.com/nodejs/node/pull/2091)
* [[`808de0da03`](https://github.com/nodejs/node/commit/808de0da03)] - **(SEMVER-MAJOR)** **src**: apply debug force load fixups from 41e63fb (Ali Ijaz Sheikh) [#2509](https://github.com/nodejs/node/pull/2509)
* [[`5201cb0ff1`](https://github.com/nodejs/node/commit/5201cb0ff1)] - **src**: fix memory leak in ExternString (Karl Skomski) [#2402](https://github.com/nodejs/node/pull/2402)
* [[`2308a27c0a`](https://github.com/nodejs/node/commit/2308a27c0a)] - **src**: only set v8 flags if argc > 1 (Evan Lucas) [#2646](https://github.com/nodejs/node/pull/2646)
* [[`384effed20`](https://github.com/nodejs/node/commit/384effed20)] - **test**: fix use of `common` before required (Rod Vagg) [#2685](https://github.com/nodejs/node/pull/2685)
* [[`f146f686b7`](https://github.com/nodejs/node/commit/f146f686b7)] - **(SEMVER-MAJOR)** **test**: fix test-repl-tab-complete.js for V8 4.5 (Ali Ijaz Sheikh) [#2509](https://github.com/nodejs/node/pull/2509)
* [[`fe4b309fd3`](https://github.com/nodejs/node/commit/fe4b309fd3)] - **test**: refactor to eliminate flaky test (Rich Trott) [#2609](https://github.com/nodejs/node/pull/2609)
* [[`619721e6b8`](https://github.com/nodejs/node/commit/619721e6b8)] - **test**: mark eval_messages as flaky (Alexis Campailla) [#2648](https://github.com/nodejs/node/pull/2648)
* [[`93ba585b66`](https://github.com/nodejs/node/commit/93ba585b66)] - **test**: mark test-vm-syntax-error-stderr as flaky (João Reis) [#2662](https://github.com/nodejs/node/pull/2662)
* [[`367140bca0`](https://github.com/nodejs/node/commit/367140bca0)] - **test**: mark test-repl-persistent-history as flaky (João Reis) [#2659](https://github.com/nodejs/node/pull/2659)
* [[`f6b093343d`](https://github.com/nodejs/node/commit/f6b093343d)] - **timers**: minor `_unrefActive` fixes and improvements (Jeremiah Senkpiel) [#2540](https://github.com/nodejs/node/pull/2540)
* [[`403d7ee7d1`](https://github.com/nodejs/node/commit/403d7ee7d1)] - **timers**: don't mutate unref list while iterating it (Julien Gilli) [#2540](https://github.com/nodejs/node/pull/2540)
* [[`7a8c3e08c3`](https://github.com/nodejs/node/commit/7a8c3e08c3)] - **timers**: Avoid linear scan in `_unrefActive`. (Julien Gilli) [#2540](https://github.com/nodejs/node/pull/2540)
* [[`b630ebaf43`](https://github.com/nodejs/node/commit/b630ebaf43)] - **win,msi**: Upgrade from old upgrade code (João Reis) [#2439](https://github.com/nodejs/node/pull/2439)

## 2015-09-02, Version 3.3.0, @rvagg

### Notable changes

* **build**: Add a `--link-module` option to `configure` that can be used to bundle additional JavaScript modules into a built binary (Bradley Meck) [#2497](https://github.com/nodejs/node/pull/2497)
* **docs**: Merge outstanding doc updates from joyent/node (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* **http_parser**: Significant performance improvement by having `http.Server` consume all initial data from its `net.Socket` and parsing directly without having to enter JavaScript. Any `'data'` listeners on the `net.Socket` will result in the data being "unconsumed" into JavaScript, thereby undoing any performance gains. (Fedor Indutny) [#2355](https://github.com/nodejs/node/pull/2355)
* **libuv**: Upgrade to 1.7.3 (from 1.6.1), see [ChangeLog](https://github.com/libuv/libuv/blob/v1.x/ChangeLog) for details (Saúl Ibarra Corretgé) [#2310](https://github.com/nodejs/node/pull/2310)
* **V8**: Upgrade to 4.4.63.30 (from 4.4.63.26) (Michaël Zasso) [#2482](https://github.com/nodejs/node/pull/2482)

### Known issues

See https://github.com/nodejs/io.js/labels/confirmed-bug for complete and current list of known issues.

* Some uses of computed object shorthand properties are not handled correctly by the current version of V8. e.g. `[{ [prop]: val }]` evaluates to `[{}]`. [#2507](https://github.com/nodejs/node/issues/2507)
* Some problems with unreferenced timers running during `beforeExit` are still to be resolved. See [#1264](https://github.com/nodejs/io.js/issues/1264).
* Surrogate pair in REPL can freeze terminal. [#690](https://github.com/nodejs/io.js/issues/690)
* `process.send()` is not synchronous as the docs suggest, a regression introduced in 1.0.2, see [#760](https://github.com/nodejs/io.js/issues/760).
* Calling `dns.setServers()` while a DNS query is in progress can cause the process to crash on a failed assertion. [#894](https://github.com/nodejs/io.js/issues/894)
* `url.resolve` may transfer the auth portion of the url when resolving between two full hosts, see [#1435](https://github.com/nodejs/io.js/issues/1435).

### Commits

* [[`1a531b4e44`](https://github.com/nodejs/node/commit/1a531b4e44)] - **(SEMVER-MINOR)** Introduce --link-module to ./configure (Bradley Meck) [#2497](https://github.com/nodejs/node/pull/2497)
* [[`d2f314c190`](https://github.com/nodejs/node/commit/d2f314c190)] - **build**: fix borked chmod call for release uploads (Rod Vagg) [#2645](https://github.com/nodejs/node/pull/2645)
* [[`3172e9c541`](https://github.com/nodejs/node/commit/3172e9c541)] - **build**: set file permissions before uploading (Rod Vagg) [#2623](https://github.com/nodejs/node/pull/2623)
* [[`a860d7fae1`](https://github.com/nodejs/node/commit/a860d7fae1)] - **build**: change staging directory on new server (Rod Vagg) [#2623](https://github.com/nodejs/node/pull/2623)
* [[`50c0baa8d7`](https://github.com/nodejs/node/commit/50c0baa8d7)] - **build**: rename 'doc' directory to 'docs' for upload (Rod Vagg) [#2623](https://github.com/nodejs/node/pull/2623)
* [[`0a0577cf5f`](https://github.com/nodejs/node/commit/0a0577cf5f)] - **build**: fix bad cherry-pick for vcbuild.bat build-release (Rod Vagg) [#2625](https://github.com/nodejs/node/pull/2625)
* [[`34de90194b`](https://github.com/nodejs/node/commit/34de90194b)] - **build**: only define NODE_V8_OPTIONS if not empty (Evan Lucas) [#2532](https://github.com/nodejs/node/pull/2532)
* [[`944174b189`](https://github.com/nodejs/node/commit/944174b189)] - **build**: make ci test addons in test/addons (Ben Noordhuis) [#2428](https://github.com/nodejs/node/pull/2428)
* [[`e955f9a1b0`](https://github.com/nodejs/node/commit/e955f9a1b0)] - **crypto**: Use OPENSSL_cleanse to shred the data. (Сковорода Никита Андреевич) [#2575](https://github.com/nodejs/node/pull/2575)
* [[`395d736b9d`](https://github.com/nodejs/node/commit/395d736b9d)] - **debugger**: use strict equality comparison (Minwoo Jung) [#2558](https://github.com/nodejs/node/pull/2558)
* [[`1d0e5210a8`](https://github.com/nodejs/node/commit/1d0e5210a8)] - **deps**: upgrade libuv to 1.7.3 (Saúl Ibarra Corretgé) [#2310](https://github.com/nodejs/node/pull/2310)
* [[`34ef53364f`](https://github.com/nodejs/node/commit/34ef53364f)] - **deps**: update V8 to 4.4.63.30 (Michaël Zasso) [#2482](https://github.com/nodejs/node/pull/2482)
* [[`23579a5f4a`](https://github.com/nodejs/node/commit/23579a5f4a)] - **doc**: add TSC meeting minutes 2015-08-12 (Rod Vagg) [#2438](https://github.com/nodejs/node/pull/2438)
* [[`0cc59299a4`](https://github.com/nodejs/node/commit/0cc59299a4)] - **doc**: add TSC meeting minutes 2015-08-26 (Rod Vagg) [#2591](https://github.com/nodejs/node/pull/2591)
* [[`6efa96e33a`](https://github.com/nodejs/node/commit/6efa96e33a)] - **doc**: merge CHANGELOG.md with joyent/node ChangeLog (P.S.V.R) [#2536](https://github.com/nodejs/node/pull/2536)
* [[`f75d54607b`](https://github.com/nodejs/node/commit/f75d54607b)] - **doc**: clarify cluster behaviour with no workers (Jeremiah Senkpiel) [#2606](https://github.com/nodejs/node/pull/2606)
* [[`8936302121`](https://github.com/nodejs/node/commit/8936302121)] - **doc**: minor clarification in buffer.markdown (Сковорода Никита Андреевич) [#2574](https://github.com/nodejs/node/pull/2574)
* [[`0db0e53753`](https://github.com/nodejs/node/commit/0db0e53753)] - **doc**: add @jasnell and @sam-github to release team (Rod Vagg) [#2455](https://github.com/nodejs/node/pull/2455)
* [[`c16e100593`](https://github.com/nodejs/node/commit/c16e100593)] - **doc**: reorg release team to separate section (Rod Vagg) [#2455](https://github.com/nodejs/node/pull/2455)
* [[`e3e00143fd`](https://github.com/nodejs/node/commit/e3e00143fd)] - **doc**: fix bad merge on modules.markdown (James M Snell)
* [[`2f62455880`](https://github.com/nodejs/node/commit/2f62455880)] - **doc**: minor additional corrections and improvements (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`3bd08aac4b`](https://github.com/nodejs/node/commit/3bd08aac4b)] - **doc**: minor grammatical update in crypto.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`f707189370`](https://github.com/nodejs/node/commit/f707189370)] - **doc**: minor grammatical update (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`6c98cf0266`](https://github.com/nodejs/node/commit/6c98cf0266)] - **doc**: remove repeated statement in globals.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`48e6ccf8c2`](https://github.com/nodejs/node/commit/48e6ccf8c2)] - **doc**: remove 'dudes' from documentation (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`b5d68f8076`](https://github.com/nodejs/node/commit/b5d68f8076)] - **doc**: update tense in child_process.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`242e3fe3ba`](https://github.com/nodejs/node/commit/242e3fe3ba)] - **doc**: fixed worker.id type (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`ea9ee15c21`](https://github.com/nodejs/node/commit/ea9ee15c21)] - **doc**: port is optional for socket.bind() (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`0ff6657a50`](https://github.com/nodejs/node/commit/0ff6657a50)] - **doc**: fix minor types and grammar in fs docs (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`94d83c04f2`](https://github.com/nodejs/node/commit/94d83c04f2)] - **doc**: update parameter name in net.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`04111ce40f`](https://github.com/nodejs/node/commit/04111ce40f)] - **doc**: small typo in domain.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`c9fdd1bbbf`](https://github.com/nodejs/node/commit/c9fdd1bbbf)] - **doc**: fixed typo in net.markdown (missing comma) (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`27c07b3f8e`](https://github.com/nodejs/node/commit/27c07b3f8e)] - **doc**: update description of fs.exists in fs.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`52018e73d9`](https://github.com/nodejs/node/commit/52018e73d9)] - **doc**: clarification on the 'close' event (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`f6d3b87a25`](https://github.com/nodejs/node/commit/f6d3b87a25)] - **doc**: improve working in stream.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`b5da89431a`](https://github.com/nodejs/node/commit/b5da89431a)] - **doc**: update path.extname documentation (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`1d4ea609db`](https://github.com/nodejs/node/commit/1d4ea609db)] - **doc**: small clarifications to modules.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`c888985591`](https://github.com/nodejs/node/commit/c888985591)] - **doc**: code style cleanups in repl.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`105b493595`](https://github.com/nodejs/node/commit/105b493595)] - **doc**: correct grammar in cluster.markdown (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`51b86ccac7`](https://github.com/nodejs/node/commit/51b86ccac7)] - **doc**: Clarify the module.parent is set once (James M Snell) [#2378](https://github.com/nodejs/node/pull/2378)
* [[`d2ffecba2d`](https://github.com/nodejs/node/commit/d2ffecba2d)] - **doc**: add internal modules notice (Jeremiah Senkpiel) [#2523](https://github.com/nodejs/node/pull/2523)
* [[`b36debd5cb`](https://github.com/nodejs/node/commit/b36debd5cb)] - **env**: introduce `KickNextTick` (Fedor Indutny) [#2355](https://github.com/nodejs/node/pull/2355)
* [[`1bc446863f`](https://github.com/nodejs/node/commit/1bc446863f)] - **http_parser**: consume StreamBase instance (Fedor Indutny) [#2355](https://github.com/nodejs/node/pull/2355)
* [[`ce04b735cc`](https://github.com/nodejs/node/commit/ce04b735cc)] - **src**: only memcmp if length > 0 in Buffer::Compare (Karl Skomski) [#2544](https://github.com/nodejs/node/pull/2544)
* [[`31823e37c7`](https://github.com/nodejs/node/commit/31823e37c7)] - **src**: DRY getsockname/getpeername code (Ben Noordhuis) [#956](https://github.com/nodejs/node/pull/956)
* [[`13fd96dda3`](https://github.com/nodejs/node/commit/13fd96dda3)] - **src**: missing Exception::Error in node_http_parser (Jeremiah Senkpiel) [#2550](https://github.com/nodejs/node/pull/2550)
* [[`42e075ae02`](https://github.com/nodejs/node/commit/42e075ae02)] - **test**: improve performance of stringbytes test (Trevor Norris) [#2544](https://github.com/nodejs/node/pull/2544)
* [[`fc726399fd`](https://github.com/nodejs/node/commit/fc726399fd)] - **test**: unmark test-process-argv-0.js as flaky (Rich Trott) [#2613](https://github.com/nodejs/node/pull/2613)
* [[`7727ba1394`](https://github.com/nodejs/node/commit/7727ba1394)] - **test**: lint and refactor to avoid autocrlf issue (Roman Reiss) [#2494](https://github.com/nodejs/node/pull/2494)
* [[`c56aa829f0`](https://github.com/nodejs/node/commit/c56aa829f0)] - **test**: use tmpDir instead of fixturesDir (Sakthipriyan Vairamani) [#2583](https://github.com/nodejs/node/pull/2583)
* [[`5e65181ea4`](https://github.com/nodejs/node/commit/5e65181ea4)] - **test**: handling failure cases properly (Sakthipriyan Vairamani) [#2206](https://github.com/nodejs/node/pull/2206)
* [[`c48b95e847`](https://github.com/nodejs/node/commit/c48b95e847)] - **test**: initial list of flaky tests (Alexis Campailla) [#2424](https://github.com/nodejs/node/pull/2424)
* [[`94e88498ba`](https://github.com/nodejs/node/commit/94e88498ba)] - **test**: pass args to test-ci via env variable (Alexis Campailla) [#2424](https://github.com/nodejs/node/pull/2424)
* [[`09987c7a1c`](https://github.com/nodejs/node/commit/09987c7a1c)] - **test**: support flaky tests in test-ci (Alexis Campailla) [#2424](https://github.com/nodejs/node/pull/2424)
* [[`08b83c8b45`](https://github.com/nodejs/node/commit/08b83c8b45)] - **test**: add test configuration templates (Alexis Campailla) [#2424](https://github.com/nodejs/node/pull/2424)
* [[`8f8ab6fa57`](https://github.com/nodejs/node/commit/8f8ab6fa57)] - **test**: runner should return 0 on flaky tests (Alexis Campailla) [#2424](https://github.com/nodejs/node/pull/2424)
* [[`0cfd3be9c6`](https://github.com/nodejs/node/commit/0cfd3be9c6)] - **test**: runner support for flaky tests (Alexis Campailla) [#2424](https://github.com/nodejs/node/pull/2424)
* [[`3492d2d4c6`](https://github.com/nodejs/node/commit/3492d2d4c6)] - **test**: make test-process-argv-0 robust (Rich Trott) [#2541](https://github.com/nodejs/node/pull/2541)
* [[`a96cc31710`](https://github.com/nodejs/node/commit/a96cc31710)] - **test**: speed up test-child-process-spawnsync.js (Rich Trott) [#2542](https://github.com/nodejs/node/pull/2542)
* [[`856baf4c67`](https://github.com/nodejs/node/commit/856baf4c67)] - **test**: make spawnSync() test robust (Rich Trott) [#2535](https://github.com/nodejs/node/pull/2535)
* [[`3aa6bbb648`](https://github.com/nodejs/node/commit/3aa6bbb648)] - **tools**: update release.sh to work with new website (Rod Vagg) [#2623](https://github.com/nodejs/node/pull/2623)
* [[`f2f0fe45ff`](https://github.com/nodejs/node/commit/f2f0fe45ff)] - **tools**: make add-on scraper print filenames (Ben Noordhuis) [#2428](https://github.com/nodejs/node/pull/2428)
* [[`bb24c4a418`](https://github.com/nodejs/node/commit/bb24c4a418)] - **win,msi**: correct installation path registry keys (João Reis) [#2565](https://github.com/nodejs/node/pull/2565)
* [[`752977b888`](https://github.com/nodejs/node/commit/752977b888)] - **win,msi**: change InstallScope to perMachine (João Reis) [#2565](https://github.com/nodejs/node/pull/2565)

## 2015-08-25, Version 3.2.0, @rvagg

### Notable changes

* **events**: Added `EventEmitter#listenerCount(event)` as a replacement for `EventEmitter.listenerCount(emitter, event)`, which has now been marked as deprecated in the docs. (Sakthipriyan Vairamani) [#2349](https://github.com/nodejs/node/pull/2349)
* **module**: Fixed an error with preloaded modules when the current working directory doesn't exist. (Bradley Meck) [#2353](https://github.com/nodejs/node/pull/2353)
* **node**: Startup time is now about 5% faster when not passing V8 flags. (Evan Lucas) [#2483](https://github.com/nodejs/node/pull/2483)
* **repl**: Tab-completion now works better with arrays. (James M Snell) [#2409](https://github.com/nodejs/node/pull/2409)
* **string_bytes**: Fixed an unaligned write in the handling of UCS2 encoding. (Fedor Indutny) [#2480](https://github.com/nodejs/node/pull/2480)
* **tls**: Added a new `--tls-cipher-list` flag that can be used to override the built-in default cipher list. (James M Snell) [#2412](https://github.com/nodejs/node/pull/2412) _Note: it is suggested you use the built-in cipher list as it has been carefully selected to reflect current security best practices and risk mitigation._

### Known issues

See https://github.com/nodejs/io.js/labels/confirmed-bug for complete and current list of known issues.

* Some uses of computed object shorthand properties are not handled correctly by the current version of V8. e.g. `[{ [prop]: val }]` evaluates to `[{}]`. [#2507](https://github.com/nodejs/node/issues/2507)
* Some problems with unreferenced timers running during `beforeExit` are still to be resolved. See [#1264](https://github.com/nodejs/io.js/issues/1264).
* Surrogate pair in REPL can freeze terminal. [#690](https://github.com/nodejs/io.js/issues/690)
* `process.send()` is not synchronous as the docs suggest, a regression introduced in 1.0.2, see [#760](https://github.com/nodejs/io.js/issues/760).
* Calling `dns.setServers()` while a DNS query is in progress can cause the process to crash on a failed assertion. [#894](https://github.com/nodejs/io.js/issues/894)
* `url.resolve` may transfer the auth portion of the url when resolving between two full hosts, see [#1435](https://github.com/nodejs/io.js/issues/1435).

### Commits

* [[`1cd794f129`](https://github.com/nodejs/node/commit/1cd794f129)] - **buffer**: reapply 07c0667 (Fedor Indutny) [#2487](https://github.com/nodejs/node/pull/2487)
* [[`156781dedd`](https://github.com/nodejs/node/commit/156781dedd)] - **build**: use required platform in android-configure (Evan Lucas) [#2501](https://github.com/nodejs/node/pull/2501)
* [[`77075ec906`](https://github.com/nodejs/node/commit/77075ec906)] - **crypto**: fix mem {de}allocation in ExportChallenge (Karl Skomski) [#2359](https://github.com/nodejs/node/pull/2359)
* [[`cb30414d9e`](https://github.com/nodejs/node/commit/cb30414d9e)] - **doc**: sync CHANGELOG.md from master (Roman Reiss) [#2524](https://github.com/nodejs/node/pull/2524)
* [[`9330f5ef45`](https://github.com/nodejs/node/commit/9330f5ef45)] - **doc**: make the deprecations consistent (Sakthipriyan Vairamani) [#2450](https://github.com/nodejs/node/pull/2450)
* [[`09437e0146`](https://github.com/nodejs/node/commit/09437e0146)] - **doc**: fix comments in tls_wrap.cc and _http_client.js (Minwoo Jung) [#2489](https://github.com/nodejs/node/pull/2489)
* [[`c9867fed29`](https://github.com/nodejs/node/commit/c9867fed29)] - **doc**: document response.finished in http.markdown (hackerjs) [#2414](https://github.com/nodejs/node/pull/2414)
* [[`7f23a83c42`](https://github.com/nodejs/node/commit/7f23a83c42)] - **doc**: update AUTHORS list (Rod Vagg) [#2505](https://github.com/nodejs/node/pull/2505)
* [[`cd0c362f67`](https://github.com/nodejs/node/commit/cd0c362f67)] - **doc**: update AUTHORS list (Rod Vagg) [#2318](https://github.com/nodejs/node/pull/2318)
* [[`2c7b9257ea`](https://github.com/nodejs/node/commit/2c7b9257ea)] - **doc**: add TSC meeting minutes 2015-07-29 (Rod Vagg) [#2437](https://github.com/nodejs/node/pull/2437)
* [[`aaefde793e`](https://github.com/nodejs/node/commit/aaefde793e)] - **doc**: add TSC meeting minutes 2015-08-19 (Rod Vagg) [#2460](https://github.com/nodejs/node/pull/2460)
* [[`51ef9106f5`](https://github.com/nodejs/node/commit/51ef9106f5)] - **doc**: add TSC meeting minutes 2015-06-03 (Rod Vagg) [#2453](https://github.com/nodejs/node/pull/2453)
* [[`7130b4cf1d`](https://github.com/nodejs/node/commit/7130b4cf1d)] - **doc**: fix links to original converged repo (Rod Vagg) [#2454](https://github.com/nodejs/node/pull/2454)
* [[`14f2aee1df`](https://github.com/nodejs/node/commit/14f2aee1df)] - **doc**: fix links to original gh issues for TSC meetings (Rod Vagg) [#2454](https://github.com/nodejs/node/pull/2454)
* [[`87a9ef0a40`](https://github.com/nodejs/node/commit/87a9ef0a40)] - **doc**: add audio recording links to TSC meeting minutes (Rod Vagg) [#2454](https://github.com/nodejs/node/pull/2454)
* [[`f5cf24afbc`](https://github.com/nodejs/node/commit/f5cf24afbc)] - **doc**: add TSC meeting minutes 2015-07-22 (Rod Vagg) [#2436](https://github.com/nodejs/node/pull/2436)
* [[`3f821b96eb`](https://github.com/nodejs/node/commit/3f821b96eb)] - **doc**: fix spelling mistake in node.js comment (Jacob Edelman) [#2391](https://github.com/nodejs/node/pull/2391)
* [[`3e6a6fcdd6`](https://github.com/nodejs/node/commit/3e6a6fcdd6)] - **(SEMVER-MINOR)** **events**: deprecate static listenerCount function (Sakthipriyan Vairamani) [#2349](https://github.com/nodejs/node/pull/2349)
* [[`023386c852`](https://github.com/nodejs/node/commit/023386c852)] - **fs**: replace bad_args macro with concrete error msg (Roman Klauke) [#2495](https://github.com/nodejs/node/pull/2495)
* [[`d1c27b2e29`](https://github.com/nodejs/node/commit/d1c27b2e29)] - **module**: fix module preloading when cwd is ENOENT (Bradley Meck) [#2353](https://github.com/nodejs/node/pull/2353)
* [[`5d7486941b`](https://github.com/nodejs/node/commit/5d7486941b)] - **repl**: filter integer keys from repl tab complete list (James M Snell) [#2409](https://github.com/nodejs/node/pull/2409)
* [[`7f02443a9a`](https://github.com/nodejs/node/commit/7f02443a9a)] - **repl**: dont throw ENOENT on NODE_REPL_HISTORY_FILE (Todd Kennedy) [#2451](https://github.com/nodejs/node/pull/2451)
* [[`56a2ae9cef`](https://github.com/nodejs/node/commit/56a2ae9cef)] - **src**: improve startup time (Evan Lucas) [#2483](https://github.com/nodejs/node/pull/2483)
* [[`14653c7429`](https://github.com/nodejs/node/commit/14653c7429)] - **stream**: rename poorly named function (Ben Noordhuis) [#2479](https://github.com/nodejs/node/pull/2479)
* [[`1c6e014bfa`](https://github.com/nodejs/node/commit/1c6e014bfa)] - **stream**: micro-optimize high water mark calculation (Ben Noordhuis) [#2479](https://github.com/nodejs/node/pull/2479)
* [[`f1f4b4c46d`](https://github.com/nodejs/node/commit/f1f4b4c46d)] - **stream**: fix off-by-factor-16 error in comment (Ben Noordhuis) [#2479](https://github.com/nodejs/node/pull/2479)
* [[`2d3f09bd76`](https://github.com/nodejs/node/commit/2d3f09bd76)] - **stream_base**: various improvements (Fedor Indutny) [#2351](https://github.com/nodejs/node/pull/2351)
* [[`c1ce423b35`](https://github.com/nodejs/node/commit/c1ce423b35)] - **string_bytes**: fix unaligned write in UCS2 (Fedor Indutny) [#2480](https://github.com/nodejs/node/pull/2480)
* [[`e4d0e86165`](https://github.com/nodejs/node/commit/e4d0e86165)] - **test**: refactor test-https-simple.js (Rich Trott) [#2433](https://github.com/nodejs/node/pull/2433)
* [[`0ea5c8d737`](https://github.com/nodejs/node/commit/0ea5c8d737)] - **test**: remove test-timers-first-fire (João Reis) [#2458](https://github.com/nodejs/node/pull/2458)
* [[`536c3d0537`](https://github.com/nodejs/node/commit/536c3d0537)] - **test**: use reserved IP in test-net-connect-timeout (Rich Trott) [#2257](https://github.com/nodejs/node/pull/2257)
* [[`5df06fd8df`](https://github.com/nodejs/node/commit/5df06fd8df)] - **test**: add spaces after keywords (Brendan Ashworth)
* [[`e714b5620e`](https://github.com/nodejs/node/commit/e714b5620e)] - **test**: remove unreachable code (Michaël Zasso) [#2289](https://github.com/nodejs/node/pull/2289)
* [[`3579f3a2a4`](https://github.com/nodejs/node/commit/3579f3a2a4)] - **test**: disallow unreachable code (Michaël Zasso) [#2289](https://github.com/nodejs/node/pull/2289)
* [[`3545e236fc`](https://github.com/nodejs/node/commit/3545e236fc)] - **test**: reduce timeouts in test-net-keepalive (Brendan Ashworth) [#2429](https://github.com/nodejs/node/pull/2429)
* [[`b60e690023`](https://github.com/nodejs/node/commit/b60e690023)] - **test**: improve test-net-server-pause-on-connect (Brendan Ashworth) [#2429](https://github.com/nodejs/node/pull/2429)
* [[`11d1b8fcaf`](https://github.com/nodejs/node/commit/11d1b8fcaf)] - **test**: improve test-net-pingpong (Brendan Ashworth) [#2429](https://github.com/nodejs/node/pull/2429)
* [[`5fef5c6562`](https://github.com/nodejs/node/commit/5fef5c6562)] - **(SEMVER-MINOR)** **tls**: add --tls-cipher-list command line switch (James M Snell) [#2412](https://github.com/nodejs/node/pull/2412)
* [[`d9b70f9cbf`](https://github.com/nodejs/node/commit/d9b70f9cbf)] - **tls**: handle empty cert in checkServerIndentity (Mike Atkins) [#2343](https://github.com/nodejs/node/pull/2343)
* [[`4f8e34c202`](https://github.com/nodejs/node/commit/4f8e34c202)] - **tools**: add license boilerplate to check-imports.sh (James M Snell) [#2386](https://github.com/nodejs/node/pull/2386)
* [[`b76b9197f9`](https://github.com/nodejs/node/commit/b76b9197f9)] - **tools**: enable space-after-keywords in eslint (Brendan Ashworth)
* [[`64a8f30a70`](https://github.com/nodejs/node/commit/64a8f30a70)] - **tools**: fix anchors in generated documents (Sakthipriyan Vairamani) [#2491](https://github.com/nodejs/node/pull/2491)
* [[`22e344ea10`](https://github.com/nodejs/node/commit/22e344ea10)] - **win**: fix custom actions for WiX older than 3.9 (João Reis) [#2365](https://github.com/nodejs/node/pull/2365)
* [[`b5bd3ebfc8`](https://github.com/nodejs/node/commit/b5bd3ebfc8)] - **win**: fix custom actions on Visual Studio != 2013 (Julien Gilli) [#2365](https://github.com/nodejs/node/pull/2365)

## 2015-08-18, Version 3.1.0, @Fishrock123

### Notable changes

* **buffer**: Fixed a couple large memory leaks (Ben Noordhuis) [#2352](https://github.com/nodejs/node/pull/2352).
* **crypto**:
  - Fixed a couple of minor memory leaks (Karl Skomski) [#2375](https://github.com/nodejs/node/pull/2375).
  - Signing now checks for OpenSSL errors (P.S.V.R) [#2342](https://github.com/nodejs/node/pull/2342). **Note that this may expose previously hidden errors in user code.**
* **intl**: Intl support using small-icu is now enabled by default in builds (Steven R. Loomis) [#2264](https://github.com/nodejs/node/pull/2264).
  - [`String#normalize()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/normalize) can now be used for unicode normalization.
  - The [`Intl`](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Intl) object and various `String` and `Number` methods are present, but only support the English locale.
  - For support of all locales, node must be built with [full-icu](https://github.com/nodejs/node#build-with-full-icu-support-all-locales-supported-by-icu).
* **tls**: Fixed tls throughput being much lower after an incorrect merge (Fedor Indutny) [#2381](https://github.com/nodejs/node/pull/2381).
* **tools**: The v8 tick processor now comes bundled with node (Matt Loring) [#2090](https://github.com/nodejs/node/pull/2090).
  - This can be used by producing performance profiling output by running node with `--perf`, then running your appropriate platform's script on the output as found in [tools/v8-prof](https://github.com/nodejs/node/tree/master/tools/v8-prof).
* **util**: `util.inspect(obj)` now prints the constructor name of the object if there is one (Christopher Monsanto) [#1935](https://github.com/nodejs/io.js/pull/1935).

### Known issues

See https://github.com/nodejs/io.js/labels/confirmed-bug for complete and current list of known issues.

* Some problems with unreferenced timers running during `beforeExit` are still to be resolved. See [#1264](https://github.com/nodejs/io.js/issues/1264).
* Surrogate pair in REPL can freeze terminal. [#690](https://github.com/nodejs/io.js/issues/690)
* `process.send()` is not synchronous as the docs suggest, a regression introduced in 1.0.2, see [#760](https://github.com/nodejs/io.js/issues/760).
* Calling `dns.setServers()` while a DNS query is in progress can cause the process to crash on a failed assertion. [#894](https://github.com/nodejs/io.js/issues/894)
* `url.resolve` may transfer the auth portion of the url when resolving between two full hosts, see [#1435](https://github.com/nodejs/io.js/issues/1435).

### Commits

* [[`3645dc62ed`](https://github.com/nodejs/node/commit/3645dc62ed)] - **build**: work around VS2015 issue in ICU <56 (Steven R. Loomis) [#2283](https://github.com/nodejs/node/pull/2283)
* [[`1f12e03266`](https://github.com/nodejs/node/commit/1f12e03266)] - **(SEMVER-MINOR)** **build**: intl: converge from joyent/node (Steven R. Loomis) [#2264](https://github.com/nodejs/node/pull/2264)
* [[`071640abdd`](https://github.com/nodejs/node/commit/071640abdd)] - **build**: Intl: bump ICU4C from 54 to 55 (Steven R. Loomis) [#2293](https://github.com/nodejs/node/pull/2293)
* [[`07a88b0c8b`](https://github.com/nodejs/node/commit/07a88b0c8b)] - **build**: update manifest to include Windows 10 (Lucien Greathouse) [#2332](https://github.com/nodejs/io.js/pull/2332)
* [[`0bb099f444`](https://github.com/nodejs/node/commit/0bb099f444)] - **build**: expand ~ in install prefix early (Ben Noordhuis) [#2307](https://github.com/nodejs/io.js/pull/2307)
* [[`7fe6dd8f5d`](https://github.com/nodejs/node/commit/7fe6dd8f5d)] - **crypto**: check for OpenSSL errors when signing (P.S.V.R) [#2342](https://github.com/nodejs/node/pull/2342)
* [[`605f6ee904`](https://github.com/nodejs/node/commit/605f6ee904)] - **crypto**: fix memory leak in PBKDF2Request (Karl Skomski) [#2375](https://github.com/nodejs/node/pull/2375)
* [[`ba6eb8af12`](https://github.com/nodejs/node/commit/ba6eb8af12)] - **crypto**: fix memory leak in ECDH::SetPrivateKey (Karl Skomski) [#2375](https://github.com/nodejs/node/pull/2375)
* [[`6a16368611`](https://github.com/nodejs/node/commit/6a16368611)] - **crypto**: fix memory leak in PublicKeyCipher::Cipher (Karl Skomski) [#2375](https://github.com/nodejs/node/pull/2375)
* [[`a760a87803`](https://github.com/nodejs/node/commit/a760a87803)] - **crypto**: fix memory leak in SafeX509ExtPrint (Karl Skomski) [#2375](https://github.com/nodejs/node/pull/2375)
* [[`f45487cd6e`](https://github.com/nodejs/node/commit/f45487cd6e)] - **crypto**: fix memory leak in SetDHParam (Karl Skomski) [#2375](https://github.com/nodejs/node/pull/2375)
* [[`2ff183dd86`](https://github.com/nodejs/node/commit/2ff183dd86)] - **doc**: Update FIPS instructions in README.md (Michael Dawson) [#2278](https://github.com/nodejs/node/pull/2278)
* [[`6483bc2e8f`](https://github.com/nodejs/node/commit/6483bc2e8f)] - **doc**: clarify options for fs.watchFile() (Rich Trott) [#2425](https://github.com/nodejs/node/pull/2425)
* [[`e76822f454`](https://github.com/nodejs/node/commit/e76822f454)] - **doc**: multiple documentation updates cherry picked from v0.12 (James M Snell) [#2302](https://github.com/nodejs/io.js/pull/2302)
* [[`1738c9680b`](https://github.com/nodejs/node/commit/1738c9680b)] - **net**: ensure Socket reported address is current (Ryan Graham) [#2095](https://github.com/nodejs/io.js/pull/2095)
* [[`844d3f0e3e`](https://github.com/nodejs/node/commit/844d3f0e3e)] - **path**: use '===' instead of '==' for comparison (Sam Stites) [#2388](https://github.com/nodejs/node/pull/2388)
* [[`7118b8a882`](https://github.com/nodejs/node/commit/7118b8a882)] - **path**: remove dead code in favor of unit tests (Nathan Woltman) [#2282](https://github.com/nodejs/io.js/pull/2282)
* [[`34f2cfa806`](https://github.com/nodejs/node/commit/34f2cfa806)] - **src**: better error message on failed Buffer malloc (Karl Skomski) [#2422](https://github.com/nodejs/node/pull/2422)
* [[`b196c1da3c`](https://github.com/nodejs/node/commit/b196c1da3c)] - **src**: fix memory leak in DLOpen (Karl Skomski) [#2375](https://github.com/nodejs/node/pull/2375)
* [[`d1307b2995`](https://github.com/nodejs/node/commit/d1307b2995)] - **src**: don't use fopen() in require() fast path (Ben Noordhuis) [#2377](https://github.com/nodejs/node/pull/2377)
* [[`455ec570d1`](https://github.com/nodejs/node/commit/455ec570d1)] - **src**: rename Buffer::Use() to Buffer::New() (Ben Noordhuis) [#2352](https://github.com/nodejs/node/pull/2352)
* [[`fd63e1ce2b`](https://github.com/nodejs/node/commit/fd63e1ce2b)] - **src**: introduce internal Buffer::Copy() function (Ben Noordhuis) [#2352](https://github.com/nodejs/node/pull/2352)
* [[`5586ceca13`](https://github.com/nodejs/node/commit/5586ceca13)] - **src**: move internal functions out of node_buffer.h (Ben Noordhuis) [#2352](https://github.com/nodejs/node/pull/2352)
* [[`bff9bcddb6`](https://github.com/nodejs/node/commit/bff9bcddb6)] - **src**: plug memory leaks (Ben Noordhuis) [#2352](https://github.com/nodejs/node/pull/2352)
* [[`ccf12df4f3`](https://github.com/nodejs/node/commit/ccf12df4f3)] - **(SEMVER-MINOR)** **src**: add total_available_size to v8 statistics (Roman Klauke) [#2348](https://github.com/nodejs/io.js/pull/2348)
* [[`194eeb841b`](https://github.com/nodejs/node/commit/194eeb841b)] - **test**: drop Isolate::GetCurrent() from addon tests (Ben Noordhuis) [#2427](https://github.com/nodejs/node/pull/2427)
* [[`46cdb2f6e2`](https://github.com/nodejs/node/commit/46cdb2f6e2)] - **test**: lint addon tests (Ben Noordhuis) [#2427](https://github.com/nodejs/node/pull/2427)
* [[`850c794882`](https://github.com/nodejs/node/commit/850c794882)] - **test**: refactor test-fs-watchfile.js (Rich Trott) [#2393](https://github.com/nodejs/node/pull/2393)
* [[`a3160c0a33`](https://github.com/nodejs/node/commit/a3160c0a33)] - **test**: correct spelling of 'childProcess' (muddletoes) [#2389](https://github.com/nodejs/node/pull/2389)
* [[`e51f90d747`](https://github.com/nodejs/node/commit/e51f90d747)] - **test**: option to run a subset of tests (João Reis) [#2260](https://github.com/nodejs/io.js/pull/2260)
* [[`cc46d3bca3`](https://github.com/nodejs/node/commit/cc46d3bca3)] - **test**: clarify dropMembership() call (Rich Trott) [#2062](https://github.com/nodejs/io.js/pull/2062)
* [[`0ee4df9c7a`](https://github.com/nodejs/node/commit/0ee4df9c7a)] - **test**: make listen-fd-cluster/server more robust (Sam Roberts) [#1944](https://github.com/nodejs/io.js/pull/1944)
* [[`cf9ba81398`](https://github.com/nodejs/node/commit/cf9ba81398)] - **test**: address timing issues in simple http tests (Gireesh Punathil) [#2294](https://github.com/nodejs/io.js/pull/2294)
* [[`cbb75c4f86`](https://github.com/nodejs/node/commit/cbb75c4f86)] - **tls**: fix throughput issues after incorrect merge (Fedor Indutny) [#2381](https://github.com/nodejs/node/pull/2381)
* [[`94b765f409`](https://github.com/nodejs/node/commit/94b765f409)] - **tls**: fix check for reused session (Fedor Indutny) [#2312](https://github.com/nodejs/io.js/pull/2312)
* [[`e83a41ad65`](https://github.com/nodejs/node/commit/e83a41ad65)] - **tls**: introduce internal `onticketkeycallback` (Fedor Indutny) [#2312](https://github.com/nodejs/io.js/pull/2312)
* [[`fb0f5d733f`](https://github.com/nodejs/node/commit/fb0f5d733f)] - **(SEMVER-MINOR)** **tools**: run the tick processor without building v8 (Matt Loring) [#2090](https://github.com/nodejs/node/pull/2090)
* [[`7606bdb897`](https://github.com/nodejs/node/commit/7606bdb897)] - **(SEMVER-MINOR)** **util**: display constructor when inspecting objects (Christopher Monsanto) [#1935](https://github.com/nodejs/io.js/pull/1935)

## 2015-08-04, Version 3.0.0, @rvagg

### Notable changes

* **buffer**:
  - Due to changes in V8, it has been necessary to reimplement `Buffer` on top of V8's `Uint8Array`. Every effort has been made to minimize the performance impact, however `Buffer` instantiation is measurably slower. Access operations may be faster in some circumstances but the exact performance profile and difference over previous versions will depend on how `Buffer` is used within applications. (Trevor Norris) [#1825](https://github.com/nodejs/node/pull/1825).
  - `Buffer` can now take `ArrayBuffer`s as a constructor argument (Trevor Norris) [#2002](https://github.com/nodejs/node/pull/2002).
  - When a single buffer is passed to `Buffer.concat()`, a new, copied `Buffer` object will be returned; previous behavior was to return the original `Buffer` object (Sakthipriyan Vairamani) [#1937](https://github.com/nodejs/node/pull/1937).
* **build**: PPC support has been added to core to allow compiling on pLinux BE and LE (AIX support coming soon) (Michael Dawson) [#2124](https://github.com/nodejs/node/pull/2124).
* **dgram**: If an error occurs within `socket.send()` and a callback has been provided, the error is only passed as the first argument to the callback and not emitted on the `socket` object; previous behavior was to do both (Matteo Collina & Chris Dickinson) [#1796](https://github.com/nodejs/node/pull/1796)
* **freelist**: Deprecate the undocumented `freelist` core module (Sakthipriyan Vairamani) [#2176](https://github.com/nodejs/node/pull/2176).
* **http**:
  - Status codes now all use the official [IANA names](http://www.iana.org/assignments/http-status-codes) as per [RFC7231](https://tools.ietf.org/html/rfc7231), e.g. `http.STATUS_CODES[414]` now returns `'URI Too Long'` rather than `'Request-URI Too Large'` (jomo) [#1470](https://github.com/nodejs/node/pull/1470).
  - Calling .getName() on an HTTP agent no longer returns a trailing colon, HTTPS agents will no longer return an extra colon near the middle of the string (Brendan Ashworth) [#1617](https://github.com/nodejs/node/pull/1617).
* **node**:
  - `NODE_MODULE_VERSION` has been bumped to `45` to reflect the break in ABI (Rod Vagg) [#2096](https://github.com/nodejs/node/pull/2096).
  - Introduce a new `process.release` object that contains a `name` property set to `'io.js'` and `sourceUrl`, `headersUrl` and `libUrl` (Windows only) properties containing URLs for the relevant resources; this is intended to be used by node-gyp (Rod Vagg) [#2154](https://github.com/nodejs/node/pull/2154).
  - The version of node-gyp bundled with io.js now downloads and uses a tarball of header files from iojs.org rather than the full source for compiling native add-ons; it is hoped this is a temporary floating patch and the change will be upstreamed to node-gyp soon (Rod Vagg) [#2066](https://github.com/nodejs/node/pull/2066).
* **repl**: Persistent history is now enabled by default. The history file is located at ~/.node_repl_history, which can be overridden by the new environment variable `NODE_REPL_HISTORY`. This deprecates the previous `NODE_REPL_HISTORY_FILE` variable. Additionally, the format of the file has been changed to plain text to better handle file corruption. (Jeremiah Senkpiel) [#2224](https://github.com/nodejs/node/pull/2224).
* **smalloc**: The `smalloc` module has been removed as it is no longer possible to provide the API due to changes in V8 (Ben Noordhuis) [#2022](https://github.com/nodejs/node/pull/2022).
* **tls**: Add `server.getTicketKeys()` and `server.setTicketKeys()` methods for [TLS session key](https://www.ietf.org/rfc/rfc5077.txt) rotation (Fedor Indutny) [#2227](https://github.com/nodejs/node/pull/2227).
* **v8**: Upgraded to 4.4.63.26
  - ES6: Enabled [computed property names](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer#Computed_property_names)
  - ES6: `Array` can now be subclassed in strict mode
  - ES6: Implement [rest parameters](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Functions/rest_parameters) in staging, use the `--harmony-rest-parameters` command line flag
  - ES6: Implement the [spread operator](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator) in staging, use the `--harmony-spreadcalls` command line flag
  - Removed `SetIndexedPropertiesToExternalArrayData` and related APIs, forcing a shift to `Buffer` to be reimplemented based on `Uint8Array`
  - Introduction of `Maybe` and `MaybeLocal` C++ API for objects which _may_ or _may not_ have a value.
  - Added support for PPC

See also https://github.com/nodejs/node/wiki/Breaking-Changes#300-from-2x for a summary of the breaking changes (SEMVER-MAJOR).

### Known issues

See https://github.com/nodejs/node/labels/confirmed-bug for complete and current list of known issues.

* Some problems with unreferenced timers running during `beforeExit` are still to be resolved. See [#1264](https://github.com/nodejs/node/issues/1264).
* Surrogate pair in REPL can freeze terminal. [#690](https://github.com/nodejs/node/issues/690)
* `process.send()` is not synchronous as the docs suggest, a regression introduced in 1.0.2, see [#760](https://github.com/nodejs/node/issues/760).
* Calling `dns.setServers()` while a DNS query is in progress can cause the process to crash on a failed assertion. [#894](https://github.com/nodejs/node/issues/894)
* `url.resolve` may transfer the auth portion of the url when resolving between two full hosts, see [#1435](https://github.com/nodejs/node/issues/1435).

### Commits

* [[`60a974d200`](https://github.com/nodejs/node/commit/60a974d200)] - **buffer**: fix missing null/undefined check (Trevor Norris) [#2195](https://github.com/nodejs/node/pull/2195)
* [[`e6ab2d92bc`](https://github.com/nodejs/node/commit/e6ab2d92bc)] - **buffer**: fix not return on error (Trevor Norris) [#2225](https://github.com/nodejs/node/pull/2225)
* [[`1057d1186b`](https://github.com/nodejs/node/commit/1057d1186b)] - **buffer**: rename internal/buffer_new.js to buffer.js (Ben Noordhuis) [#2022](https://github.com/nodejs/node/pull/2022)
* [[`4643b8b667`](https://github.com/nodejs/node/commit/4643b8b667)] - **(SEMVER-MINOR)** **buffer**: allow ArrayBuffer as Buffer argument (Trevor Norris) [#2002](https://github.com/nodejs/node/pull/2002)
* [[`e5ada116cd`](https://github.com/nodejs/node/commit/e5ada116cd)] - **buffer**: minor cleanup from rebase (Trevor Norris) [#2003](https://github.com/nodejs/node/pull/2003)
* [[`b625ab4242`](https://github.com/nodejs/node/commit/b625ab4242)] - **buffer**: fix usage of kMaxLength (Trevor Norris) [#2003](https://github.com/nodejs/node/pull/2003)
* [[`eea66e2a7b`](https://github.com/nodejs/node/commit/eea66e2a7b)] - **(SEMVER-MAJOR)** **buffer**: fix case of one buffer passed to concat (Sakthipriyan Vairamani) [#1937](https://github.com/nodejs/node/pull/1937)
* [[`8664084166`](https://github.com/nodejs/node/commit/8664084166)] - **buffer**: make additional changes to native API (Trevor Norris) [#1825](https://github.com/nodejs/node/pull/1825)
* [[`36f78f4c1c`](https://github.com/nodejs/node/commit/36f78f4c1c)] - **buffer**: switch API to return MaybeLocal<T> (Trevor Norris) [#1825](https://github.com/nodejs/node/pull/1825)
* [[`571ec13841`](https://github.com/nodejs/node/commit/571ec13841)] - **buffer**: switch to using Maybe<T> API (Trevor Norris) [#1825](https://github.com/nodejs/node/pull/1825)
* [[`d75f5c8d0e`](https://github.com/nodejs/node/commit/d75f5c8d0e)] - **buffer**: finish implementing FreeCallback (Trevor Norris) [#1825](https://github.com/nodejs/node/pull/1825)
* [[`63da0dfd3a`](https://github.com/nodejs/node/commit/63da0dfd3a)] - **buffer**: implement Uint8Array backed Buffer (Trevor Norris) [#1825](https://github.com/nodejs/node/pull/1825)
* [[`23be6ca189`](https://github.com/nodejs/node/commit/23be6ca189)] - **buffer**: allow ARGS_THIS to accept a name (Trevor Norris) [#1825](https://github.com/nodejs/node/pull/1825)
* [[`971de5e417`](https://github.com/nodejs/node/commit/971de5e417)] - **build**: prepare Windows installer for i18n support (Frederic Hemberger) [#2247](https://github.com/nodejs/node/pull/2247)
* [[`2ba8b23661`](https://github.com/nodejs/node/commit/2ba8b23661)] - **build**: add 'x86' option back in to configure (Rod Vagg) [#2233](https://github.com/nodejs/node/pull/2233)
* [[`b4226e797a`](https://github.com/nodejs/node/commit/b4226e797a)] - **build**: first set of updates to enable PPC support (Michael Dawson) [#2124](https://github.com/nodejs/node/pull/2124)
* [[`24dd016deb`](https://github.com/nodejs/node/commit/24dd016deb)] - **build**: produce symbol map files on windows (Ali Ijaz Sheikh) [#2243](https://github.com/nodejs/node/pull/2243)
* [[`423d8944ce`](https://github.com/nodejs/node/commit/423d8944ce)] - **cluster**: do not unconditionally set --debug-port (cjihrig) [#1949](https://github.com/nodejs/node/pull/1949)
* [[`fa98b97171`](https://github.com/nodejs/node/commit/fa98b97171)] - **cluster**: add handle ref/unref stubs in rr mode (Ben Noordhuis) [#2274](https://github.com/nodejs/node/pull/2274)
* [[`944f68046c`](https://github.com/nodejs/node/commit/944f68046c)] - **crypto**: remove kMaxLength on randomBytes() (Trevor Norris) [#1825](https://github.com/nodejs/node/pull/1825)
* [[`3d3c687012`](https://github.com/nodejs/node/commit/3d3c687012)] - **deps**: update V8 to 4.4.63.26 (Michaël Zasso) [#2220](https://github.com/nodejs/node/pull/2220)
* [[`3aad4fa89a`](https://github.com/nodejs/node/commit/3aad4fa89a)] - **deps**: upgrade v8 to 4.4.63.12 (Ben Noordhuis) [#2092](https://github.com/nodejs/node/pull/2092)
* [[`70d1f32f56`](https://github.com/nodejs/node/commit/70d1f32f56)] - **(SEMVER-MAJOR)** **deps**: update v8 to 4.4.63.9 (Ben Noordhuis) [#2022](https://github.com/nodejs/node/pull/2022)
* [[`deb7ee93a7`](https://github.com/nodejs/node/commit/deb7ee93a7)] - **deps**: backport 7b24219346 from v8 upstream (Rod Vagg) [#1805](https://github.com/nodejs/node/pull/1805)
* [[`d58e780504`](https://github.com/nodejs/node/commit/d58e780504)] - **(SEMVER-MAJOR)** **deps**: update v8 to 4.3.61.21 (Chris Dickinson) [iojs/io.js#1632](https://github.com/iojs/io.js/pull/1632)
* [[`2a63cf612b`](https://github.com/nodejs/node/commit/2a63cf612b)] - **deps**: make node-gyp work with io.js (cjihrig) [iojs/io.js#990](https://github.com/iojs/io.js/pull/990)
* [[`bf63266460`](https://github.com/nodejs/node/commit/bf63266460)] - **deps**: upgrade to npm 2.13.3 (Kat Marchán) [#2284](https://github.com/nodejs/node/pull/2284)
* [[`ef2c8cd4ec`](https://github.com/nodejs/node/commit/ef2c8cd4ec)] - **(SEMVER-MAJOR)** **dgram**: make send cb act as "error" event handler (Matteo Collina) [#1796](https://github.com/nodejs/node/pull/1796)
* [[`3da057fef6`](https://github.com/nodejs/node/commit/3da057fef6)] - **(SEMVER-MAJOR)** **dgram**: make send cb act as "error" event handler (Chris Dickinson) [#1796](https://github.com/nodejs/node/pull/1796)
* [[`df1994fe53`](https://github.com/nodejs/node/commit/df1994fe53)] - ***Revert*** "**dns**: remove AI_V4MAPPED hint flag on FreeBSD" (cjihrig) [iojs/io.js#1555](https://github.com/iojs/io.js/pull/1555)
* [[`1721968b22`](https://github.com/nodejs/node/commit/1721968b22)] - **doc**: document repl persistent history changes (Jeremiah Senkpiel) [#2224](https://github.com/nodejs/node/pull/2224)
* [[`d12df7f159`](https://github.com/nodejs/node/commit/d12df7f159)] - **doc**: update v8 flags in man page (Michaël Zasso) [iojs/io.js#1701](https://github.com/iojs/io.js/pull/1701)
* [[`d168d01b04`](https://github.com/nodejs/node/commit/d168d01b04)] - **doc**: properly inheriting from EventEmitter (Sakthipriyan Vairamani) [#2168](https://github.com/nodejs/node/pull/2168)
* [[`500f2538cc`](https://github.com/nodejs/node/commit/500f2538cc)] - **doc**: a listener, not "an" listener (Sam Roberts) [#1025](https://github.com/nodejs/node/pull/1025)
* [[`54627a919d`](https://github.com/nodejs/node/commit/54627a919d)] - **doc**: server close event does not have an argument (Sam Roberts) [#1025](https://github.com/nodejs/node/pull/1025)
* [[`ed85c95a9c`](https://github.com/nodejs/node/commit/ed85c95a9c)] - **doc,test**: documents behaviour of non-existent file (Sakthipriyan Vairamani) [#2169](https://github.com/nodejs/node/pull/2169)
* [[`2965442308`](https://github.com/nodejs/node/commit/2965442308)] - **(SEMVER-MAJOR)** **http**: fix agent.getName() and add tests (Brendan Ashworth) [#1617](https://github.com/nodejs/node/pull/1617)
* [[`2d9456e3e6`](https://github.com/nodejs/node/commit/2d9456e3e6)] - **(SEMVER-MAJOR)** **http**: use official IANA Status Codes (jomo) [#1470](https://github.com/nodejs/node/pull/1470)
* [[`11e4249227`](https://github.com/nodejs/node/commit/11e4249227)] - **(SEMVER-MAJOR)** **http_server**: `prefinish` vs `finish` (Fedor Indutny) [#1411](https://github.com/nodejs/node/pull/1411)
* [[`9bc2e26720`](https://github.com/nodejs/node/commit/9bc2e26720)] - **net**: do not set V4MAPPED on FreeBSD (Julien Gilli) [iojs/io.js#1555](https://github.com/iojs/io.js/pull/1555)
* [[`ba9ccf227e`](https://github.com/nodejs/node/commit/ba9ccf227e)] - **node**: remove redundant --use-old-buffer (Rod Vagg) [#2275](https://github.com/nodejs/node/pull/2275)
* [[`ef65321083`](https://github.com/nodejs/node/commit/ef65321083)] - **(SEMVER-MAJOR)** **node**: do not override `message`/`stack` of error (Fedor Indutny) [#2108](https://github.com/nodejs/node/pull/2108)
* [[`9f727f5e03`](https://github.com/nodejs/node/commit/9f727f5e03)] - **node-gyp**: detect RC build with x.y.z-rc.n format (Rod Vagg) [#2171](https://github.com/nodejs/node/pull/2171)
* [[`e52f963632`](https://github.com/nodejs/node/commit/e52f963632)] - **node-gyp**: download header tarball for compile (Rod Vagg) [#2066](https://github.com/nodejs/node/pull/2066)
* [[`902c9ca51d`](https://github.com/nodejs/node/commit/902c9ca51d)] - **node-gyp**: make aware of nightly, next-nightly & rc (Rod Vagg) [#2066](https://github.com/nodejs/node/pull/2066)
* [[`4cffaa3f55`](https://github.com/nodejs/node/commit/4cffaa3f55)] - **(SEMVER-MINOR)** **readline**: allow tabs in input (Rich Trott) [#1761](https://github.com/nodejs/node/pull/1761)
* [[`ed6c249104`](https://github.com/nodejs/node/commit/ed6c249104)] - **(SEMVER-MAJOR)** **repl**: persist history in plain text (Jeremiah Senkpiel) [#2224](https://github.com/nodejs/node/pull/2224)
* [[`f7d5e4c618`](https://github.com/nodejs/node/commit/f7d5e4c618)] - **(SEMVER-MINOR)** **repl**: default persistence to ~/.node_repl_history (Jeremiah Senkpiel) [#2224](https://github.com/nodejs/node/pull/2224)
* [[`ea05e760cd`](https://github.com/nodejs/node/commit/ea05e760cd)] - **repl**: don't clobber RegExp.$ properties (Sakthipriyan Vairamani) [#2137](https://github.com/nodejs/node/pull/2137)
* [[`d20093246b`](https://github.com/nodejs/node/commit/d20093246b)] - **src**: disable vector ICs on arm (Michaël Zasso) [#2220](https://github.com/nodejs/node/pull/2220)
* [[`04fd4fad46`](https://github.com/nodejs/node/commit/04fd4fad46)] - **(SEMVER-MINOR)** **src**: introduce process.release object (Rod Vagg) [#2154](https://github.com/nodejs/node/pull/2154)
* [[`9d34bd1147`](https://github.com/nodejs/node/commit/9d34bd1147)] - **src**: increment NODE_MODULE_VERSION to 45 (Rod Vagg) [#2096](https://github.com/nodejs/node/pull/2096)
* [[`ceee8d2807`](https://github.com/nodejs/node/commit/ceee8d2807)] - **test**: add tests for persistent repl history (Jeremiah Senkpiel) [#2224](https://github.com/nodejs/node/pull/2224)
* [[`8e1a8ffe24`](https://github.com/nodejs/node/commit/8e1a8ffe24)] - **test**: remove two obsolete pummel tests (Ben Noordhuis) [#2022](https://github.com/nodejs/node/pull/2022)
* [[`ae731ec0fa`](https://github.com/nodejs/node/commit/ae731ec0fa)] - **test**: don't use arguments.callee (Ben Noordhuis) [#2022](https://github.com/nodejs/node/pull/2022)
* [[`21d31c08e7`](https://github.com/nodejs/node/commit/21d31c08e7)] - **test**: remove obsolete harmony flags (Chris Dickinson)
* [[`64cf71195c`](https://github.com/nodejs/node/commit/64cf71195c)] - **test**: change the hostname to an invalid name (Sakthipriyan Vairamani) [#2287](https://github.co…

@psnider psnider referenced this pull request in senecajs/seneca Apr 20, 2016

Open

leak from plugin when using toString on large data #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment