Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 94c87fe #27792

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@targos
Copy link
Member

commented May 21, 2019

Original commit message:

[ic] Fix handling of +0/-0 when constant field tracking is enabled

... and ensure that runtime behaviour is in sync with the IC code.

Bug: chromium:950747, v8:9113
Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60768}

Refs: v8/v8@94c87fe

Fixes: #27784

deps: V8: cherry-pick 94c87fe
Original commit message:

    [ic] Fix handling of +0/-0 when constant field tracking is enabled

    ... and ensure that runtime behaviour is in sync with the IC code.

    Bug: chromium:950747, v8:9113
    Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60768}

Refs: v8/v8@94c87fe
@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

commented May 21, 2019

I would like to fast track this PR to get it into a patch release tomorrow.

Please +1 if you agree.

@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@addaleax @devsnek @targos @bnoordhuis @nodejs/v8-update are you fine to fast track this for the patch release today? This seems like a pretty bad bug to me that should be fixed soon.

@BridgeAR BridgeAR referenced this pull request May 22, 2019

Merged

v12.3.1 proposal #27814

@BridgeAR BridgeAR added the fast-track label May 22, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Landed in f2fe1e5 🎉

@BridgeAR BridgeAR closed this May 22, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request May 22, 2019

deps: V8: cherry-pick 94c87fe
Original commit message:

    [ic] Fix handling of +0/-0 when constant field tracking is enabled

    ... and ensure that runtime behaviour is in sync with the IC code.

    Bug: chromium:950747, v8:9113
    Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60768}

PR-URL: nodejs#27792
Fixes: nodejs#27784
Refs: v8/v8@94c87fe
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>

@targos targos deleted the targos:fix-27784 branch May 22, 2019

@targos

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

BridgeAR added a commit that referenced this pull request May 22, 2019

deps: V8: cherry-pick 94c87fe
Original commit message:

    [ic] Fix handling of +0/-0 when constant field tracking is enabled

    ... and ensure that runtime behaviour is in sync with the IC code.

    Bug: chromium:950747, v8:9113
    Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60768}

PR-URL: #27792
Fixes: #27784
Refs: v8/v8@94c87fe
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@targos those already failed before. There is some issue around the benchmark test currently.

BridgeAR added a commit that referenced this pull request May 22, 2019

2019-05-22, Version v12.3.1 (Current)
Notable changes

* deps:
  * Fix handling of +0/-0 when constant field tracking is enabled
    (Michaël Zasso) #27792
  * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
    #27718
* src:
  * Fix v12.3.0 regression that prevents native addons from compiling
    #27804

PR-URL: #27814

BridgeAR added a commit to BridgeAR/node that referenced this pull request May 22, 2019

2019-05-22, Version v12.3.1 (Current)
Notable changes

* deps:
  * Fix handling of +0/-0 when constant field tracking is enabled
    (Michaël Zasso) nodejs#27792
  * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
    nodejs#27718
* src:
  * Fix v12.3.0 regression that prevents native addons from compiling
    nodejs#27804

PR-URL: nodejs#27814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.