Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix link from bootstrap README to BUILDING #28504

Closed
wants to merge 1 commit into from

Conversation

@rvagg
Copy link
Member

commented Jul 2, 2019

I messed up #28465 and only noticed after it landed. tools/bootstrap/README.md points to README.md when it should point to BUILDING.md.

Here's the rendered version if you want to confirm I have it right this time.

@rvagg rvagg force-pushed the rvagg:rvagg/bootstrap-link branch from 4323cba to e6f64b9 Jul 2, 2019

@Trott
Trott approved these changes Jul 2, 2019
@trivikr
trivikr approved these changes Jul 2, 2019
@trivikr

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Like this comment to fast track this changes

@trivikr trivikr added the fast-track label Jul 2, 2019

@trivikr

This comment has been minimized.

@trivikr trivikr added the author ready label Jul 2, 2019

@ZYSzys
ZYSzys approved these changes Jul 2, 2019
@lpinca
lpinca approved these changes Jul 2, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Landed in 3ab457e

@Trott Trott closed this Jul 2, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 2, 2019
doc: fix link from bootstrap README to BUILDING
PR-URL: nodejs#28504
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Jul 20, 2019
doc: fix link from bootstrap README to BUILDING
PR-URL: #28504
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.