http2: Abstracting stream and session-related logic #33928

rickyes · 2020-06-17T13:28:55Z

Take session and strems-related logic out of core.js for easier coding (every time I try to make changes to the logic for http2 I see that the file is too big and I can't do anything about it).

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

lundibundi · 2020-06-17T18:54:00Z

@nodejs/http2

rickyes · 2020-06-18T05:24:12Z

The changes didn't have much of an impact on performance.

 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=100                  -10.33 %     ±19.74% ±26.27% ±34.19%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=1000                   5.60 %     ±14.68% ±19.54% ±25.43%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=5000                  -6.90 %     ±16.81% ±22.37% ±29.11%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=100                  -1.95 %     ±20.92% ±27.85% ±36.25%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=1000                  5.60 %     ±21.50% ±28.61% ±37.25%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=5000                -13.30 %     ±16.87% ±22.45% ±29.22%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=100                 -7.17 %     ±16.38% ±21.80% ±28.37%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=1000                 8.95 %     ±19.87% ±26.43% ±34.40%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=5000                 9.93 %     ±16.70% ±22.23% ±28.96%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=100                  -6.07 %     ±16.02% ±21.33% ±27.79%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=1000                 23.04 %     ±23.32% ±31.02% ±40.38%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=5000                 -5.92 %     ±18.64% ±24.81% ±32.29%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=100                 -7.46 %     ±18.66% ±24.84% ±32.37%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=1000                -7.77 %     ±11.68% ±15.54% ±20.24%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=5000                 6.48 %     ±13.65% ±18.18% ±23.70%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=100                  -0.85 %     ±16.67% ±22.20% ±28.93%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=1000                  5.83 %     ±12.05% ±16.03% ±20.87%
 http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=5000                 -2.93 %     ±13.95% ±18.59% ±24.25%

 http2/headers.js nheaders=0 n=1000                                                                                      0.22 %      ±0.65%  ±0.87%  ±1.14%
 http2/headers.js nheaders=10 n=1000                                                                             **      0.97 %      ±0.71%  ±0.94%  ±1.23%
 http2/headers.js nheaders=100 n=1000                                                                           ***      1.75 %      ±0.87%  ±1.16%  ±1.53%
 http2/headers.js nheaders=1000 n=1000                                                                                   1.37 %      ±1.45%  ±1.95%  ±2.58%

 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=100                   -4.08 %     ±24.08% ±32.04% ±41.70%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=1000                   3.24 %     ±17.99% ±23.95% ±31.20%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=5000                  -5.44 %     ±21.04% ±28.00% ±36.44%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=100                  10.09 %     ±18.11% ±24.10% ±31.37%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=1000                  0.61 %     ±18.75% ±24.95% ±32.48%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=5000                 10.45 %     ±23.10% ±30.74% ±40.01%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=100                  2.79 %     ±20.53% ±27.32% ±35.56%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=1000               -12.14 %     ±18.36% ±24.43% ±31.82%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=5000                17.30 %     ±27.67% ±36.81% ±47.91%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=100                  -3.85 %     ±20.92% ±27.84% ±36.26%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=1000                  0.88 %     ±18.70% ±24.89% ±32.41%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=5000                  3.24 %     ±20.17% ±26.84% ±34.94%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=100                 -3.56 %     ±19.76% ±26.29% ±34.23%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=1000                -0.86 %     ±19.20% ±25.55% ±33.27%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=5000                10.19 %     ±23.35% ±31.08% ±40.48%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=100                   2.83 %     ±17.89% ±23.81% ±30.99%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=1000                  5.86 %     ±18.16% ±24.16% ±31.45%
 http2/respond-with-fd.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=5000                  8.57 %     ±20.31% ±27.02% ±35.17%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=100                            10.54 %     ±22.44% ±29.85% ±38.86%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=1000                            0.03 %     ±15.41% ±20.50% ±26.69%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=5000                           -2.79 %     ±14.26% ±18.98% ±24.71%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=100                            6.54 %     ±17.99% ±23.94% ±31.16%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=1000                          -9.83 %     ±15.84% ±21.08% ±27.43%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=5000                          -4.28 %     ±14.55% ±19.36% ±25.20%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=100                           2.34 %     ±16.65% ±22.17% ±28.90%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=1000                         20.75 %     ±24.06% ±32.06% ±41.84%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=5000                         -4.99 %     ±17.15% ±22.82% ±29.70%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=100                           -7.36 %     ±21.07% ±28.03% ±36.49%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=1000                          -2.36 %     ±18.50% ±24.62% ±32.06%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=5000                           6.86 %     ±15.42% ±20.60% ±26.96%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=100                           2.60 %     ±22.02% ±29.30% ±38.13%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=1000                         -1.11 %     ±22.71% ±30.22% ±39.35%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=5000                         13.15 %     ±20.09% ±26.75% ±34.85%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=100                           10.55 %     ±19.99% ±26.59% ±34.61%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=1000                         -11.09 %     ±18.40% ±24.49% ±31.89%
 http2/simple.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=5000                          -3.90 %     ±18.22% ±24.25% ±31.56%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=1048576 streams=100                        1.76 %     ±11.61% ±15.46% ±20.14%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=1048576 streams=1000                      -1.95 %     ±16.78% ±22.34% ±29.10%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=1048576 streams=200                 *     26.94 %     ±22.63% ±30.14% ±39.29%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=131072 streams=100                        -5.08 %      ±9.13% ±12.16% ±15.85%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=131072 streams=1000                        5.11 %     ±21.12% ±28.11% ±36.60%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=131072 streams=200                        -3.64 %     ±18.14% ±24.17% ±31.54%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=262144 streams=100                         2.49 %     ±19.91% ±26.52% ±34.56%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=262144 streams=1000                       -9.34 %     ±19.81% ±26.37% ±34.34%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=262144 streams=200                        -7.87 %     ±14.07% ±18.80% ±24.63%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=65536 streams=100                          8.69 %     ±15.07% ±20.08% ±26.20%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=65536 streams=1000                        -0.23 %     ±13.65% ±18.16% ±23.65%
 http2/write.js duration=5 benchmarker='test-double-http2' size=100000 length=65536 streams=200                         -4.87 %     ±13.04% ±17.35% ±22.60%

rickyes · 2020-06-18T14:25:39Z

Maybe /cc @jasnell @addaleax @BridgeAR

mcollina

lgtm

nodejs-github-bot · 2020-06-19T13:29:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31941/

rickyes · 2020-06-19T13:49:53Z

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutssl_x64/20861/testReport/junit/(root)/test/parallel_test_code_cache/

The test-code-cache use case is failing, we need to add internal/http2/session and internal/http2/streams here? ping @joyeecheung @addaleax

node/src/node_native_module.cc

Lines 91 to 99 in 56967af

    
           #if !HAVE_OPENSSL 
        
                 "crypto", 
        
                 "https", 
        
                 "http2", 
        
                 "tls", 
        
                 "_tls_common", 
        
                 "_tls_wrap", 
        
                 "internal/http2/core", 
        
                 "internal/http2/compat",

rickyes · 2020-06-19T15:06:30Z

ping @mcollina @addaleax @jasnell I've made some changes to fix the code-cache. help review, please.

nodejs-github-bot · 2020-06-19T15:31:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31953/
Benchmarks: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/612/

lundibundi · 2020-06-22T08:37:00Z

Not sure if this PR is the culprit but the benchmark above failed (the prev benchmark run for this PR failed with the same error).

19:04:44 ++ ./node-master benchmark/compare.js --old ./node-master --new ./node-pr -- http2
19:04:44 ++ tee output190620-170444.csv
19:04:44 "binary", "filename", "configuration", "rate", "time"
19:04:49 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=100", 3522, 5.25998366
19:04:55 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=100", 2186, 5.219020456
19:05:01 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=100", 2112, 5.223423342
19:05:06 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=100", 2515, 5.221362605
19:05:12 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=100", 2914, 5.244409724
19:05:17 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=100", 3372, 5.197587316
19:05:23 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=1000", 2310, 5.234376489
19:05:28 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=1000", 2298, 5.228407984
19:05:34 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=1000", 2122, 5.208801167
19:05:39 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=1000", 2128, 5.223415788
19:05:44 /w/bnch-comp/node/benchmark/_test-double-benchmarker.js:40
19:05:44     client.on('error', (e) => { throw e; });
19:05:44                                 ^
19:05:44 
19:05:44 Error: connect EADDRNOTAVAIL 127.0.0.1:12346 - Local (127.0.0.1:0)
19:05:44     at internalConnect (net.js:904:16)
19:05:44     at defaultTriggerAsyncIdScope (internal/async_hooks.js:416:12)
19:05:44     at net.js:992:9
19:05:44     at processTicksAndRejections (internal/process/task_queues.js:79:11) {
19:05:44   errno: -99,
19:05:44   code: 'EADDRNOTAVAIL',
19:05:44   syscall: 'connect',
19:05:44   address: '127.0.0.1',
19:05:44   port: 12346
19:05:44 }
19:05:44 Error: test-double-http2 failed with 1.
19:05:44     at ChildProcess.<anonymous> (/w/bnch-comp/node/benchmark/_http-benchmarkers.js:238:16)
19:05:44     at Object.onceWrapper (events.js:421:26)
19:05:44     at ChildProcess.emit (events.js:314:20)
19:05:44     at maybeClose (internal/child_process.js:1051:16)
19:05:44     at Socket.<anonymous> (internal/child_process.js:442:11)
19:05:44     at Socket.emit (events.js:314:20)
19:05:44     at Pipe.<anonymous> (net.js:655:12)
19:05:44 ++ cat output190620-170444.csv
19:05:44 ++ Rscript benchmark/compare.R
19:05:45                                                                                                confidence improvement accuracy (*) (**) (***)
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=100         NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=100          NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=1000         NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=100           NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=1000          NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=100         NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=100          NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=1000         NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=100          NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=1000         NA       NaN %           NA   NA    NA

rickyes · 2020-06-22T10:33:02Z

Not sure if this PR is the culprit but the benchmark above failed (the prev benchmark run for this PR failed with the same error).

19:04:44 ++ ./node-master benchmark/compare.js --old ./node-master --new ./node-pr -- http2
19:04:44 ++ tee output190620-170444.csv
19:04:44 "binary", "filename", "configuration", "rate", "time"
19:04:49 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=100", 3522, 5.25998366
19:04:55 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=100", 2186, 5.219020456
19:05:01 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=100", 2112, 5.223423342
19:05:06 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=100", 2515, 5.221362605
19:05:12 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=100", 2914, 5.244409724
19:05:17 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=100", 3372, 5.197587316
19:05:23 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=1000", 2310, 5.234376489
19:05:28 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=1000", 2298, 5.228407984
19:05:34 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=1000", 2122, 5.208801167
19:05:39 "old", "http2/compat.js", "duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=1000", 2128, 5.223415788
19:05:44 /w/bnch-comp/node/benchmark/_test-double-benchmarker.js:40
19:05:44     client.on('error', (e) => { throw e; });
19:05:44                                 ^
19:05:44 
19:05:44 Error: connect EADDRNOTAVAIL 127.0.0.1:12346 - Local (127.0.0.1:0)
19:05:44     at internalConnect (net.js:904:16)
19:05:44     at defaultTriggerAsyncIdScope (internal/async_hooks.js:416:12)
19:05:44     at net.js:992:9
19:05:44     at processTicksAndRejections (internal/process/task_queues.js:79:11) {
19:05:44   errno: -99,
19:05:44   code: 'EADDRNOTAVAIL',
19:05:44   syscall: 'connect',
19:05:44   address: '127.0.0.1',
19:05:44   port: 12346
19:05:44 }
19:05:44 Error: test-double-http2 failed with 1.
19:05:44     at ChildProcess.<anonymous> (/w/bnch-comp/node/benchmark/_http-benchmarkers.js:238:16)
19:05:44     at Object.onceWrapper (events.js:421:26)
19:05:44     at ChildProcess.emit (events.js:314:20)
19:05:44     at maybeClose (internal/child_process.js:1051:16)
19:05:44     at Socket.<anonymous> (internal/child_process.js:442:11)
19:05:44     at Socket.emit (events.js:314:20)
19:05:44     at Pipe.<anonymous> (net.js:655:12)
19:05:44 ++ cat output190620-170444.csv
19:05:44 ++ Rscript benchmark/compare.R
19:05:45                                                                                                confidence improvement accuracy (*) (**) (***)
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=100 requests=100         NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=100          NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=10 requests=1000         NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=100           NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=1 requests=1000          NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=200 requests=100         NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=100          NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=20 requests=1000         NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=100          NA       NaN %           NA   NA    NA
19:05:45  http2/compat.js duration=5 benchmarker='test-double-http2' clients=2 streams=40 requests=1000         NA       NaN %           NA   NA    NA

@lundibundi Maybe we can run the benchmark again, I've run it locally (OSX) multiple times with no errors.

jasnell · 2020-06-25T19:30:06Z

Pulling the author ready label off until the possible issues are explored

lundibundi · 2020-06-25T20:33:24Z

@rickyes another benchmark CI
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/627/

rickyes · 2020-06-26T01:45:45Z

@rickyes another benchmark CI
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/627/

@lundibundi There seems to be a problem with the benchmark on master, I only run the latest master benchmark ci and it gives me this error

./node benchmark/compare.js --old ./node-master --new ./node-master -- http2

rickyes · 2020-06-28T07:56:12Z

@rickyes another benchmark CI
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/627/

@lundibundi There seems to be a problem with the benchmark on master, I only run the latest master benchmark ci and it gives me this error
./node benchmark/compare.js --old ./node-master --new ./node-master -- http2

ping @jasnell Do we need to wait for the benchmark CI to be fixed before we can land this PR?

rickyes · 2020-07-02T03:43:41Z

ping @jasnell

rickyes · 2020-07-02T13:56:56Z

@rickyes another benchmark CI
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/627/

@lundibundi There seems to be a problem with the benchmark on master, I only run the latest master benchmark ci and it gives me this error
./node benchmark/compare.js --old ./node-master --new ./node-master -- http2

@lundibundi It looks like the master problem is fixed. Can you please start the benchmark CI again?

lundibundi · 2020-07-03T15:51:25Z

@rickyes https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/636/

rickyes · 2020-07-08T05:10:58Z

Very strange, I run normally on macOS, I find a Linux to try.

rickyes · 2020-08-03T13:40:31Z

This PR is at an impasse, waiting for #34598

rickyes · 2020-08-12T04:34:37Z

Benchmarks: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/660/

github-actions · 2024-05-11T16:57:58Z

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jun 17, 2020

rickyes changed the title ~~http2: Abstracting streams and session-related logic~~ http2: Abstracting stream and session-related logic Jun 17, 2020

rickyes force-pushed the refactor-http2-struct branch from e145c8a to aba2d82 Compare June 17, 2020 13:39

lundibundi added the http2 Issues or PRs related to the http2 subsystem. label Jun 17, 2020

mcollina approved these changes Jun 18, 2020

View reviewed changes

addaleax approved these changes Jun 19, 2020

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2020

jasnell approved these changes Jun 19, 2020

View reviewed changes

rickyes mentioned this pull request Jun 19, 2020

Extracts session and stream from quic/core.js #33969

Closed

addaleax approved these changes Jun 19, 2020

View reviewed changes

github-actions bot mentioned this pull request Jun 20, 2020

CI Relability 2020-06-20 JaneaSystems/nodejs-reliability#13

Open

34 tasks

trivikr approved these changes Jun 20, 2020

View reviewed changes

This was referenced Jun 21, 2020

CI Relability 2020-06-21 JaneaSystems/nodejs-reliability#14

Open

CI Relability 2020-06-22 JaneaSystems/nodejs-reliability#15

Open

This was referenced Jun 23, 2020

CI Relability 2020-06-23 JaneaSystems/nodejs-reliability#16

Open

CI Relability 2020-06-24 JaneaSystems/nodejs-reliability#17

Open

CI Relability 2020-06-25 JaneaSystems/nodejs-reliability#18

Open

jasnell removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2020

rickyes mentioned this pull request Jun 26, 2020

Benchmark CI run error: benchmark/_test-double-benchmarker #34061

Open

rickyes mentioned this pull request Jul 12, 2020

Running benchmarks tests on CI #34321

Closed

rickyes force-pushed the refactor-http2-struct branch from e558800 to 241d587 Compare July 25, 2020 02:40

http2: Abstracting stream and session-related logic

02c8610

rickyes force-pushed the refactor-http2-struct branch from 4a344c3 to 02c8610 Compare July 25, 2020 03:19

rickyes requested review from a team as code owners August 10, 2020 16:06

aduh95 added the blocked PRs that are blocked by other issues or PRs. label Oct 16, 2020

guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare March 29, 2021 21:33

Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49

aduh95 added the stalled Issues and PRs that are stalled. label May 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http2: Abstracting stream and session-related logic #33928

http2: Abstracting stream and session-related logic #33928

rickyes commented Jun 17, 2020 •

edited

lundibundi commented Jun 17, 2020

rickyes commented Jun 18, 2020 •

edited

rickyes commented Jun 18, 2020

mcollina left a comment

nodejs-github-bot commented Jun 19, 2020

rickyes commented Jun 19, 2020 •

edited

rickyes commented Jun 19, 2020

nodejs-github-bot commented Jun 19, 2020 •

edited by lundibundi

lundibundi commented Jun 22, 2020

rickyes commented Jun 22, 2020

jasnell commented Jun 25, 2020

lundibundi commented Jun 25, 2020

rickyes commented Jun 26, 2020

rickyes commented Jun 28, 2020

rickyes commented Jul 2, 2020

rickyes commented Jul 2, 2020

lundibundi commented Jul 3, 2020

rickyes commented Jul 8, 2020

rickyes commented Aug 3, 2020

rickyes commented Aug 12, 2020

github-actions bot commented May 11, 2024

http2: Abstracting stream and session-related logic #33928

Are you sure you want to change the base?

http2: Abstracting stream and session-related logic #33928

Conversation

rickyes commented Jun 17, 2020 • edited

Checklist

lundibundi commented Jun 17, 2020

rickyes commented Jun 18, 2020 • edited

rickyes commented Jun 18, 2020

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jun 19, 2020

rickyes commented Jun 19, 2020 • edited

rickyes commented Jun 19, 2020

nodejs-github-bot commented Jun 19, 2020 • edited by lundibundi

lundibundi commented Jun 22, 2020

rickyes commented Jun 22, 2020

jasnell commented Jun 25, 2020

lundibundi commented Jun 25, 2020

rickyes commented Jun 26, 2020

rickyes commented Jun 28, 2020

rickyes commented Jul 2, 2020

rickyes commented Jul 2, 2020

lundibundi commented Jul 3, 2020

rickyes commented Jul 8, 2020

rickyes commented Aug 3, 2020

rickyes commented Aug 12, 2020

github-actions bot commented May 11, 2024

rickyes commented Jun 17, 2020 •

edited

rickyes commented Jun 18, 2020 •

edited

rickyes commented Jun 19, 2020 •

edited

nodejs-github-bot commented Jun 19, 2020 •

edited by lundibundi