Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pipeline.js #34856

Closed
wants to merge 1 commit into from
Closed

Update pipeline.js #34856

wants to merge 1 commit into from

Conversation

Deepp0925
Copy link

@Deepp0925 Deepp0925 commented Aug 20, 2020 •
edited by rickyes

Fixes: #34842

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes (not needed)
  • tests and/or benchmarks are included (not needed)
  • documentation is changed or added
  • commit message follows commit guidelines

added a property index to error object in the pipeline function

@mscdex
Copy link
Contributor

mscdex commented Aug 20, 2020

Can you revise the PR to only include the actual changes (leaving out the pure code style changes)? That will make it easier to review.

@Deepp0925
Copy link
Author

@mscdex I am new to GitHub, so I didn't know how to make changes to this, thus I just created a new PR #34873

@Deepp0925 Deepp0925 closed this Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline error causing stream
2 participants
@Deepp0925 @mscdex